mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Huang Wei <huangwei@kylinos.cn>
Cc: Yogesh Gaur <yogeshgaur.83@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	syzbot+e7aa19176573a6992617@syzkaller.appspotmail.com
Subject: Re: [PATCH] usb: typec: ucsi: acpi: don't dereference a missing ACPI companion
Date: Mon, 21 Sep 2026 14:22:52 +0200	[thread overview]
Message-ID: <2026092130-thong-secrecy-1dd4@gregkh> (raw)
In-Reply-To: <20260921030346.1996820-1-huangwei@kylinos.cn>

On Mon, Sep 21, 2026 at 11:03:46AM +0800, Huang Wei wrote:
> Hi Yogesh,
> 
> I checked this over. The fix is correct - the sysfs bind path can
> indeed hand a non-ACPI platform device to ucsi_acpi_probe(), and
> adev->dep_unmet is the first dereference.

And that's the problem, don't do that.  Seriously, if userspace does it,
it deserves the pieces the kernel ends up in.  This isn't a kernel
issue, it's a userspace "do not do this" issue.

There is now a taint flag that gets set if userspace tries to do this,
showing us all what is really going on, so we can ignore reports like
this.  Also syzbot now should not be attempting foolish things like
this.

thanks,

greg k-h

  reply	other threads:[~2026-09-21 12:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20  9:07 Yogesh Gaur
2026-09-21  3:03 ` Huang Wei
2026-09-21 12:22   ` Greg Kroah-Hartman [this message]
2026-09-21 13:09     ` Huang Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026092130-thong-secrecy-1dd4@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=huangwei@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+e7aa19176573a6992617@syzkaller.appspotmail.com \
    --cc=yogeshgaur.83@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®