mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Minda Chen <minda.chen@starfivetech.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: usb: dwc3: Add JHB100 device controller PHY adapter
Date: Tue, 22 Sep 2026 18:15:29 +0100	[thread overview]
Message-ID: <20260922-colonize-uncaring-c604b3529275@spud> (raw)
In-Reply-To: <20260918071103.24482-2-minda.chen@starfivetech.com>

[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]

On Fri, Sep 18, 2026 at 03:11:01PM +0800, Minda Chen wrote:
> Add dt-binding of JHB100 server host field USB device controller PHY
> adapter register IO region and its regs-name.

I don't understand the rationale here or the other binding patch.
Why is it not always 2 regs? Either the device has 2 or it has 1, there
shouldn't be variability unless there's more than one instance and the
dfferent instances have different numbers?

Cheers,
Conor.

> 
> Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
> ---
>  .../devicetree/bindings/usb/starfive,jhb100-dwc3.yaml | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/starfive,jhb100-dwc3.yaml b/Documentation/devicetree/bindings/usb/starfive,jhb100-dwc3.yaml
> index fbabe99e9d5c..b2fd98c06ba0 100644
> --- a/Documentation/devicetree/bindings/usb/starfive,jhb100-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/starfive,jhb100-dwc3.yaml
> @@ -20,7 +20,16 @@ properties:
>      const: starfive,jhb100-dwc3
>  
>    reg:
> -    maxItems: 1
> +    minItems: 1
> +    items:
> +      - description: Core DWC3 region
> +      - description: DWC3 device controller adapter region
> +
> +  reg-names:
> +    minItems: 1
> +    items:
> +      - const: core
> +      - const: adapter
>  
>    interrupts:
>      maxItems: 1
> -- 
> 2.17.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-09-22 17:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18  7:11 [PATCH v1 0/3] Add StarFive JHB100 host field USB device controller driver Minda Chen
2026-09-18  7:11 ` [PATCH v1 1/3] dt-bindings: usb: dwc3: Add JHB100 device controller PHY adapter Minda Chen
2026-09-22 17:15   ` Conor Dooley [this message]
2026-09-18  7:11 ` [PATCH v1 2/3] dt-bindings: usb: dwc3: Add JHB100 USB device clock number limit Minda Chen
2026-09-18  7:11 ` [PATCH v1 3/3] usb: dwc3-generic: Add Starfive JHB100 USB 2.0 device controller and adapter Minda Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922-colonize-uncaring-c604b3529275@spud \
    --to=conor@kernel.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=minda.chen@starfivetech.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®