From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi2-f13.google.com (mail-oi2-f13.google.com [74.125.231.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CA79497B9B for ; Tue, 22 Sep 2026 18:46:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.205 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790102778; cv=none; b=FrpQ4MqvfNy3rLwAx7Mkd1ARwoLzAJzPx4aiEd4zI/12PHuP8mMeUEeun/vMeGB31MjQx1Vcv3Ck4XdcnlfGMHomiqPp63SQWNF9zKDmst565m+9GJGVXSfm6fnVBkq+cQLAHWsNOEq0YS6rJLeBY4idolvt3fCLnYfLECr7hNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790102778; c=relaxed/simple; bh=IuMpNgCx/wsRt/giACaxjy53WAUkwMR2mJuQ09sqhYU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SyP02XrefqdzpNhpzrK6V47GjclmgsTAGe7Nte3SgyfyYyuRvlWsd5tQVzOj6CAGMCdbK16LWlbpUyLCOo7MFb+uTY2FzsnqVznzoiLd9sYR+ExG16EK+1G+S9KJYPKzUtg8Xv1lk3yv+bFVyPXummTPBV7+kX9cxEj5Drt+C+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=scCWnbb0; arc=none smtp.client-ip=74.125.231.205 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="scCWnbb0" Received: by mail-oi2-f13.google.com with SMTP id 5614622812f47-4b37a2c0356so157462b6e.2 for ; Tue, 22 Sep 2026 11:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790102769; x=1790707569; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hvBW23f2UuBKO8svIifjsjiemFC1LwQ9bznHBbhEXQs=; b=scCWnbb0xhmsAtCfiaPQQ/PnR491Vl9Mgp36n3EjZOAeN9cpUrfc6YlI267aUQCQ+h Ycdr4njzS5rjrgnwDOVR2u8jSHx37FCQKlvJwxrwQgMqxjsbEuUsoAeFZDG3MY225Yhh ePDF3gnibux7M5Yz8RM77vJJ5iNtUA6AQs3OtCPKLlxZXqz5nmWyfYo+TlTyvUx24bZm PyWcj0GMGeogWSYhj4XvUumq5wkHOk9RhXGT/ctW1YMeEZEJDly5TqHf4U8o8KR4ytxG L1I9c4pt/BvCTUhWeA9qeIc7M3m0aQYq1X7vM3eR/FxIxkOLZgauIrDm+DOdLQ4IY4cW PDEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790102769; x=1790707569; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hvBW23f2UuBKO8svIifjsjiemFC1LwQ9bznHBbhEXQs=; b=wg/gwpe4tXKNPKBZWdqSVwAwLYU2WldzZm8kdY5DP0ublyPlmzqY6MTon8VN/30qc4 F2RWNcL9zLeC+harHXSENk5IyPOEdrdFKOoZayH//xovvqMRstsZIe7h/ld9ye42Fq8k 3mzjRkQgEKy/K2KBh9EAep4cr/I2y+bx86ehfyf6MtpLRpxsZD5+JiCW8b7PPZjHr1ZY SLltgdNGRQqFRp5RIe+SWMwcS7dSik4ktF6jVVg/yeQ5Wd5U8APILQeR+vA2SLOSncSD QTbK03wJ5lyIIVA7irgIy1zpwxWPEHMZ5DS4NTWKRZkEEyt6Grhj2VPDRG7ALVLd2OML +Hhg== X-Forwarded-Encrypted: i=1; AKwUvBxJYz5fsCgL2gx27vod57NmT33VWCz4kpLCq5YdiWZXc4lpBNwgxFf4B6RtCo65PFJVSU++x2JPvaH7RTM=@vger.kernel.org X-Gm-Message-State: AFuF++m+nxlb2LyJ2f0aWzgBV4/Vwk3zAMZA9xZKWA4Q/fWOgWecHO4s 0velSpnYtQIIpzPntJRtMikWbej++BsZKWgp4XnMoia0VjA/QWKDgIpY X-Gm-Gg: AYBFou0bH+u2R15S0SlyJjG0qCoXIitC45EbFfNmHIRdP/EPWagcGVtP8ovCcM3jI4g ++9Ds4w7cNcJtIsstuqMW5UDwzJUmkewxCIikEgUJZ9sF0zhgob9SqJXJtkESeppgHCHjuiaW54 8QsXBilbeT1HE4kts77RDIEXLgIVNngR5X4WiOhcUpRclBCUORs94u5Y/4c31NzNsg7OwW56Pp/ P1YDB/SOdYlxthUlClhQRYOmX5F3GJ0AznLr+K9Ewe/3V/ZLDkSlTmbf/jbuGNTVEo9X4l7Yini I/ydSgzJwa5JsKacpjK2qaerCFttITzGZz4iKaRJSxaxdIsUeKZIbnfPKDXClC/STs21TaoU3WO YKrDf9cc6hrYpPVewcoMP+8bllXVCaVv/8AthsT3CxBwNkhoaSCd0VIg4htIUmkCws09H/GKH/8 pQpf9rwVju2ato0RWuWo4wEZbUUeXoVX6ypOykfE0IBzKd+174dQNfw1mrvOxL8SXKqTxL3rHCW J/vH+yiJR6uyJJaxATDDS3x7dsothvjQmEMmaDWHKofSWKJqzVEkbbC2vrH7Ns3QBWSsUGkslCM YT/MTtkx6TMoIHlW4j4TZ8Q+P2HrUnI= X-Received: by 2002:a05:6808:14d1:b0:4b9:e65b:8c33 with SMTP id 5614622812f47-4d5b8cd7d75mr333208b6e.33.1790102768645; Tue, 22 Sep 2026 11:46:08 -0700 (PDT) Received: from [100.82.231.29] (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 5614622812f47-4d5c43a24bbsm147545b6e.7.2026.09.22.11.46.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 11:46:08 -0700 (PDT) From: Jim Cromie Date: Tue, 22 Sep 2026 12:45:58 -0600 Subject: [PATCH v3 4/4] kallsyms: Unroll 24-bit sequence reconstruction in get_symbol_seq() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260922-ksyms-tune-v3-4-681a34ea05d9@gmail.com> References: <20260922-ksyms-tune-v3-0-681a34ea05d9@gmail.com> In-Reply-To: <20260922-ksyms-tune-v3-0-681a34ea05d9@gmail.com> To: Andrew Morton Cc: Lorenzo Stoakes , Kees Cook , David Laight , Masahiro Yamada , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, bpf@vger.kernel.org, Jim Cromie X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790102761; l=1647; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=IuMpNgCx/wsRt/giACaxjy53WAUkwMR2mJuQ09sqhYU=; b=yS/yGjzOac4hLV4AjSFZ5EelcHRPIABxP3zNa55tRBvDMQ9hjwXNYUKY/aAcVbDC1o5X/qkv+ VdoviOApkczAe37evfvRkm/lYAf+lj76e/eHBTzZCKBe70sD1vYOqhi X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= kallsyms_seqs_of_names[] stores 3-byte big-endian sequence indices that map alphabetical symbol positions to address-ordered symbol records. Currently, get_symbol_seq() reconstructs each 24-bit integer using a 3-iteration for-loop that shifts and bitwise-ORs each byte sequentially. During binary search in kallsyms_lookup_names() and duplicate boundary scans, this loop introduces branch and loop overhead on the hot lookup path. Mark get_symbol_seq() as static inline and unroll the 3-byte extraction into direct byte shifts: (p[0] << 16) | (p[1] << 8) | p[2]. This eliminates loop induction variable maintenance and allows the compiler to generate direct loads and constant shifts. Signed-off-by: Jim Cromie --- Changes in v3: - Added as a standalone micro-optimization patch (addresses David Laight review). --- kernel/kallsyms.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c index 06c79ad70cfd..8f76403e0e7b 100644 --- a/kernel/kallsyms.c +++ b/kernel/kallsyms.c @@ -281,14 +281,11 @@ unsigned long kallsyms_sym_address(int idx) return (unsigned long)offset_to_ptr(kallsyms_offsets + idx); } -static unsigned int get_symbol_seq(int index) +static inline unsigned int get_symbol_seq(int index) { - unsigned int i, seq = 0; + const u8 *p = &kallsyms_seqs_of_names[3 * index]; - for (i = 0; i < 3; i++) - seq = (seq << 8) | kallsyms_seqs_of_names[3 * index + i]; - - return seq; + return (p[0] << 16) | (p[1] << 8) | p[2]; } static int kallsyms_lookup_names(const char *name, -- 2.55.0