From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93BCF54854A for ; Tue, 22 Sep 2026 12:57:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790081876; cv=none; b=ERMmqlf5g870EQbF+YAdLlk7yUq524wKnlCdkEglaRlOwkHCHZPKAFqFmMX6NT6hQnCgrJH36xDfNUnl4MtmTxAa4j2ne4M+o17KqSIP04zpXLuTEk8kawUCDGWKD3sNzruDisGZxlD3i5To7xd5NcpjbQMDU/XTcScVwra8Ixw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790081876; c=relaxed/simple; bh=xyzdu2q1tpL6mhFPCDTUidWRkkUpI2PcImyNjPq2sLw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=X5vB9tpgwFLDFyKKO68DwcQaGg7fihL0Jvsl6wzU72qKg9OILQ+U7KN9NVEOGP7aD0bmLdQldPu5FZiQiWPVzT8xOkbrVKqxSFPazmetTlgK6WQv8p2K8KK9c57U3vmNbCZvjDPzb9D8TtRnPr4orCIsExTNDAAOnq6cVUgYWvY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oCxyr3Bu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LkRwaJ2A; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oCxyr3Bu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LkRwaJ2A" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68MBOvoS984483 for ; Tue, 22 Sep 2026 12:57:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QSt7Om/WARb9DD7M+LNLPO3I5eWJQD69hsyVLSKhInE=; b=oCxyr3Bu8iz//duf BM1TVeZjNJ5TfEbv1Ld4WEg2cKlJHM0PHEnczyPU93E7Ei7YbL7yP4wgcu+BiQ2H BNhQJQ1ASXPT/fSITM/KhArSEwFxV6kBFYYksQft+uzebf3Z8OEw80Vf+UEd26vz C5GBoPuXPM5hgcDVspnAjz0Vj75q1ELm57+YwkNehBKwK5rjDc3AxVQDBivWJNMc tdY76vmqfM0SCcLtYpXNOZwyXqGa0KwbwJ3PHT3UFQHHMVzjlJGeOcHEQNiDGTgv PRnknhLXVx4/EKqL9sGQqAhvzcYzbfoKgdzYyjm3xbMZNYkTQ6j1PWKp+WM/ncdb 2JG/NQ== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4guqk4rp04-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 22 Sep 2026 12:57:53 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-5c7c0d2b0aaso1982267e0c.1 for ; Tue, 22 Sep 2026 05:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790081873; x=1790686673; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QSt7Om/WARb9DD7M+LNLPO3I5eWJQD69hsyVLSKhInE=; b=LkRwaJ2AHTdbHS4aVIaaON0wxFX8csoWygTVI6YrWEK72egpQBsGTWsGVLEniKT/je gPxT+0wu+kU7tCcji7qv2m3HHsa2rXMGPUvzkDlSGp8ioDWcqTGBA1fyUHnUKOog7fC7 mmlrJ45YJzLffZ2+svSCAJo+H6VWoT4FPRfBhZxqUbFejSAYYhRPJ/+09dPF8wzaZP0W hvFQgcLqT82lDgeSpcufVap1RjjX4bvoUD8jGfArg4OwthjcZkcNhyxk1F938/lA6E47 xsyas7kAK78yPOAYF9HZzA/evCcU5gkFzrHzSpub1DCb+YtMI7fuYPnxs0vluMbPHJtT bgXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790081873; x=1790686673; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QSt7Om/WARb9DD7M+LNLPO3I5eWJQD69hsyVLSKhInE=; b=vL23Qc6cwvj/4aiNftMale2sEO1S5csaVVjZjp+QVjUN+OP101HEkKgYB/6+vDSQL0 QmORb8yMkfuB7A3wKH2TUI8mPxfpJSNKPkSVGloloQNLtr+zK0TEPaRfPybmGRfPf0mi z5xgqiRAeFzFzrbEMISih+QxBJa4s61DPX7CzbXoUP4XudA++XH7mI4BfM26FgVGkxY5 Fa0xPr/xvWCEfy4LmnoRW89QYL1CWJUK03yDPALU4fzUrGejhH/mwU/JGhYlvoBHslIs vwP6TyDNId6Z07PjUjTnJYcWpEmyhhQF6DszZDl1XMoANYQJyJFyap9Aps07y8RBo+jx RU7Q== X-Forwarded-Encrypted: i=1; AKwUvByvc1i2m5pEPNJz53fNI9SrGVdWmUaWSfvxrzoSlIEiM7MR6dKZgSxl4wjvZ2snitcJXmiojhlIUP+3r3o=@vger.kernel.org X-Gm-Message-State: AFuF++m8Vbd4BWOylCCsB52CQhcfK/TXtHuxS24kW7F0XZv7qqI6U/vl W4OF5Q5nTBQlSVmuAeFXwAM3qAlttjXk62zW4QZX7dWms9Pjs9mStFxvfgll8VwvoSDXx+k67zP B69pJV7k9HrZeuNDCUtUEROOaYFD4510EXJ/0EyigG3qC1jkyj08zbrDuMtEUgGc/4Bw= X-Gm-Gg: AYBFou3JfsPCHBD1d1ySBgYCf5L/grLovVM98RZS0bQDqUB1QF9B1WC2IZRrtph3onv 6dj8i3DLQvyTZhzuJ0kBEElVpHp6EQ9cy+M2fAwmGFupe47vwAhqk7X5sQwI891rOs2Yj3E0u60 CyQitz2qvRxHCXn/RVS9BITUxP/I7YQWtYLajLr/p3R33qAoI/G29pvBT5F0zFX1Anexi7nNryt DtukkTx6Ajjl7kvOvDBjlQFSqO2I5CH59zypku6HIWwvXGg1EObRj8R0o16Vk1FmK9rD8+26SYU g67CdVaxOQWphjpT4FNCS+8m3Vl1cPRNNT0dp0Ulp1yniJU76m9StzJSUgy7ib/sykosaapKlEO 64zmdXNRylSXYb7kTYl8PwpRxFrQ= X-Received: by 2002:a05:6122:8d1:b0:5c9:c60a:e9ae with SMTP id 71dfb90a1353d-5c9c60af4d9mr5452818e0c.20.1790081872734; Tue, 22 Sep 2026 05:57:52 -0700 (PDT) X-Received: by 2002:a05:6122:8d1:b0:5c9:c60a:e9ae with SMTP id 71dfb90a1353d-5c9c60af4d9mr5452788e0c.20.1790081872310; Tue, 22 Sep 2026 05:57:52 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:5105:ff9:e148:c440]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6aaa4537b5dsm1097669a12.30.2026.09.22.05.57.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 05:57:51 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 22 Sep 2026 14:57:19 +0200 Subject: [PATCH v9 04/14] crypto: qce - Use a fallback for AES-CTR with a partial final block Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260922-qce-fix-self-tests-v9-4-b1aa742e79af@oss.qualcomm.com> References: <20260922-qce-fix-self-tests-v9-0-b1aa742e79af@oss.qualcomm.com> In-Reply-To: <20260922-qce-fix-self-tests-v9-0-b1aa742e79af@oss.qualcomm.com> To: Thara Gopinath , Herbert Xu , "David S. Miller" , Stanimir Varbanov , Eneas U de Queiroz , Kuldeep Singh , Eric Biggers , Demi Marie Obenour , Bjorn Andersson , Konrad Dybcio , Russell King , Abel Vesa Cc: linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, brgl@kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1764; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=xyzdu2q1tpL6mhFPCDTUidWRkkUpI2PcImyNjPq2sLw=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqsns5UtvWLW6lIYAfah148jHNJ/4S50XpACUQe 12MNVv0xeKJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCarJ7OQAKCRAFnS7L/zaE w28DD/9nfSdD+17cgYjPaGe5HJAgXHxftzNagDQJH7cEhX9vMt2Mbk+DuGFFwD9Q20XZyUyipgr CMs2cyMfWynkJsBRHA+hM2oMBL7xhii8d6+WvWRd9bx0nun1NS81+DB7DbCaqxLnKe6z4cC9jxW cpNQ1e8YXfvZ400M5Uc0xALSJLJZKMg8mPje4uDSj0tRaRQDp8MTXT47Sq+YzLEN6EKZRLgSrfg U0Oof9KZJutCTjYN3iQ8YZAY84vnJ/Wthr69++YkItEvgzFpDjYm0Gu6Z2F4Q2w6TEzNEMQR55U 4V/4D9X4cDxRLXF0/HCo3S0IVV4Hf4Sb5m52tqV+/kviEcwJFm+2ENiG5e0GJ0Cl2oIIQJ2+EPP WQIXBnI7Nkb48ZswP56iVZpbCw6y7Qqi4RaaoxjLkcYNtXHtVtVZD9jrpN2z80OAoiA0dslO1Qu CyIGFZmWvvID54Ciehq0raOUB0fuDtTojLs/v7xv2VGBYThETFvIVOzIlyiNs70Xgcx+F6q7ss0 7gxW9MyHtj3dJim1PSnVkTwU5VjCQ/7kCLpYDxwFjT/jBE00AB1CCNl08sBcL9wY9L72/kI8N7o lVC6AvNYXTB+q5bQ7HNr4cuu53xXf5cjVOdJEjo8UobUDHg39ohLUo8sb/AXBTFb7lJuxZeJXfF XQSr60V2vwRoCqg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIyMDE4NyBTYWx0ZWRfX8SegXkY5gUkS MXvxP0gROyDyvKcWoJSIVGf6TvFnFB0g3XNiFp9pYGlwALhVGXnRZNWdZOaNQPVZYBDOHbaR+6D vzIW79EwMqRbLAu5f2zle6VhXyqbVaAXZdXgL2iekc5f0ObktkoURaWlWG7GFy8r7Ug6q9NgQM7 D5huQl5FJXaF31DDbhEkD+S8+Fbf6lGsjP0Iv7eSHwb4nNdE6ecqXWSlXy89eebDVvpUdvbbpBY piDFaKn60ogR+/p/DZUZ/AlNorA/XAY1rjDeF1uq4AmLtNcWAAlk2ZE5d+4MoFQisxWFRq2uMmh BBpMxaeIetLuoWxqYHENsvSW+/98JTguo/0ypsgX4yvQhqIAw20vxtziOSCrJU1kAIfUvN04nMX iVw6eTSTGAsN4E8bt0STyadKcSdPPuYV+X49mC18PFegGmN7OOEFyka44ymulePqqnqmPDB5Dv7 ucQabY3U3PsBrFMFR0A== X-Proofpoint-GUID: rCHw1ABy63D0pOUZQGxcWiPv-dAweuOu X-Proofpoint-ORIG-GUID: rCHw1ABy63D0pOUZQGxcWiPv-dAweuOu X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIyMDE4NyBTYWx0ZWRfX8MhpyY9iBuuM MVu2Ex4n5OZMX4sSkD4nXk7qIQ8Tjd01pNjBZGu7pjFYkCKy7VwGAhyrcYF0SgK+tDG7AltblD+ 4w9XBw3+odksNBIBylil8bAKnzACNQw= X-Authority-Analysis: v=2.4 cv=XrVvqlF9 c=1 sm=1 tr=0 ts=6ab27b51 cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=vUpbTSJP45I4i0_vGVUA:9 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-22_01,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609220187 ctr(aes) is registered with a block size of 1, so the crypto API hands the driver requests whose length is not a multiple of the AES block size. The crypto engine, however, stalls waiting for a full block of input in that case, leaving the operation incomplete and failing the request (and the crypto self-tests) with a hardware operation error. Route AES-CTR requests with a partial final block to the software fallback, which already handles the other cases the engine cannot. Cc: stable@vger.kernel.org Fixes: bb5c863b3d3c ("crypto: qce - fix ctr-aes-qce block, chunk sizes") Tested-by: Kuldeep Singh Signed-off-by: Bartosz Golaszewski --- drivers/crypto/qce/skcipher.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c index ec2f21446cee9dd4a5e3a73879925ebbcafe0548..27ce87be2029d896fd987608f091084ac64f5185 100644 --- a/drivers/crypto/qce/skcipher.c +++ b/drivers/crypto/qce/skcipher.c @@ -259,9 +259,12 @@ static int qce_skcipher_crypt(struct skcipher_request *req, int encrypt) * AES-XTS request with len > QCE_SECTOR_SIZE and * is not a multiple of it.(Revisit this condition to check if it is * needed in all versions of CE) + * AES-CTR with a partial final block (the CE stalls waiting for a full + * block of input). */ if (IS_AES(rctx->flags) && ((keylen != AES_KEYSIZE_128 && keylen != AES_KEYSIZE_256) || + (IS_CTR(rctx->flags) && !IS_ALIGNED(req->cryptlen, AES_BLOCK_SIZE)) || (IS_XTS(rctx->flags) && ((req->cryptlen <= aes_sw_max_len) || (req->cryptlen > QCE_SECTOR_SIZE && req->cryptlen % QCE_SECTOR_SIZE))))) { -- 2.47.3