mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pengpeng Hou <hppiscas@163.com>
To: b-liu@ti.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	s.nawrocki@samsung.com, kishon@kernel.org, balbi@ti.com,
	tony@atomide.com, hppiscas@163.com
Subject: [PATCH v2 0/3] usb: musb: omap2430: handle PHY setup failures across PM
Date: Tue, 22 Sep 2026 08:44:11 +0800	[thread overview]
Message-ID: <20260922004414.4192-1-hppiscas@163.com> (raw)

The OMAP2430 glue has three unchecked PHY setup sites: initial setup,
runtime resume and system resume. This v2 resends them as one threaded
series, as Greg requested, and closes the shared reference-ownership gap
before adding the remaining error propagation.

Patch 1 records initialization and power references independently and
uses common helpers in init, PM and exit. Patch 2 stops runtime resume
and mailbox work when resuming fails. Patch 3 reports normal system-resume
failure while ending the temporary I2C/SPI PHY deferral, allowing a later
runtime resume to retry.

The existing phy_suspended flag controls system-sleep ordering, not
resource ownership. Keeping those roles separate avoids double-release
on another suspend or platform exit after a failed resume. A release
failure retains its ownership flag rather than silently discarding it.

The three original setup sites share this lifecycle machinery. They are
not three independent proofs of hardware faults, and this series does
not address errors hidden inside individual PHY providers.

The issues were found by our static-analysis tool.

Changes since v1:
- resend with all three members replying directly to this cover
- share reference tracking across init, runtime PM, system PM and exit
- account for a cleanup operation itself failing
- stop mailbox access when runtime resume fails
- retain needs_resume until early resume succeeds and end system PHY
  deferral after normal resume even when setup fails

Previous series:
https://lore.kernel.org/all/20260906034149.85550-1-hppiscas@163.com/

Pengpeng Hou (3):
  usb: musb: omap2430: track PHY references and check initial setup
  usb: musb: omap2430: stop runtime resume after PHY setup failure
  usb: musb: omap2430: report system-resume PHY setup failures

 drivers/usb/musb/omap2430.c | 123 ++++++++++++++++++++++++++++++++++++++------
 1 file changed, 107 insertions(+), 16 deletions(-)

base-commit: f0100363d8c374bd8e9ea7c9ba02744f0b802ca4


             reply	other threads:[~2026-09-22  0:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22  0:44 Pengpeng Hou [this message]
2026-09-22  0:44 ` [PATCH v2 1/3] usb: musb: omap2430: track PHY references and check initial setup Pengpeng Hou
2026-09-22  0:44 ` [PATCH v2 2/3] usb: musb: omap2430: stop runtime resume after PHY setup failure Pengpeng Hou
2026-09-22  0:44 ` [PATCH v2 3/3] usb: musb: omap2430: report system-resume PHY setup failures Pengpeng Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922004414.4192-1-hppiscas@163.com \
    --to=hppiscas@163.com \
    --cc=b-liu@ti.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®