From: Jonathan Cameron <jic23@kernel.org>
To: Janani Sunil <jananisunil.dev@gmail.com>
Cc: "Janani Sunil" <janani.sunil@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Linus Walleij" <linusw@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Michael Walle" <mwalle@kernel.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
linux@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>
Subject: Re: [PATCH v8 00/17] iio: adc: Add AD7768/AD7768-4 ADC driver support
Date: Tue, 22 Sep 2026 01:13:36 +0100 [thread overview]
Message-ID: <20260922011336.3a52aa05@jic23-hlaptop> (raw)
In-Reply-To: <457da50e-a633-4508-a8e9-7e000933623c@gmail.com>
On Mon, 21 Sep 2026 10:46:41 +0200
Janani Sunil <jananisunil.dev@gmail.com> wrote:
> On 9/21/26 02:37, Jonathan Cameron wrote:
> > On Wed, 16 Sep 2026 13:13:49 +0200
> > Janani Sunil <janani.sunil@analog.com> wrote:
> >
> >> Add support for Analog Devices AD7768 and AD7768-4, 24-bit simultaneous
> >> sampling Sigma-Delta ADCs with automatic power mode selection.
> >> Changes in v8:
> >> - Introduce the DCLK divider helper in the core patch to avoid moving its
> >> register-programming logic later in the series.
> >> - Document why register caching is not used
> > Other than open question on regcache vs volatile registers
> > this series looks good to me now. So let us get that resolved
> > nice and quickly. If it turns out regcache can be used I don't mind
> > just tweaking that comment for now and taking a follow up patch to
> > turn regcache on when you have it ready.
> >
> > Jonathan
>
> volatile_reg would handle the live GPIO and status registers. I will remove the regcache sentence from the comments, leaving just the SPI framing explanation. I'll look at enabling regcache in a separate patch.
I was in process of taking this series and applying that tweak
so you could build on top and found something curious.
The ad7768-1 driver. However, I asked claude to tell me if they
were similar and indeed it provided a bunch of evidence
to support your statement that they aren't that close.
So fair enough and someone should talk to your chip naming
department :) Applied to the testing branch of iio.git for
the bots to take a look.
Thanks,
Jonathan
>
> Best Regards,
> Jan
>
prev parent reply other threads:[~2026-09-22 0:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 11:13 Janani Sunil
2026-09-16 11:13 ` [PATCH v8 01/17] iio: adc: adi-axi-adc: Initialize state mutex Janani Sunil
2026-09-16 11:13 ` [PATCH v8 02/17] dt-bindings: iio: adc: Add AD7768 Janani Sunil
2026-09-16 11:13 ` [PATCH v8 03/17] iio: backend: Add support for CRC Janani Sunil
2026-09-16 11:13 ` [PATCH v8 04/17] iio: adc: adi-axi-adc: " Janani Sunil
2026-09-16 11:13 ` [PATCH v8 05/17] iio: adc: Add AD7768 and AD7768-4 core support Janani Sunil
2026-09-21 0:31 ` Jonathan Cameron
2026-09-16 11:13 ` [PATCH v8 06/17] iio: adc: ad7768: Validate master clock rate Janani Sunil
2026-09-16 11:13 ` [PATCH v8 07/17] iio: adc: ad7768: Add power mode helper Janani Sunil
2026-09-16 11:13 ` [PATCH v8 08/17] iio: adc: ad7768: Derive output data rates Janani Sunil
2026-09-16 11:13 ` [PATCH v8 09/17] iio: adc: ad7768: Configure channel sampling profiles Janani Sunil
2026-09-16 11:13 ` [PATCH v8 10/17] iio: adc: ad7768: Add sampling frequency controls Janani Sunil
2026-09-16 11:14 ` [PATCH v8 11/17] iio: adc: ad7768: Add per-channel filter controls Janani Sunil
2026-09-16 11:14 ` [PATCH v8 12/17] iio: adc: ad7768: Wait for digital filters to settle Janani Sunil
2026-09-16 11:14 ` [PATCH v8 13/17] iio: adc: ad7768: Add calibration controls Janani Sunil
2026-09-16 11:14 ` [PATCH v8 14/17] iio: adc: ad7768: Add per-channel conversion delay Janani Sunil
2026-09-16 11:14 ` [PATCH v8 15/17] iio: adc: ad7768: Add VCM regulator support Janani Sunil
2026-09-16 11:14 ` [PATCH v8 16/17] iio: adc: ad7768: Register GPIO auxiliary device Janani Sunil
2026-09-16 11:14 ` [PATCH v8 17/17] Documentation: iio: Add AD7768 Documentation Janani Sunil
2026-09-21 0:37 ` [PATCH v8 00/17] iio: adc: Add AD7768/AD7768-4 ADC driver support Jonathan Cameron
2026-09-21 8:46 ` Janani Sunil
2026-09-22 0:13 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922011336.3a52aa05@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=janani.sunil@analog.com \
--cc=jananisunil.dev@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=mwalle@kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=p.zabel@pengutronix.de \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®