From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA285490BE0 for ; Tue, 22 Sep 2026 05:44:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790055850; cv=none; b=Hd9aWEFXrWLhEabsrj+LnmZQoZ1RpQyvQqxX8UYH9bNs0QJmUU+D83gisRm3CQs64D+rztK1DgwIloeUrWqQtwMFD7AM8DOPfDjfw7BwA9p2h+pt0QUA6hKosSmMljb2r5BB/BgiO4aV05mf4Pg0nnEgf61LDApu55tTmMZ/uDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790055850; c=relaxed/simple; bh=VJcogttpnzmzRq+dZ9JiW+yKGA10LOl2AIc4TKpIVUo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Fju8YAB4hKzVfmLUm5TeX3l0R06BH8S6pIM/RI8MumzENXE1mNjL9S0RkC9XMGDqY0inmEg0ZTortL0y0kHdadN9UvWtNUiTAI+NLaf/nuZkNtQ7k/jaH3em7yHi3xZxhiGQ+zjL4j31OIEb6iRV2KG7zUqK796dkpPnLocWgMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TbGJvfPk; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TbGJvfPk" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e69b9e16aso37625115e9.1 for ; Mon, 21 Sep 2026 22:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790055847; x=1790660647; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=d4/LQ+6F9fJ/cjcJrUOPJx6DRMexHTJtKczEX1e75B0=; b=TbGJvfPkvAZRo+LXDcLV+l5pniWtNlBS654EvABd+F3nV86+Z8qz99YCO0T8HIMDB3 p6AeTXRjx8Aw0QXeHtgutrtPy/o+ur6Nv0suElnopeNjBhs5IgMeuQuhKK0/CPM2JaQT GgSRntQZkDZQ6s3AJQJtvN0aJPuJOgGxixUPcRIgJXWYZ3k31zALrwwcrbvS1QqkTO4+ 85H1uTrVHhSarB1f3OyUKmemfeieGICLetaFog5iBq8Zx2AA7Mi4UY4JnL+TrfrF2zg1 i+v0ihWMd3eThlOlci+Q1ZGnR08cBp4/N6bhT1Q6fNouo85BCiwSNBiyazKMGKy8c/DY eJRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790055847; x=1790660647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=d4/LQ+6F9fJ/cjcJrUOPJx6DRMexHTJtKczEX1e75B0=; b=I3n2mDlemRnb2EalbwCC0MUqVU27QMsaDK2ZxcEnoanLTzHxL6hl9FD4uIg5YOAgL9 pEbBvDcJw3WeitkNs8leK24fLfQ/QoJJgiLQZbbAUM2T8pHZ65NgkA/j/A85tuTT/qL+ z1CmrYyC0jxP/16jUzCGAO30+wTv2RvpySjSg+Upi2tYW9EkNjJrQBW8IS6StwGEgb4L RrRej+Eh/CnfZAS984/O+sSpVNfg80Cvv71l+9teQvqIz9xjA+hpzUeu/jKAFmXrjwN+ qy+nrVw8y8MKrTrdTT4FrrqvNs5bn/6/51x1bhRGloqiFKiVTJcAfIAkrgDC1VO6OTPt rFdQ== X-Forwarded-Encrypted: i=1; AKwUvBzawtQ5LRiOf+S/kuXXx0RlExAp6BsrUe5tVRdFYgd8TM6mp6tR2+nrZ87xYNRicodM4+92dxuKFrTfgUE=@vger.kernel.org X-Gm-Message-State: AFuF++lIqEK13w4YHqacwv9KgrePap+H2hDBMawx0+W8Szpv9262GNNR UmANmpDVe/hh7k/JeTmIAhxlBB90proSRTV57PE2QhVr8GWdE7jlt4gs X-Gm-Gg: AYBFou1LgGatWpU3lMvrSMIyRnQYgKNkk2dKPJVaxX30sJjI1fP887mpIu1c9WD/8IX VFDQYwBlY6gd7LTPpYXuJmV1PYmyK+sp530WOFqVwRDM0Fc3cw6yTgbGjvQdqB5dHYlvIjC9I6b ymMJoACHff1RyLCwWmzh+VBd9ykVrJ9YxnQwhlB9h7VogfPrTSW/mvOHFEB4ITBWwxHFvJKpmLZ USUQyutoZ30KrPYU9gVTRi3d/kA1WwRWgNf+AIrV+TqHx8I2TMNRdoUpZKxTCUg0A96t7FcBz6A JW/WQXnGMwXCJlZRIbgiN2EKX5CmQ5rPpZ3V5io2o9Ufc78+3fTuSdxOsSBUzqgmSlcxv3kIHYw mzTpSIpODhsI2gHHMgsyLSOqtlo9dFECtbzCLExj6QpxOeDS6rgoVxF5MRN1K4TgbGJRTPo7R0b we87MU5tbHkDTYPl6+1utgICYq6jGABu8Zyggjuq16ppJ+Y0xkW7WIgoKgXCN1CsCO+2/+SRaZa +t1xs8P6CsQNEqk3PSGE8fJ4cYFgGzQ4PED6KFWvxSPL9A8WWuqdOplaKAJ5Oh0wePJa5M7FyS+ U3AMhbMVuBmHcM3ea/ikV741g3wDaL0Na/pyR7X+ZbRGslIX9v1cASF8YmO2RWUfTKI/+A6JnGq L X-Received: by 2002:a05:600d:848f:10b0:49d:827:e5b6 with SMTP id 5b1f17b1804b1-49fc5735351mr124626255e9.20.1790055846765; Mon, 21 Sep 2026 22:44:06 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-a5e6-3401-ecdc-1e24-2e52-02d6.310.pool.telefonica.de. [2a02:3100:a5e6:3401:ecdc:1e24:2e52:2d6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fd8a638fcsm47621575e9.0.2026.09.21.22.44.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 21 Sep 2026 22:44:06 -0700 (PDT) From: Karl Mehltretter To: Eric Biggers Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Ard Biesheuvel , "Jason A . Donenfeld" , Herbert Xu , linux-riscv@lists.infradead.org Subject: Re: [PATCH 19/20] lib/crypto: riscv/aes-ctr: Migrate optimized code into library Date: Tue, 22 Sep 2026 07:44:01 +0200 Message-Id: <20260922054401.19194-1-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20260921050910.296144-20-ebiggers@kernel.org> References: <20260921050910.296144-1-ebiggers@kernel.org> <20260921050910.296144-20-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, 20 Sep 2026 22:09:05 -0700 Eric Biggers wrote: > -// void aes_ctr32_crypt_zvkned_zvkb(const struct crypto_aes_ctx *key, > -// const u8 *in, u8 *out, size_t len, > -// u8 iv[16]); > +// void aes_ctr32_crypt_zvkned_zvkb(u8 *dst, const u8 *src, u32 len, u8 iv[16], > +// const struct aes_enckey *key); > SYM_FUNC_START(aes_ctr32_crypt_zvkned_zvkb) isn't this a sign extension problem on rv64? The psABI sign-extends 32-bit args, so for len >= 2G a2 comes in as 0xffffffff8xxxxxxx, and the asm uses it as a 64-bit length as is. That would run off the end of both buffers. Nothing passes that much in one call today, but aes_ctr_arch() only chunks down to 0xfffffff0 and aes_ctr() takes a size_t, so it is allowed. The old prototype was size_t and the caller zero-extended. Thanks, Karl