From: Yixun Lan <dlan@kernel.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: alex@ghiti.fr, aou@eecs.berkeley.edu, conor+dt@kernel.org,
devicetree@vger.kernel.org, krzk+dt@kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
palmer@dabbelt.com, pjw@kernel.org, robh@kernel.org,
spacemit@lists.linux.dev
Subject: Re: [PATCH 1/1] riscv: dts: spacemit: set ETH MAC from eeprom for OrangePi
Date: Tue, 22 Sep 2026 07:29:10 +0000 [thread overview]
Message-ID: <20260922072910-GKB353745@kernel.org> (raw)
In-Reply-To: <20260922065001.1888961-1-amadeus@jmu.edu.cn>
Hi Chukun,
On 14:50 Tue 22 Sep , Chukun Pan wrote:
> Hi,
>
> > Could you point me where the u-boot patching the MAC address?
> > I'm not fully aware of this problem..
>
> This is handled by U-Boot's fdt_fixup_ethernet() function:
> https://github.com/u-boot/u-boot/blob/main/boot/fdt_support.c#L639
>
> do_bootm_linux()
> |
> boot_prep_linux()
> |
> image_setup_linux()
> |
> image_setup_libfdt()
> |
> fdt_fixup_ethernet()
>
So checked the code, it's not a direct problem of /alias, but due to the
env variable provided to override the mac address, see
https://github.com/u-boot/u-boot/blob/main/boot/fdt_support.c#L698
tmp = env_get(mac);
if (!tmp)
continue;
In this case, I don't think it's necessary to drop the ethernet alias,
I mean it's totally fine if there is uboot ethaddr env and it wins
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2026-09-22 7:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 10:00 Chukun Pan
2026-09-21 12:42 ` Yixun Lan
2026-09-22 6:50 ` Chukun Pan
2026-09-22 7:29 ` Yixun Lan [this message]
2026-09-23 6:40 ` Chukun Pan
2026-09-24 1:23 ` Troy Mitchell
2026-09-22 8:55 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922072910-GKB353745@kernel.org \
--to=dlan@kernel.org \
--cc=alex@ghiti.fr \
--cc=amadeus@jmu.edu.cn \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®