From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 783CA539764 for ; Tue, 22 Sep 2026 11:03:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790075000; cv=none; b=RsMSXeF9sGYwNsCDk2UWYNorJjaQdZDLac+P6eHpQekrAh4mRDfyg613p0ZHS7UfwCY1Ys5BwwvuiLtf7p0e0/5rEoi2h+MdL0b4uI5b/sVk3iqpB5+Ng3Ilmi8TBnjAInUZIndEPZBQlodHXcBmGfBGnNEL4NA9wMTrKsgzrfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790075000; c=relaxed/simple; bh=AKXo4HFyGH+qOtzhSzfVmyUzvAxDbIKAOw+B0wfwJ/s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=er8FjU8kFkQwAV+RePkyVDDYGGItwqlt1WwmQCz+0+lEtmSoAGKANNCGSubhpD8/U+PFbwi/0Ghf3qzPSKvhzN5NbYa/oN8yhL1BZAtiHS/eIuJYwCZmOPfMWCdC+YWQZPqjcJDO20rKLMcRXbb2UPthLrY0uz9II4AnvzAa/zE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lex.la; spf=pass smtp.mailfrom=lex.la; dkim=pass (2048-bit key) header.d=lex.la header.i=@lex.la header.b=Re0GYu4S; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lex.la Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lex.la Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lex.la header.i=@lex.la header.b="Re0GYu4S" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49ccf3ca626so20560855e9.0 for ; Tue, 22 Sep 2026 04:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lex.la; s=google; t=1790074998; x=1790679798; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AKXo4HFyGH+qOtzhSzfVmyUzvAxDbIKAOw+B0wfwJ/s=; b=Re0GYu4SyfK5Lso5wuUrGXWsmztb++hqnMp+ez0X7BtQj1KAQJD6r/kNUWsdKU9e2S h/kmIHD8iHd6qKR30qub41YANqNlf5E2sz6Qfl6SuVUsXdNE1+Cnj08zknSn2cW7PqHX rxCWmnitCxgzkmqAfG/ye/6RjoZI9lbssLO1/b6FlMaWs10vKnw07fcWaGXeIUv1tOFv s2ili8uiFjg5EKCdZcqBviCWpZwDgfN7qmm2it3taECCZWRsV3NlCYE/2wBkdYuRN4O2 QSkCBXmw6d9zWTL0igkSb8y0TTTvwWQdwRhrogdgFOhzV/g11uUQxt+EbJvq1rNjHjZd VLHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790074998; x=1790679798; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=AKXo4HFyGH+qOtzhSzfVmyUzvAxDbIKAOw+B0wfwJ/s=; b=XFuq1oZEyx5adc/kSKJN1hINzGkoOcAiNTVsAmySUk0ZG87AE0zwXboE3ILdJtQsIb nhUvUYFpE4B9YIoLraa1NhhRfV1rfIc+EYF39DuRHr+jibrfi7E17sS927iJ9MFH2Pv2 5IqW5ojedQrLBw9o/oPX0BNpsc6yA8FbkcIQj15lLJyu2YhRVr9oYywP3/P25gn0H9+y LOvyxFTlDQIWL5cmTQagK4WMrHnGZEzGzhbM26zwlvXcJPNGgW2zqTX0s6+GQxiDXMp+ w5rDGYMZx9WiGLQRWzyPq/KYI4BAeTLat6hq6mlEUBDr1OwBFw+TCW19UQWUMWGaxyZM aoww== X-Forwarded-Encrypted: i=1; AKwUvByT32MkrQbm1p1/9C0sG5kYbHPZSrCt0fw/Yx469GaswG++wnFiUZ5boApxrzGdwM3w7nRMEphXN5i1oyE=@vger.kernel.org X-Gm-Message-State: AFuF++mqrY0TClLdHsWwZFpYGfihHzSt2OqxWjLthHVaeX82QlQPVZAK eudxx9aFE7JQ1WEsa/RCHNhFbjhKZS3IOUpk41f9gynMjQ2SdaCgGfwORhR1zWyXrco= X-Gm-Gg: AYBFou0PcZT/0WBfGVDaEuK4TNWTBiuAjHHSCM5VX4oOFLzNBiGl3IopJxJ38adaWXH Mdrb4K7Go+57IT+DcHs1dd9cGwfWLmSAy4oZnEJpzNnL0cksxwi9nRo0M9H4rdcAfCU8fLSgffA f22NhyDEw0FPnhPO282SHFrm6awGFV+ZqDw3XGCfWQv9iNSbLlW4/vXhYnYmLsnIf4WpPW+47IV 0L6VGgC9FjGuJVKZowg0EAK4frZ0skwjmRZlSH+1ybJo0utuxoz2g2BxZoMhO3rn1ib6HeHE5LI LsAI3S/xvJIQJ9xY3R4ba7n21f1QbqeSEPCbAvUq13wth80cW1UCUZGzudDpPuzUBL1BigfgD2Q 8TA9cWkIPSIglpi9qwRCfac7a/nclcAY7eZM0Vkfxe+oNRLy/JjiMk2o73SQv4EEeNwJFAph54/ le2wdUrrxyWWhKCVqXzFGIhdUES7IYcztziY0sXIFcMLqeu5XCuw== X-Received: by 2002:a05:600c:1c20:b0:49c:fa20:cc07 with SMTP id 5b1f17b1804b1-49fc5741914mr220584495e9.30.1790074997555; Tue, 22 Sep 2026 04:03:17 -0700 (PDT) Received: from remote-01 ([84.17.55.230]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fdab0c240sm29990795e9.4.2026.09.22.04.03.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 04:03:16 -0700 (PDT) From: Aleksei Sviridkin To: netdev@vger.kernel.org Cc: Aleksei Sviridkin , andrew@lunn.ch, andrew+netdev@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, olteanv@gmail.com, Thangaraj.S@microchip.com, UNGLinuxDriver@microchip.com, steve.glendinning@shawell.net, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v9 0/4] net: phy: keep a PHY interrupt across a generic bind cycle Date: Tue, 22 Sep 2026 14:03:14 +0300 Message-ID: <20260922110314.4028755-1-f@lex.la> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260919015326.499479-1-f@lex.la> References: <20260919015326.499479-1-f@lex.la> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Andrew, please don't spend time on v9. A v10 follows with one code change. The store in phy_detach() moves inside the generic-driver branch. As posted it runs on every detach, so it also takes the value from the drivers you listed that set PHY_MAC_INTERRUPT in phydev->irq alone, which is what you said genphy should not touch. There is a second case for the same fix. After a failed request phy_request_interrupt() leaves PHY_POLL in phydev->irq while the bus table still holds the number that failed, so an unconditional restore hands that number back on the next cycle. pw-bot: cr