mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@linux.microsoft.com>
Cc: kotaranov@microsoft.com, snsanghvi@microsoft.com,
	longli@microsoft.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next 0/5] RDMA/mana_ib: Streamline kernel UD/GSI posting and completion handling
Date: Tue, 22 Sep 2026 17:06:51 +0300	[thread overview]
Message-ID: <20260922140651.GJ563127@unreal> (raw)
In-Reply-To: <20260916134835.2380971-1-kotaranov@linux.microsoft.com>

On Wed, Sep 16, 2026 at 06:48:30AM -0700, Konstantin Taranov wrote:
> From: Konstantin Taranov <kotaranov@microsoft.com>
> 
> This series updates the kernel UD/GSI work-request and completion paths in
> the MANA RDMA driver. The existing completion path copies CQE information
> into shadow entries and then walks the QPs attached to a CQ to produce
> work completions. This adds bookkeeping and a second pass over information
> that is already available when processing the CQE.
> 
> Generate work completions directly from CQEs and the corresponding posted
> shadow entries instead. Keep only QPs requiring software flushing on the
> CQ's error lists, and use the caller's remaining completion budget to
> retire their outstanding requests. The explicit GSI send-drain path adds
> the QP to the error list and invokes the CQ handler.
> 
> The shared GDMA SGE writer and explicit-index doorbell helper are included
> with their first users so this series does not depend on a later GDMA
> change. The WQE definitions and polling context also provide groundwork
> for a separate kernel RC series; RC posting, PSN/FSN processing, hardware
> error-CQE handling.

I read the commit messages, but couldn't find much information about what
you are doing or why. They only describe the implementation, in AI prose.

Thanks

> 
> Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
> 
> Konstantin Taranov (5):
>   RDMA/mana_ib: Optimize shadow queue bookkeeping
>   RDMA/mana_ib: Revise UD send posting and WQE definitions
>   RDMA/mana_ib: Revise UD receive posting with GDMA_WR_IB_SGL
>   RDMA/mana_ib: Make kernel CQ arming robust
>   RDMA/mana_ib: Poll UD completions and flush software error QPs
> 
>  drivers/infiniband/hw/mana/cq.c               | 315 +++++++++++++-----
>  drivers/infiniband/hw/mana/mana_ib.h          | 101 +++++-
>  drivers/infiniband/hw/mana/qp.c               |  78 +++--
>  drivers/infiniband/hw/mana/shadow_queue.h     |  60 ++--
>  drivers/infiniband/hw/mana/wr.c               | 141 ++++----
>  .../net/ethernet/microsoft/mana/gdma_main.c   |  43 ++-
>  include/net/mana/gdma.h                       |   9 +-
>  7 files changed, 527 insertions(+), 220 deletions(-)
> 
> 
> base-commit: 63367df6e7255067ad6a83abe0d2799dfa491876
> -- 
> 2.43.0

      parent reply	other threads:[~2026-09-22 14:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 13:48 Konstantin Taranov
2026-09-16 13:48 ` [PATCH rdma-next 1/5] RDMA/mana_ib: Optimize shadow queue bookkeeping Konstantin Taranov
2026-09-16 13:48 ` [PATCH rdma-next 2/5] RDMA/mana_ib: Revise UD send posting and WQE definitions Konstantin Taranov
2026-09-16 13:48 ` [PATCH rdma-next 3/5] RDMA/mana_ib: Revise UD receive posting with GDMA_WR_IB_SGL Konstantin Taranov
2026-09-16 13:48 ` [PATCH rdma-next 4/5] RDMA/mana_ib: Make kernel CQ arming robust Konstantin Taranov
2026-09-16 13:48 ` [PATCH rdma-next 5/5] RDMA/mana_ib: Poll UD completions and flush software error QPs Konstantin Taranov
2026-09-22 14:06 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922140651.GJ563127@unreal \
    --to=leon@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=kotaranov@linux.microsoft.com \
    --cc=kotaranov@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=snsanghvi@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®