From: Kayra Cizmeci <kayracizmeci@gmail.com>
To: peterz@infradead.org
Cc: albin_yang@163.com, albinwyang@tencent.com, bsegall@google.com,
chen.yu@linux.dev, dietmar.eggemann@arm.com,
juri.lelli@redhat.com, kayracizmeci@gmail.com,
kprateek.nayak@amd.com, linux-kernel@vger.kernel.org,
mgorman@suse.de, mingo@redhat.com, mintaohuang@tencent.com,
rostedt@goodmis.org, vincent.guittot@linaro.org,
vschneid@redhat.com, yu.c.chen@intel.com
Subject: Re: [PATCH v3] sched/stats: Fix run_delay over-count for migrated sched_delayed tasks
Date: Wed, 23 Sep 2026 00:08:19 +0300 [thread overview]
Message-ID: <20260922210819.11803-1-kayracizmeci@gmail.com> (raw)
In-Reply-To: <20260922105522.GO1837346@noisy.programming.kicks-ass.net>
Hi Peter,
> Will we not have a similar problem with proxy exec?
> That is, would t->is_blocked be more appropriate?
Yeah.
Only place that sets is_blocked to 1 is try_to_block_task(), which gets only called from __schedule.
Also, we give should_block param. !task_is_blocked(), so
if there are a pointer we return false on try_to_block_task(), so on task_is_blocked() true case,
and that means proxy tasks stay in rq. With blocked 1. So yeah, we have a similar problem on proxy exec.
To the second one tho, I think using task_is_blocked() would be better. Since, the current code
looks to that for whether or not queue the proxy.
And, on some places is_blocked is cleared after enqueu. My brain stopped working 2 hours ago,
this proxy execution stuff combined with delayed fries my brain. So I might be wrong, please correct me if so.
as far as I can tell reading tho. I'm sick of using tho. tho. :-)
Thanks,
Kayra
next prev parent reply other threads:[~2026-09-22 21:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 8:24 albin_yang
2026-09-22 10:55 ` Peter Zijlstra
2026-09-22 21:08 ` Kayra Cizmeci [this message]
2026-09-23 2:03 ` albin_yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922210819.11803-1-kayracizmeci@gmail.com \
--to=kayracizmeci@gmail.com \
--cc=albin_yang@163.com \
--cc=albinwyang@tencent.com \
--cc=bsegall@google.com \
--cc=chen.yu@linux.dev \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mintaohuang@tencent.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®