From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-195.mta0.migadu.com [91.218.175.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9392A53B35E for ; Tue, 22 Sep 2026 23:02:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790118140; cv=none; b=CV78undkuZvHiYZXJ5vKoTko8Vl82fnEBYFu29vLH90l266U69uPN0Kf7yZb/b6d78fNVwDmbu5LJc0TKBpsPF7Nh1V6AUMgMLhIYqE4H5u6M2EDgY/4/5YtJPkyQlNZQ5VhU48GzEdqllzMWqfpPV7igu1fVvgdL4ZEoTIZT/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790118140; c=relaxed/simple; bh=eKY8muhrbtudXuydSv21jOYK8tLObXIbSVhFacGhado=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ugdfFdo5MUkjz99WnTccJdsSWQfyu2u5+aXjDHtrl4ytCSByU35OOV84xCS5d6kBukKH+q8Q9BZb1E3IYCJXUL7h1mU8QFeQqCumWbVyPweavdZHkLB4c3EamzP2E5k8cWBjPjgM36J0WocTPMsKjjum5HzWr6ebp45zTKJ1Y/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=f3w3a72j; arc=none smtp.client-ip=91.218.175.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="f3w3a72j" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=eKY8muhrbtudXuydSv21jOYK8tLObXIbSVhFacGhado=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1790118135; v=1; x=1790722935; b=f3w3a72jaGc0IACX6BAwyLWc0Ani4Dcvrnf+GVLaQoctwkeghDac5vaKnac11C49xPgyAL9x 0lpIbK89dc8pnnCd2xZKcUkzDhvXJklminjgnVFwhEfq4ff8QrUV8b4arfUWuoUB+Z804fxlRVC eP9iMOv0Rwf3sKNXpVevxg5w= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 462eb4cb2836677f; Tue, 22 Sep 2026 23:02:14 +0000 X-Mizu-Trace-ID: 462eb4cb2836677f X-Migadu-Flow: FLOW_OUT From: Denis Benato To: linux-kernel@vger.kernel.org Cc: linux-input@vger.kernel.org, "Benjamin Tissoires" , "Jiri Kosina" , "Luke D . Jones" , "Mateusz Schwartz" , "Denis Benato" , "Jonathan LoBue" , "Khamunetri Clark" , "Derek J. Clark" , Denis Benato Subject: [PATCH v8 07/12] HID: asus: add joysticks anti-deadzone configuration Date: Tue, 22 Sep 2026 23:02:00 +0000 Message-ID: <20260922230205.6847-8-denis.benato@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260922230205.6847-1-denis.benato@linux.dev> References: <20260922230205.6847-1-denis.benato@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ROG Ally devices allow configuring the anti-deadzone parameter for the resistive joysticks devices as over time those develops drift, therefore allow userspace to configure the anti-deadzone by exposing relevant sysfs attributes. Assisted-by: opencode:glm-5.2 Signed-off-by: Denis Benato Signed-off-by: Luke Jones --- drivers/hid/hid-asus.c | 215 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 211 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 3affb0e39e50..7911f510466d 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -1382,6 +1382,197 @@ static struct device_attribute dev_attr_right_joystick_outer_threshold = static struct device_attribute dev_attr_right_joystick_outer_threshold_range = __ATTR(outer_threshold_range, 0444, right_joystick_outer_threshold_range_show, NULL); +/** + * ally_set_anti_deadzone() - Set anti-deadzone values for joysticks + * @ally: ally handheld structure + * @hdev: HID device + * @cfg: ally config + * @left_adz: left joystick anti-deadzone value (0-100) + * @right_adz: right joystick anti-deadzone value (0-100) + * + * Return: 0 on success, negative errno on failure + */ +static int ally_set_anti_deadzone(struct ally_handheld *ally, + struct hid_device *hdev, struct ally_config *cfg, + u8 left_adz, u8 right_adz) +{ + const u8 payload[] = { left_adz, right_adz }; + int ret; + + if (!cfg->anti_deadzone_support) { + hid_dbg(hdev, "Anti-deadzone not supported on this device\n"); + return -EOPNOTSUPP; + } + + u8 *buf __free(kfree) = ally_alloc_cmd(CMD_SET_ANTI_DEADZONE, payload, sizeof(payload)); + if (!buf) + return -ENOMEM; + + ret = ally_gamepad_send_packet(ally, hdev, buf, ROG_ALLY_REPORT_SIZE); + if (ret < 0) { + hid_err(hdev, "Failed to set anti-deadzone values: %d\n", ret); + return ret; + } + + return 0; +} + +static ssize_t left_joystick_anti_deadzone_show(struct device *dev, struct device_attribute *attr, + char *buf) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->anti_deadzone_support) { + hid_dbg(hdev, "Anti-deadzone not supported on this device\n"); + return -EOPNOTSUPP; + } + + return sysfs_emit(buf, "%u\n", cfg->left_anti_deadzone); +} + +static ssize_t left_joystick_anti_deadzone_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + u8 value; + int ret; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + ret = kstrtou8(buf, 10, &value); + if (ret || value > 100) + return -EINVAL; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->anti_deadzone_support) { + hid_dbg(hdev, "Anti-deadzone not supported on this device\n"); + return -EOPNOTSUPP; + } + + ret = ally_set_anti_deadzone(ally, hdev, cfg, value, cfg->right_anti_deadzone); + if (ret) + return ret; + + cfg->left_anti_deadzone = value; + + sysfs_notify(&dev->kobj, "left_joystick_axis", "anti_deadzone"); + + return count; +} + +static ssize_t left_joystick_anti_deadzone_range_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + return sysfs_emit(buf, "0 100\n"); +} + +static ssize_t right_joystick_anti_deadzone_show(struct device *dev, struct device_attribute *attr, + char *buf) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->anti_deadzone_support) { + hid_dbg(hdev, "Anti-deadzone not supported on this device\n"); + return -EOPNOTSUPP; + } + + return sysfs_emit(buf, "%u\n", cfg->right_anti_deadzone); +} + +static ssize_t right_joystick_anti_deadzone_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + u8 value; + int ret; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + ret = kstrtou8(buf, 10, &value); + if (ret || value > 100) + return -EINVAL; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->anti_deadzone_support) { + hid_dbg(hdev, "Anti-deadzone not supported on this device\n"); + return -EOPNOTSUPP; + } + + ret = ally_set_anti_deadzone(ally, hdev, cfg, cfg->left_anti_deadzone, value); + if (ret) + return ret; + + cfg->right_anti_deadzone = value; + + sysfs_notify(&dev->kobj, "right_joystick_axis", "anti_deadzone"); + + return count; +} + +static ssize_t right_joystick_anti_deadzone_range_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + return sysfs_emit(buf, "0 100\n"); +} + +static struct device_attribute dev_attr_left_joystick_anti_deadzone = + __ATTR(anti_deadzone, 0644, left_joystick_anti_deadzone_show, + left_joystick_anti_deadzone_store); + +static struct device_attribute dev_attr_left_joystick_anti_deadzone_range = + __ATTR(anti_deadzone_range, 0444, left_joystick_anti_deadzone_range_show, NULL); + +static struct device_attribute dev_attr_right_joystick_anti_deadzone = + __ATTR(anti_deadzone, 0644, right_joystick_anti_deadzone_show, + right_joystick_anti_deadzone_store); + +static struct device_attribute dev_attr_right_joystick_anti_deadzone_range = + __ATTR(anti_deadzone_range, 0444, right_joystick_anti_deadzone_range_show, NULL); + /** * ally_set_trigger_ranges() - Generic function to set triggers ranges * @ally: ally handheld structure @@ -1755,6 +1946,8 @@ static struct attribute *left_joystick_axis_attrs[] = { &dev_attr_left_joystick_outer_threshold.attr, &dev_attr_left_joystick_inner_threshold_range.attr, &dev_attr_left_joystick_outer_threshold_range.attr, + &dev_attr_left_joystick_anti_deadzone.attr, + &dev_attr_left_joystick_anti_deadzone_range.attr, NULL }; @@ -1763,6 +1956,8 @@ static struct attribute *right_joystick_axis_attrs[] = { &dev_attr_right_joystick_outer_threshold.attr, &dev_attr_right_joystick_inner_threshold_range.attr, &dev_attr_right_joystick_outer_threshold_range.attr, + &dev_attr_right_joystick_anti_deadzone.attr, + &dev_attr_right_joystick_anti_deadzone_range.attr, NULL }; @@ -1894,8 +2089,11 @@ static struct ally_config *ally_config_create(struct hid_device *hdev, struct al } } - /* Skip the calibration groups when the capability is missing. */ - if (cfg->user_cal_support) { + /* + * Skip the calibration and anti-deadzone groups when none of the + * features they expose is supported. + */ + if (cfg->user_cal_support || cfg->anti_deadzone_support) { int cal_i; for (cal_i = 0; cal_i < ARRAY_SIZE(ally_cal_attr_groups); @@ -1949,8 +2147,7 @@ static void ally_config_remove(struct hid_device *hdev, struct ally_config *cfg) * create them, so a device without those capabilities does not * trigger a "not found" warning. */ - if (cfg->user_cal_support || cfg->anti_deadzone_support || - cfg->resp_curve_support) { + if (cfg->user_cal_support || cfg->anti_deadzone_support) { for (i = 0; i < ARRAY_SIZE(ally_cal_attr_groups); i++) sysfs_remove_group(&hdev->dev.kobj, ally_cal_attr_groups[i]); @@ -2275,6 +2472,16 @@ static int hid_asus_ally_init(struct hid_device *hdev, struct ally_handheld *all ret); } + if (cfg->anti_deadzone_support) { + ret = ally_set_anti_deadzone(ally, hdev, cfg, + cfg->left_anti_deadzone, + cfg->right_anti_deadzone); + if (ret < 0) + hid_warn(hdev, + "Failed to restore anti-deadzone: %d\n", + ret); + } + return 0; } -- 2.47.3