mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Trond Myklebust <trondmy@kernel.org>,
	Anna Schumaker <anna@kernel.org>,  Chuck Lever <cel@kernel.org>,
	NeilBrown <neil@brown.name>,
	 Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <Dai.Ngo@oracle.com>,  Tom Talpey <tom@talpey.com>,
	Shuah Khan <shuah@kernel.org>
Cc: Scott Mayhew <smayhew@redhat.com>,
	linux-nfs@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	 Jeff Layton <jlayton@kernel.org>
Subject: [PATCH v2 0/2] lockd: allow setting ports without setting gracetime
Date: Wed, 23 Sep 2026 11:30:49 -0400	[thread overview]
Message-ID: <20260923-nfsd-testing-v2-0-bfba431122c8@kernel.org> (raw)

This version fixes some selftest coverage gaps that Sashiko pointed out.
The actual bugfix is unchanged.

This patchset fixes a rather silly bug that Scott pointed out to me in a
meeting recently. You currently can't set the ports in lockd via the
netlink interface unless you also set the gracetime. This patch makes
them all properly optional.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Changes in v2:
- selftests: split put_ports() into put_tcp_port()/put_udp_port() helpers
- selftests: attributes_are_set_independently now also covers a UDP-only SERVER_SET
- selftests: empty_set_is_a_noop and settings_are_per_netns now set and check gracetime too
- Link to v1: https://lore.kernel.org/r/20260923-nfsd-testing-v1-0-a793f54a4dd1@kernel.org

---
Jeff Layton (2):
      lockd: allow SERVER_SET without a gracetime attribute
      selftests/nfsd: add lockd netlink configuration tests

 fs/lockd/svc.c                                    |  50 ++--
 tools/testing/selftests/nfsd/.gitignore           |   1 +
 tools/testing/selftests/nfsd/Makefile             |   1 +
 tools/testing/selftests/nfsd/nfsd_lockd_netlink.c | 268 ++++++++++++++++++++++
 tools/testing/selftests/nfsd/nfsd_netlink.h       |  90 ++++++--
 5 files changed, 367 insertions(+), 43 deletions(-)
---
base-commit: cab95e6be3ba82bcf4c8be27c2eb20e55238aa41
change-id: 20260922-nfsd-testing-00c12335047d

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>


             reply	other threads:[~2026-09-23 15:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 15:30 Jeff Layton [this message]
2026-09-23 15:30 ` [PATCH v2 1/2] lockd: allow SERVER_SET without a gracetime attribute Jeff Layton
2026-09-23 15:30 ` [PATCH v2 2/2] selftests/nfsd: add lockd netlink configuration tests Jeff Layton
2026-09-23 18:25 ` [PATCH v2 0/2] lockd: allow setting ports without setting gracetime Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923-nfsd-testing-v2-0-bfba431122c8@kernel.org \
    --to=jlayton@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=anna@kernel.org \
    --cc=cel@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=shuah@kernel.org \
    --cc=smayhew@redhat.com \
    --cc=tom@talpey.com \
    --cc=trondmy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®