mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Rodrigo Alencar <455.rodrigo.alencar@gmail.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-hardening@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	David Lechner <dlechner@baylibre.com>,
	Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Kees Cook <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: Re: [PATCH v10 04/17] iio: add IIO_FREQUENCY channel type
Date: Wed, 23 Sep 2026 02:55:22 +0100	[thread overview]
Message-ID: <20260923025522.49b10c08@jic23-hlaptop> (raw)
In-Reply-To: <bukynp5qvtqf5jgqnxzxesvt5vimm3i3lvqrwmffc7fecjnabx@rqyeho7v5cnn>

On Tue, 22 Sep 2026 17:07:45 +0100
Rodrigo Alencar <455.rodrigo.alencar@gmail.com> wrote:

> On 22/09/26 16:56, Rodrigo Alencar wrote:
> > esOn 29/07/26 09:25, Rodrigo Alencar via B4 Relay wrote:  
> > > From: Rodrigo Alencar <rodrigo.alencar@analog.com>
> > > 
> > > Add IIO_FREQUENCY channel type to support Direct Digital Synthesizer (DDS)
> > > devices that handles frequency values written directly to its buffered
> > > interface.  
> > 
> > ...
> >   
> > > Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
> > > ---
> > >  drivers/iio/industrialio-core.c | 1 +
> > >  include/uapi/linux/iio/types.h  | 1 +
> > >  tools/iio/iio_event_monitor.c   | 2 ++
> > >  3 files changed, 4 insertions(+)
> > > 
> > > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> > > index bdf3d4c06331..a45277bc5d99 100644
> > > --- a/drivers/iio/industrialio-core.c
> > > +++ b/drivers/iio/industrialio-core.c
> > > @@ -99,6 +99,7 @@ static const char * const iio_chan_type_name_spec[] = {
> > >  	[IIO_ATTENTION] = "attention",
> > >  	[IIO_ALTCURRENT] = "altcurrent",
> > >  	[IIO_COVERAGE] = "coverage",
> > > +	[IIO_FREQUENCY] = "frequency",  
> > 
> > Hi Jonathan,
> > 
> > Thanks for not giving up on this one! Taking a look at the testing branch,
> > I think this line was dropped during the rebase (addressing a conflict)  
Fixed up. Build test just running. Thanks!
> 
> btw, now that we are at this again, it crossed my mind...
> Is it fine to have a channel named the same way an attribute may be named?
> wonder if userspace tools could get confused.
I don't think so as they should be dealing with the ordering of different things
and we will always have a channel type before a modifier.

Jonathan

>  


  reply	other threads:[~2026-09-23  1:55 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  8:25 [PATCH v10 00/17] AD9910 Direct Digital Synthesizer Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 01/17] iio: ABI: add attributes for altcurrent channels Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 02/17] iio: ABI: raw, scale and offset for frequency/phase channels Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 03/17] iio: ABI: add parent entry for iio channels Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 04/17] iio: add IIO_FREQUENCY channel type Rodrigo Alencar via B4 Relay
2026-09-22 15:56   ` Rodrigo Alencar
2026-09-22 16:07     ` Rodrigo Alencar
2026-09-23  1:55       ` Jonathan Cameron [this message]
2026-07-29  8:25 ` [PATCH v10 05/17] iio: core: support 64-bit register through debugfs Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 06/17] iio: core: create local __iio_chan_prefix_emit() for reuse Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 07/17] iio: test: add kunit tests for channel prefix naming generation Rodrigo Alencar via B4 Relay
2026-08-01 23:55   ` Jonathan Cameron
2026-07-29  8:25 ` [PATCH v10 08/17] iio: core: add hierarchical channel relationships Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 09/17] dt-bindings: iio: frequency: add ad9910 Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 10/17] iio: frequency: ad9910: initial driver implementation Rodrigo Alencar via B4 Relay
2026-08-04 15:12   ` Nuno Sá
2026-09-07 21:59     ` Jonathan Cameron
2026-07-29  8:25 ` [PATCH v10 11/17] iio: frequency: ad9910: add basic parallel port support Rodrigo Alencar via B4 Relay
2026-08-02  0:56   ` Jonathan Cameron
2026-08-02  9:04     ` David Laight
2026-08-04 23:07       ` Jonathan Cameron
2026-07-29  8:25 ` [PATCH v10 12/17] iio: frequency: ad9910: add digital ramp generator support Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 13/17] iio: frequency: ad9910: add RAM mode support Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 14/17] iio: frequency: ad9910: add output shift keying support Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 15/17] iio: frequency: ad9910: show channel priority in debugfs Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 16/17] iio: ABI: add docs for ad9910 sysfs and debugfs entries Rodrigo Alencar via B4 Relay
2026-07-29  8:25 ` [PATCH v10 17/17] docs: iio: add documentation for ad9910 driver Rodrigo Alencar via B4 Relay
2026-08-02  0:09 ` [PATCH v10 00/17] AD9910 Direct Digital Synthesizer Jonathan Cameron
2026-08-02  0:58   ` Jonathan Cameron
2026-08-04 10:56     ` Rodrigo Alencar
2026-09-07 22:05       ` Jonathan Cameron
2026-09-21  2:42         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923025522.49b10c08@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=455.rodrigo.alencar@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gustavoars@kernel.org \
    --cc=kees@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®