From: Zhihao Cheng <chengzhihao1@huawei.com>
To: <song@kernel.org>, <yukuai@fygo.io>, <shli@kernel.org>,
<neil@brown.name>
Cc: <linux-raid@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<chengzhihao1@huawei.com>, <yangerkun@huawei.com>,
<yi.zhang@huawei.com>
Subject: [PATCH v3 2/4] md: Handle pers->run failure in level_store
Date: Wed, 23 Sep 2026 19:21:56 +0800 [thread overview]
Message-ID: <20260923112159.94175-3-chengzhihao1@huawei.com> (raw)
In-Reply-To: <20260923112159.94175-1-chengzhihao1@huawei.com>
Set 'raid_disks' after raid5_run() failure will trigger an
null-ptr-deref problem:
BUG: kernel NULL pointer dereference, address: 0000000000000038
RIP: 0010:raid5_check_reshape+0xad
Call Trace:
update_raid_disks+0x124
raid_disks_store+0x145
md_attr_store+0xd7
sysfs_kf_write+0x7c
The trigger process is simple:
mdadm --create /dev/md0 --level=1 --raid-devices=2 /dev/sda /dev/sdb
--force --assume-clean # create raid1
echo 5 > /sys/block/md0/md/level
level_store
mddev->pers = pers
mddev->private = priv
raid5_run
fail to abort (eg. raid5_create_ctx_pool fails)
mddev->private = NULL
echo 10 > /sys/block/md0/md/raid_disks
raid_disks_store
if (mddev->pers) // true
update_raid_disks
raid5_check_reshape
conf = mddev->private
conf->algorithm = mddev->new_layout // null-ptr-deref !
Similar process exists in do_md_stop->__md_stop_writes->raid5_quiesce.
Similar process exists in raid10 too.
Fix it by handling the error from pers->run, next active-type order will
restart the mddev.
Fixes: 245f46c2c221e ("md: add ->takeover method to support changing the personality managing an array")
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
---
drivers/md/md.c | 29 ++++++++++++++++++++++++++++-
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 02798f2dbf0e..ff78bf8656ff 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -97,6 +97,7 @@ static struct workqueue_struct *md_misc_wq;
static int remove_and_add_spares(struct mddev *mddev,
struct md_rdev *this);
static void mddev_detach(struct mddev *mddev);
+static void __md_stop(struct mddev *mddev);
static void export_rdev(struct md_rdev *rdev);
static void md_wakeup_thread_directly(struct md_thread __rcu **thread);
@@ -4243,7 +4244,33 @@ level_store(struct mddev *mddev, const char *buf, size_t len)
mddev->in_sync = 1;
timer_delete_sync(&mddev->safemode_timer);
}
- pers->run(mddev);
+ rv = pers->run(mddev);
+ if (rv) {
+ /*
+ * ->run() has released the private data of the new personality,
+ * while the old one has already been released as well. There is
+ * nothing to fall back to, so stop the array to avoid leaving
+ * 'mddev->pers' pointing to a personality which has no private
+ * data, and reminds user to try to active the mddev again.
+ */
+ pr_warn("md: %s: failed to run %s after takeover, please try to active\n",
+ mdname(mddev), pers->head.name);
+ if (mddev->pers->sync_request && mddev->to_remove == NULL)
+ mddev->to_remove = &md_redundancy_group;
+ if (md_bitmap_enabled(mddev, true))
+ mddev->bitmap_ops->flush(mddev);
+ clear_bit(MD_SERIALIZE_POLICY, &mddev->flags);
+ mddev_destroy_serial_pool(mddev, NULL);
+ __md_stop(mddev);
+ rdev_for_each(rdev, mddev)
+ if (rdev->raid_disk >= 0)
+ sysfs_unlink_rdev(mddev, rdev);
+ set_capacity_and_notify(mddev->gendisk, 0);
+ mddev->changed = 1;
+ md_new_event();
+ sysfs_notify_dirent_safe(mddev->sysfs_state);
+ goto out_unlock;
+ }
set_bit(MD_SB_CHANGE_DEVS, &mddev->sb_flags);
if (!mddev->thread)
md_update_sb(mddev, 1);
--
2.52.0
next prev parent reply other threads:[~2026-09-23 11:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 11:21 [PATCH v3 0/4] md: Fix two raid5/raid10 bugs Zhihao Cheng
2026-09-23 11:21 ` [PATCH v3 1/4] md/raid5: Hide the origin mddev->thread before takeover Zhihao Cheng
2026-10-09 4:31 ` yu kuai
2026-10-09 7:12 ` Zhihao Cheng
2026-09-23 11:21 ` Zhihao Cheng [this message]
2026-10-09 5:05 ` [PATCH v3 2/4] md: Handle pers->run failure in level_store yu kuai
2026-09-23 11:21 ` [PATCH v3 3/4] md/raid5: Don't free conf on raid5_run failure Zhihao Cheng
2026-09-23 11:21 ` [PATCH v3 4/4] md/raid10: Don't free conf on raid10_run failure Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923112159.94175-3-chengzhihao1@huawei.com \
--to=chengzhihao1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neil@brown.name \
--cc=shli@kernel.org \
--cc=song@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai@fygo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®