From: Rob Herring <robh@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Sean Wang <sean.wang@mediatek.com>,
Flora Fu <flora.fu@mediatek.com>,
Alexandre Mergnat <amergnat@baylibre.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] regulator: dt-bindings: Convert mediatek,mt6380-regulator to DT schema
Date: Wed, 23 Sep 2026 07:21:19 -0500 [thread overview]
Message-ID: <20260923122119.GA27237-robh@kernel.org> (raw)
In-Reply-To: <arOtTntGW-ocXRxK@sirena.co.uk>
On Wed, Sep 23, 2026 at 12:43:26PM +0200, Mark Brown wrote:
> On Tue, Sep 22, 2026 at 02:55:01PM -0500, Rob Herring (Arm) wrote:
> > Convert the MediaTek mediatek,mt6380-regulator binding to DT schema
> > format. It's a straight forward conversion.
>
> > + '^buck-(vcore1?|vrf)$':
> > + description: BUCK regulators
> > + $ref: regulator.yaml#
> > + unevaluatedProperties: false
> > +
> > + required:
> > + - regulator-min-microvolt
> > + - regulator-max-microvolt
> > + - regulator-ramp-delay
> > +
> > + '^ldo-v([mat]|phy|ddr)$':
> > + type: object
> > + description: LDO regulators
> > + $ref: regulator.yaml#
> > + unevaluatedProperties: false
>
> The LDO is an object but the buck is not? I'll apply, but the above
> looks weird.
I missed dropping 'type: object' here in my review/rewrite of the LLM
generated conversion. It is not needed because regulator.yaml has it
(after processing, every schema doc does).
Rob
next prev parent reply other threads:[~2026-09-23 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 19:55 Rob Herring (Arm)
2026-09-23 10:43 ` Mark Brown
2026-09-23 12:21 ` Rob Herring [this message]
2026-09-23 10:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923122119.GA27237-robh@kernel.org \
--to=robh@kernel.org \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=flora.fu@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®