mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 0/2] serial: 8250_port: Update runtime PM flow
Date: Wed, 23 Sep 2026 14:41:23 +0200	[thread overview]
Message-ID: <2026092315-eatable-canned-26a5@gregkh> (raw)
In-Reply-To: <20260814112435.3290545-1-andriy.shevchenko@linux.intel.com>

On Fri, Aug 14, 2026 at 01:16:28PM +0200, Andy Shevchenko wrote:
> There are two changes, one is a straightforward drop of the duplicate
> runtime PM call (which is idempotent and hence it's harmless to call,
> but practically no need to do so) and the other addresses long standing
> problem with potentially sleeping PM calls on some system in IRQ context.
> Also the latter might lead to unneeded resume-suspend cycle when IRQ is
> shared and interrupt is not ours. This mini-series to update runtime
> PM flow to make sure this won't happen.
> 
> Andy Shevchenko (2):
>   serial: 8250_port: Remove redundant pm_runtime_mark_last_busy() call
>   serial: 8250_port: properly handle runtime PM in IRQ
> 
>  drivers/tty/serial/8250/8250_port.c | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
> 
> -- 
> 2.50.1
> 
> 

  CC      drivers/tty/serial/8250/8250_port.o
drivers/tty/serial/8250/8250_port.c: In function ‘serial8250_default_handle_irq’:
drivers/tty/serial/8250/8250_port.c:1897:32: error: unused variable ‘up’ [-Werror=unused-variable]
 1897 |         struct uart_8250_port *up = up_to_u8250p(port);
      |                                ^~
cc1: all warnings being treated as errors

:(

  parent reply	other threads:[~2026-09-23 12:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 11:16 Andy Shevchenko
2026-08-14 11:16 ` [PATCH v1 1/2] serial: 8250_port: Remove redundant pm_runtime_mark_last_busy() call Andy Shevchenko
2026-08-14 11:16 ` [PATCH v1 2/2] serial: 8250_port: properly handle runtime PM in IRQ Andy Shevchenko
2026-09-23 12:41 ` Greg Kroah-Hartman [this message]
2026-09-24 12:20   ` [PATCH v1 0/2] serial: 8250_port: Update runtime PM flow Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026092315-eatable-canned-26a5@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®