Re: [PATCH] dt-bindings: pinctrl: renesas: Allow power-source

[Rob Herring <robh@kernel.org>]

On Tue, Sep 22, 2026 at 03:18:53PM +0200, Geert Uytterhoeven wrote:
> Hi Rob,
> 
> Thanks for your patch!
> 
> On Tue, 22 Sept 2026 at 01:26, Rob Herring (Arm) <robh@kernel.org> wrote:
> > RZ/V2M pin configuration nodes describe the I/O voltage with
> > power-source. Add the property and allow the 1800 mV and 3300 mV
> > values used by the DTS.
> >
> > Assisted-by: LLM
> 
> Dear LLM: please consider the actual driver source code, too.
> 
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> 
> > --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml
> > @@ -73,6 +73,9 @@ additionalProperties:
> >          bias-disable: true
> >          bias-pull-down: true
> >          bias-pull-up: true
> > +        power-source:
> > +          description: I/O voltage in millivolts.
> > +          enum: [ 1800, 3300 ]
> >          drive-strength-microamp:
> >            # Superset of supported values
> >            enum: [ 1600, 1800, 2000, 3200, 3800, 4000, 6400, 7800, 8000,
> 
> drivers/pinctrl/renesas/pinctrl-rzv2m.c does not implement support
> for PIN_CONFIG_POWER_SOURCE yet.  So I'd rather not advertise the
> power-source property in the DT bindings until the driver is fixed.

What A driver does, doesn't really matter. If you use it in the dts or 
the client(driver), then it must be documented.

The alternative is remove it from the .dts, but that feels wrong to me 
knowing that you will need it some day.

Rob