From: Sergey Shtylyov <s.shtylyov@auroraos.dev>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
<linux-usb@vger.kernel.org>, <netdev@vger.kernel.org>
Cc: Sergey Shtylyov <s.shtylyov@auroraos.dev>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH net-next v3 0/2] ch9200: stop ignoring the register write errors
Date: Wed, 23 Sep 2026 23:14:37 +0300 [thread overview]
Message-ID: <20260923201440.36966-1-s.shtylyov@auroraos.dev> (raw)
The successful register writes, done via the USB control requests, seem
vital for the normal functioning of the device, however the driver tends
to completely ignore the register write errors, even though it could well
propagate the errors from its bind() method. Additionally, it masks any
USB errors returned by usb_control_msg(), pretending that the call was
successful. Let's stop doing all that and see how it goes... :-)
Sergey Shtylyov (2):
ch9200: return error on failed register writes in ch9200_bind()
ch9200: do return USB errors from control_write()
drivers/net/usb/ch9200.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
--
2.55.0
next reply other threads:[~2026-09-23 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 20:14 Sergey Shtylyov [this message]
2026-09-23 20:14 ` [PATCH net-next v3 1/2] ch9200: return error on failed register writes in ch9200_bind() Sergey Shtylyov
2026-09-23 20:14 ` [PATCH net-next v3 2/2] ch9200: do return USB errors from control_write() Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923201440.36966-1-s.shtylyov@auroraos.dev \
--to=s.shtylyov@auroraos.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®