From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Armin Wolf <W_Armin@gmx.de>,
David Lechner <dlechner@baylibre.com>,
Danilo Krummrich <dakr@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Daniel Gomez <da.gomez@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Aaron Tomlin <atomlin@atomlin.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Bradley Morgan <brads@mainlining.org>,
Aleksandr Nogikh <nogikh@google.com>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-usb@vger.kernel.org,
driver-core@lists.linux.dev, linux-trace-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>,
Richard Weinberger <richard@nod.at>,
Thierry Reding <thierry.reding@kernel.org>
Subject: Re: [PATCH v4 0/3] driver core: add TAINT_FORCED_BIND for when userspace manually messes with devices and drivers
Date: Wed, 23 Sep 2026 12:29:56 +0200 [thread overview]
Message-ID: <2026092348-victory-erased-0e5a@gregkh> (raw)
In-Reply-To: <arOfHEsGGglNse7T@monoceros>
On Wed, Sep 23, 2026 at 11:54:50AM +0200, Uwe Kleine-König wrote:
> > No, drivers should NOT have to do that in their .probe() function,
> > that's what we moved away from decades ago! The match function should
> > handle all of that for you, otherwise it's contant duplication
> > everywhere that is unneeded.
>
> Well then you have to accept that root can provoke a null pointer
> exception (e.g. by forcing the pwm-tegra driver on a device) because at
> least with today's platform bus match function such a match is ok.
Agreed, yes, root can cause a crash and can do tons of horrible things
much worse than this, that's not the issue.
That's why this taint is there, to make it obvious that this is not a
"real" bug at all.
> > Please, learn from our history, don't make the same mistakes.
> >
> > Now I might be convinced that driver_override is the way to go here, but
> > it still feels really odd as again, bind/unbind was created as a driver
> > debugging option only, it should NOT be a normal operation that any user
> > should rely on. The driver should "just work" properly instead, without
> > requiring manual bind work, as that's not a good model at all.
>
> I agree in principle, but (in my case wifi) drivers are buggy sometimes
> (due to missing documentation and/or engineering effort) and being able
> to rebind the driver instead of rebooting to get a working device again
> is very useful.
Fine, use it! Just don't expect that to be "normal".
> So yes, theoretically bind/unbind isn't needed, but theory and practise
> differ in practise.
Agreed, but again, don't rely on this as a "real" solution fo ranything.
> OK, as a compromise: Let's keep the taint (after all that's not
> destroying any functionality, just adding a hint for bug reports),
> and make driver_override opt-in, which should close an attack surface
> (mostly for fuzzers?) and so reduce the amount of bug reports instead of
> marking a part of them as tainted only.
How is that going to change anything? Confused.
greg k-h
next prev parent reply other threads:[~2026-09-23 10:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 14:30 Greg Kroah-Hartman
2026-09-14 14:30 ` [PATCH v4 1/3] module: pull out add_taint_module() to be public Greg Kroah-Hartman
2026-09-14 14:30 ` [PATCH v4 2/3] module: fix up documentation for add_taint() and add_taint_module() Greg Kroah-Hartman
2026-09-14 14:42 ` Bradley Morgan
2026-09-18 15:44 ` Aaron Tomlin
2026-09-14 14:30 ` [PATCH v4 3/3] driver core: add TAINT_FORCED_BIND for when userspace manually messes with devices and drivers Greg Kroah-Hartman
2026-09-18 16:39 ` [PATCH v4 0/3] " Danilo Krummrich
2026-09-18 17:25 ` Greg Kroah-Hartman
2026-09-18 17:29 ` Bradley Morgan
2026-09-22 7:39 ` Uwe Kleine-König
2026-09-22 13:40 ` David Lechner
2026-09-22 21:04 ` Armin Wolf
2026-09-23 6:29 ` Uwe Kleine-König
2026-09-23 9:27 ` Greg Kroah-Hartman
2026-09-23 9:54 ` Uwe Kleine-König
2026-09-23 10:29 ` Greg Kroah-Hartman [this message]
2026-09-23 20:52 ` Armin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026092348-victory-erased-0e5a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=W_Armin@gmx.de \
--cc=atomlin@atomlin.com \
--cc=brads@mainlining.org \
--cc=corbet@lwn.net \
--cc=da.gomez@kernel.org \
--cc=dakr@kernel.org \
--cc=dlechner@baylibre.com \
--cc=driver-core@lists.linux.dev \
--cc=johan@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=nogikh@google.com \
--cc=petr.pavlu@suse.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=skhan@linuxfoundation.org \
--cc=thierry.reding@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®