From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A76338B7CD for ; Thu, 24 Sep 2026 06:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.180.163 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790230851; cv=none; b=WCclzlHHzMPSREpTnnhabxJuxyiwq9Z11EqkjzzQ1Q58gERBN3W7RonhVJan3UpR4G/vCmVjslgGP+jGwDJ0yEBgnTPJOvI0BwHRJToAdFV/EbgDYsjFZ0Wqgam/RQTkGZ5QNW7BgX+stC68vY7VyNrpEgia2xv2kbZnS6hWg8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790230851; c=relaxed/simple; bh=cByg57c+ZiNGGtOS/HfykUAf4O4HN7h9mKZN2uVWCm4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=kNnZrOf7w03v1a2RuZgylMikOx7+k7EaoOIKnpylOrWFTlOH9wKs6oMRq8oydv8nSpcrxBsghHFxFteIDn+O4xFxB5ryeLSho1QNetF9O2lJdzH3DSy+Z8nzc9XCqj78nAG7SNfv8my5bCsXx8ltGY/Yx5mNiuvd3peQdoZbbhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=ZLSz/DNe; arc=none smtp.client-ip=185.132.180.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="ZLSz/DNe" Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68O5d9Mk4069889; Thu, 24 Sep 2026 07:20:19 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=dk201812; bh=a gFmwEAolzDylk3GNfaXivFSzDaf95+XuykgMI0qkC4=; b=ZLSz/DNe4W48kRnxB XRRfuqHTym8bNIMbkqwrKfinToC4Dx1peGoFBaxzqxJ7izPAFibYoifWIcmI4CEG xBfkok904xR0bzJXrfpjymd5dPliSsF/fTf7VF7uRU/fQzn1oM3odCm2y9ABxipR H9sEm9h122nlO594j7/x27QzHOWB34A5afIV5uVyMwW1qa8eUNjFXKXoNVA5qbXW jfhL4uhm0ZS4YrPwqC1KdTEmMtVzC0xGnSQL//S4UN8DzVBvS9OuTl0wBttGg5cv lIWtq04vEVZ8GpS48GCDqEl9CnAe2ZXa5PcbT5TJjq6xZvyKPGiYQ4FDXCKPl/PX Ucw5w== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 4gsjftm9vx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Sep 2026 07:20:19 +0100 (BST) Received: from [127.0.1.1] (172.25.5.18) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Thu, 24 Sep 2026 07:20:18 +0100 From: Alexandru Dadu Date: Thu, 24 Sep 2026 09:19:51 +0300 Subject: [PATCH v6 3/3] drm/imagination: Release pm references in case of error Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20260924-b4-upstream-propagate-all-errors-from-kccb-cmd-submission-code-v6-3-d9d5375665ed@imgtec.com> References: <20260924-b4-upstream-propagate-all-errors-from-kccb-cmd-submission-code-v6-0-d9d5375665ed@imgtec.com> In-Reply-To: <20260924-b4-upstream-propagate-all-errors-from-kccb-cmd-submission-code-v6-0-d9d5375665ed@imgtec.com> To: Alessio Belle , Luigi Santivetti , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: , , , Alexandru Dadu X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790230815; l=920; i=alexandru.dadu@imgtec.com; s=20260304; h=from:subject:message-id; bh=cByg57c+ZiNGGtOS/HfykUAf4O4HN7h9mKZN2uVWCm4=; b=/n2CvSQds80cz0e6GwYVj+CfqHQ/R21RjKsBkCILrwr6zjpo3hMLZaSZ0hHgNlYcPkVi34j1u h8nG5MWNOgUD+ugUVEVi62DN1FFVrTxoD/bZ0dyDollcYQEu4OBNgC1 X-Developer-Key: i=alexandru.dadu@imgtec.com; a=ed25519; pk=FU07SyNrYGwhahqSxbWEuzyXlUh47xBXvLvOR7UA6+U= X-Authority-Analysis: v=2.4 cv=GPKdgeNK c=1 sm=1 tr=0 ts=6ab4c123 cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=sVS2Dey4ZWMA:10 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=7RYWX5rxfSByPNLylY2M:22 a=r_1tXGB3AAAA:8 a=MguH0ROApdJ8RnWAcOUA:9 a=QEXdDO2ut3YA:10 a=t8nPyN_e6usw4ciXM-Pk:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDAyNiBTYWx0ZWRfX7GkZ1klCHctS QZv773aCBJJyYp/ANJStm+YAIrRo3kOJHvqNYMmHljSqLUX9EyT1gV/LSPfvsMwRsOiMILdHlrf aSw418FNQFFoGuROgbDYNJjImMPAWYJQwTaoTZaRq/UVWn744+WlBpaN5D9AikfUpg9WLG74W5v P34HeY7Dx04YgnfuTNL+cn+ZST61AU4D4Ee+sVH09AEYJiIaIAnxhPvrIRhlwmmVAdrlHSCdhrH x0OSEp7DATcRdU4f1XdwWIWTwv3G+opGchbWLVBhiQbSAxjCtmOQUOzlvyiwGIFs1wdekT5ayai acF5DQE3Wnjo7PcQOeFqvFTSEx9nx73hBiD6MCLF7i+r+l9xtlqeHm1caRhT9nOjc3UgP9fBSsD vxPgsy6gY4eUCAuPRZgQupOJZ7sqsWDtFYSubVx0ycX50gqz++xKr0IeMzvOByg2ZYqPE3DJvDy kbrEb5wRJgUdqzAuY0g== X-Proofpoint-ORIG-GUID: USgOZ1Iij81aEMFYT94nxSK1vrMxt71H X-Proofpoint-GUID: USgOZ1Iij81aEMFYT94nxSK1vrMxt71H X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDAyNiBTYWx0ZWRfXwLhNr7fCCREI 1iVDq5AhPZQ11cQGycN8JDfQBwaEPLVu6lYPogKUaFO03CdfJSC++yahs2sL2S6EPUpVd9nCVPS 6pPG4zKKGIOWKeJW1PT8oZjSc7lz8cw= Add early release of the power references in case of errors. Signed-off-by: Alexandru Dadu --- drivers/gpu/drm/imagination/pvr_queue.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/imagination/pvr_queue.c b/drivers/gpu/drm/imagination/pvr_queue.c index b58c0887cafe..1b013791897d 100644 --- a/drivers/gpu/drm/imagination/pvr_queue.c +++ b/drivers/gpu/drm/imagination/pvr_queue.c @@ -817,9 +817,19 @@ static struct dma_fence *pvr_queue_run_job(struct drm_sched_job *sched_job) trace_pvr_job_submit_fw(job); } + err = pvr_job_get_pm_ref(job); + if (WARN_ON(err)) goto err_release; + if (job->paired_job) { + err = pvr_job_get_pm_ref(job->paired_job); + if (WARN_ON(err)) { + pvr_job_release_pm_ref(job); + goto err_release; + } + } + return dma_fence_get(job->done_fence); err_release: -- 2.43.0