From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: david.nystrom@est.tech, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
ricardo.neri@intel.com,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Subject: [PATCH 0/3] hwmon: (coretemp) Report unreliable temperature readings
Date: Thu, 24 Sep 2026 19:33:19 -0700 [thread overview]
Message-ID: <20260924-coretemp-temp-fault-v1-0-1884f0ff97d5@linux.intel.com> (raw)
Hi,
Intel CPUs indicate in IA32_[PACKAGE]_THERM_STATUS whether the digital
thermal readout they expose is valid. coretemp deliberately ignores that
indication, for the reason given in commit bf6ea084ebb5 ("hwmon:
(coretemp) Do not return -EAGAIN for low temperatures"): some CPUs clear
it while the temperature is too low to be measured, and the value reported
in that state is more useful to userspace than an error would be.
The consequence is that userspace cannot distinguish a genuinely low
temperature from one the CPU could not measure. This series exposes the
indication through the standard hwmon temp%d_fault attribute, leaving
temp%d_input exactly as it is.
One user-visible effect is worth mentioning: sensors(1) prints FAULT in
place of the temperature when temp%d_fault reads 1. On a CPU that clears
the valid bit at low temperature, that core stops showing a number in the
default output, although sensors -u and -j still report it, as does
anything that reads temp%d_input from sysfs directly. A driver-custom
attribute name would avoid this, but would be invisible to generic tools.
Reporting the condition through the documented attribute looks like a
better option, but please say if you prefer otherwise.
Patch 1 is pre-work: it fixes an existing bug where, on 32-bit kernels,
the first temperature read is skipped and temp%d_input reports zero for
the first 301 seconds of uptime. Both the bug and the fix were verified
with a 32-bit kernel. It carries a Fixes: tag and does not depend on the
rest of the series.
Patch 2 stops reading TjMax on a cache hit, where the value is discarded.
It is separate so that the behavioral change is not buried in the
restructuring patch 3 does.
Patch 3 adds temp%d_fault.
Thanks and BR,
Ricardo
Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
---
Ricardo Neri (3):
hwmon: (coretemp) Refresh the temperature on the first read
hwmon: (coretemp) Read TjMax only when refreshing the temperature
hwmon: (coretemp) Add temp%d_fault sysfs attribute
Documentation/hwmon/coretemp.rst | 4 +++
drivers/hwmon/coretemp.c | 71 +++++++++++++++++++++++++++++-----------
2 files changed, 55 insertions(+), 20 deletions(-)
---
base-commit: 93f51579e7df248780214094418f205253383cc5
change-id: 20260831-coretemp-temp-fault-a44c447936ec
Best regards,
--
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
next reply other threads:[~2026-09-25 2:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 2:33 Ricardo Neri [this message]
2026-09-25 2:33 ` [PATCH 1/3] hwmon: (coretemp) Refresh the temperature on the first read Ricardo Neri
2026-09-25 2:33 ` [PATCH 2/3] hwmon: (coretemp) Read TjMax only when refreshing the temperature Ricardo Neri
2026-09-25 2:33 ` [PATCH 3/3] hwmon: (coretemp) Add temp%d_fault sysfs attribute Ricardo Neri
2026-09-25 2:37 ` [PATCH 0/3] hwmon: (coretemp) Report unreliable temperature readings Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924-coretemp-temp-fault-v1-0-1884f0ff97d5@linux.intel.com \
--to=ricardo.neri-calderon@linux.intel.com \
--cc=david.nystrom@est.tech \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ricardo.neri@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®