From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AE4037F73E; Thu, 24 Sep 2026 14:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790258496; cv=none; b=CzGzpq6yZzYCYR/X8wcFZIsXGg0lLMZbRLpCJ1IsqdzQSwrEI53hKor76D24Nw2nZfppZjDFYV1rtM+6i3meNdVRmo7uvHwNVJUfayN1rWkndxBNfyqZ/NTiZmwJJtElHg90DPIllkAvQgDEnX0k/liyp6ojI2P3eHuEFdm6D08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790258496; c=relaxed/simple; bh=ZNijc5MOKUhzAFx9b3sabAhG9y17oQclhc/PpQz74Pg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZGRK0WiU6C3VCrBiAXwSwUEXdWhNVPZIPVWncEIlwBJ+dSCDYNjCGCKCMAFujKWAS+D7VhpfnXywHG/SgVnjYqfDtYFSMM6TMaGi0bu/FXA2f5NclMNwRf7glG4bZD9ezsnO1dNDMCDMPszNeJqJXZU7eGqyXnd+wB9eCERaiRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OoE828Mc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OoE828Mc" Received: by smtp.kernel.org (Postfix) with ESMTPS id 125D3C4AF09; Thu, 24 Sep 2026 14:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1790258496; bh=ZNijc5MOKUhzAFx9b3sabAhG9y17oQclhc/PpQz74Pg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=OoE828McXFL0/V6pcsgYqJxMBPGC/GjR2neOx8orTlfBJqMHxkxYclz5YuIQQfdg/ VMdp57x01sDlV/77b00XNIR3nP4LrM2BB50PprdWS050hqEGiNeQdwcsNmCdEyOdbP Q1IAVITboTr3JeCu/A6z158wF5RF0NDFVuH5CIKCL8o3fDeNVedu/icGxkIWQDpXGr v9RMVqFzJdy8hre6q1k2BK+TC0PxarnuKfqQMX0ATTn3/akzGUlXD0YAIQIiS1LM3T qBcsOreeBMQv9/4v0OENbth5Gsb7MtVDpXYHmzQWsrrtbF5ddS/2z8qHN0gZmjX3Vm bnZ0Y/fn8Imwg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 003FEC9831F; Thu, 24 Sep 2026 14:01:36 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 24 Sep 2026 16:01:35 +0200 Subject: [PATCH v2 07/11] drm/panel: s6e3ha8: Assert reset GPIO in unprepare Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260924-crosshatch-panel-v2-7-08d5c7bf72fc@ixit.cz> References: <20260924-crosshatch-panel-v2-0-08d5c7bf72fc@ixit.cz> In-Reply-To: <20260924-crosshatch-panel-v2-0-08d5c7bf72fc@ixit.cz> To: Dzmitry Sankouski , Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: Petr Vorel , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1147; i=david@ixit.cz; h=from:subject:message-id; bh=+wJwzxl6R6kFsAw/IP8INT9PZdDDVelgZpdEfbOYejM=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBqtS09+kmOyC3qmmduvr07jHQ5sps+RXxREaQTh TqcBIdNFPOJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCarUtPQAKCRBgAj/E00kg ctzqD/4vq65LGGkUX0Ykq7LT8/pNIFwf2tY0PmuVkWhAPlyAfbx2oofy4IwyvvBH5Ch+45SiLuO ikgycsyvBwM7P+tF+JfpoUuzTpJ+AaSGxtqQ5okGW9t8DQWQlpuuwl300jKBMO8sH2FfO8UaSbK fyTF8sWh5u7M1nXo88TTOR9gGPpeBzTUNDI2eEKPqk09mpAojj34+WjNehvImSYDNRUrRDlkrNq twr4EIv3nEkcJleLAC1wHiGbR/rwvm6bb2EZLRNr6i7jLc7qtORBEaK+KgGYtH/vgTyydDEJztR DsvtdiLLIGsDbV3IoAWTZS6BP6zT5ToDE1+zokt1X2DzCRonY3sQxJ3F2zs48dOOIA40MOlHeOg bDgFXyONE0vMZ9qwgq9DKM9/pJHViDl3cSgzKIRPNMT9Lh3bzFOTTKJ1H3QNjU65Tsl1ADZFHSA LisOhkepB+s93s1jj4pPlgG+mk3wJQJgOpq9QGBc+RweW5rbIBPN+njmi0jg9nq8WGcac9KYuJh FOt8rSn1XXoXg41NCC3k7bONDN9ovLnk40AFqoisqOODZVLL0RP6n2VH1lYU9F8kN/UXqQF3AVM 1G9vCw/I9HVCI+2n/H6O70PwBqb7J+u/yoakVJFCBavZAYiBvO9of/JPF/0IAGSxdrW70yhPekR X7aSXeaY2/j4ieg== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg For correct shutdown, the reset should be asserted. Assisted-by: LLM Reviewed-by: Neil Armstrong Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c index 99290913de69a..2591b8c1a7753 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c @@ -58,16 +58,17 @@ static int s6e3ha8_get_modes(struct drm_panel *panel, return drm_connector_helper_get_modes_fixed(connector, priv->desc->mode); } static int s6e3ha8_unprepare(struct drm_panel *panel) { struct s6e3ha8 *priv = to_s6e3ha8(panel); + gpiod_set_value_cansleep(priv->reset_gpio, 1); return regulator_bulk_disable(priv->desc->num_supplies, priv->supplies); } static void s6e3ha8_amb577px01_wqhd_reset(struct s6e3ha8 *priv) { gpiod_set_value_cansleep(priv->reset_gpio, 0); usleep_range(5000, 6000); gpiod_set_value_cansleep(priv->reset_gpio, 1); -- 2.55.0