From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f35.google.com (mail-wr2-f35.google.com [74.125.225.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23C5E4CE66A for ; Thu, 24 Sep 2026 20:04:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790280287; cv=none; b=L9aJHqKuU/GPy2AKRAc01JRIxLochm7S8MhsbulE8CoY86FcrKKb/UKtHhtSEORXaMZebMUwYezU+OzUTJbodbTolmxezYZPatWRoFDv9NzIPdUjScuedPlbTJCus8oDSmfBLKiNqumoznAC4WlYus3SuAFgxkLDtmDwByf/83A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790280287; c=relaxed/simple; bh=SAkLzrZ+NgrWoSnB0dRUCDukrxXHAouRh2jFxYeJoIE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ETn3FhQ5htOHtmPdrJoXALZgce6onepfDtljaBNHl71IpdkjKuYZ145gB02yehjQZj1316hyXmiOd58IFwBZHEJmRzHjAYTGHzCPeLYU5hY/Wcq2qFmxifvf7gJH885uYUNr751FQCtdwiHIQyZ3wzLtuzeLT0HDuy6nxFOpvzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CWdZcowJ; arc=none smtp.client-ip=74.125.225.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CWdZcowJ" Received: by mail-wr2-f35.google.com with SMTP id ffacd0b85a97d-4887d06c669so35046f8f.3 for ; Thu, 24 Sep 2026 13:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790280283; x=1790885083; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cbc6iQ0ywUYDK1nXJ/WmLZf8Dcp9GFj+ZSwYgXpoTt8=; b=CWdZcowJx6uDQLEX0cRw1S6Elhcj5GeQEeYZivEfJlc04FYIwayS2JmTpGQC382/nV xaAoJ7j2tIhKFSggzGf7iAAD1msOWlBA1P9J70xiDF5lpWzPktdCufMLpWqSUL3z53+e owXT8S7wj2dVpHlzEmWVJyrtYQ332v/F88WDZm06IsQ2PouXUKVIictdUOYyxbrkIFAj CyLTUsPGMkpE8JX45gdSkQ1HrcI1CjB8dvIIxdML/X6Sa4AUYvo8T+mxgY4x7NLUeHzZ JLk48y7PFaY/ux5xbrIAnx6LOGmaz1HT7e/ZNkeFDBhuJedVU33ohM3/8MxJu3ZyNn0l AJRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790280283; x=1790885083; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cbc6iQ0ywUYDK1nXJ/WmLZf8Dcp9GFj+ZSwYgXpoTt8=; b=fXyPw1dhO4fvUwTuYAKngiFWW+wDOJbVfZlS2jpSOiPmvlNMs/1fI0EPkLPTeo13h2 nitVPvJcPc/Ncs/fCWebAsXw1d1PC4Or8nI1k0qkPzsiwhtJtvjA1rm45UPgslnpgFCN B4SmaBNo/Js0hqdegWfwlQzHyFJVE8v2+qNoComVGZTLM8I22l5ZskIIBEx9pRa9MaCF dg2/qErHAGNg9KI5V1X1fmF2ed0acyBoMgCNC9g1xl/Lq63DFANQA9WV6HDpLmdrap24 iBerEVmCBVAn3LubaZ8runfMgoQkelvOC+jn1IyN/NMaZDNDRs1FRkoKaEvp/FfRg1eN G4OA== X-Forwarded-Encrypted: i=1; AKwUvByjDx3O2rIQKQaSTNuXOauzQ7oz5nev5Lbi1h5p2aYRnTVDtFxU2UJ4AE5Mrp+pMZvZ6ArDG1ilCDodeLE=@vger.kernel.org X-Gm-Message-State: AFuF++lf84eoMcGVoNwAxBm1KCECfSxh2kyQG9NzsimmtiH3uJhkhdbq 7osbQC5Utm19/uJskrO4x6XhfcbEEAyb7eXZsYl6pojfHNZyDBM1dA4N X-Gm-Gg: AYBFou0C9pN64O379xraT69oNrr6nq29fT8JH/kDslaWWedgpLJUZLFC4tK3SZo7j47 agGupoDNuYmp3H/fH+OhGQ5SlX5bZSbkYi1iQ4yQVhXZKz3MUNiMrMa5sjaHjiH2WLyFTfYC4mw H0pHSJp3NKnmS52iayVFK1u310a1+3+nIGmAqNS/gKIohgAClj+BQm8CgRKo1sIR988KAqaKDqA Qh8+wV+eiMOJIJ33zjRH5+vzqDII+frXDiSIAJcGYEl7Lai8Pi16Zs8dCPQwLVc01Swn6iK9sMP xsub5qYJ5JW/nWlwYGto5kTh5eVO1+cUEYVTRQ8IrWPgXosa3LY6SpuePaFlpEMGvhsr17Eqca9 xdHXValS2uE2dcqMcLMxYXDwZVSyu6OK8jTvVnpz0fPop+cDCPXtawyHD5xOnIgxBbeWcaSU2JM BFswVl1xJb7f1KYYtHE3eFNCbjELpsz0csz83sYC+jvIcPlsT9X7F9Y3oeu2s77U5JJQzrgK+1h euJAZojocWjmISV6QqKeihZ3JA= X-Received: by 2002:a05:6000:40db:b0:487:21be:dcc6 with SMTP id ffacd0b85a97d-48872a77f45mr6028406f8f.21.1790280283045; Thu, 24 Sep 2026 13:04:43 -0700 (PDT) Received: from [192.168.0.253] (5403F394.catv.pool.telekom.hu. [84.3.243.148]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-4887a30b1dfsm1551603f8f.4.2026.09.24.13.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 13:04:42 -0700 (PDT) From: Gabor Juhos Date: Thu, 24 Sep 2026 22:04:21 +0200 Subject: [PATCH 6/8] mtd: rawnand: qcom: make nandc_set_read_loc_last() more generic Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260924-qcom_nandc-share-more-code-v1-6-f3012199b161@gmail.com> References: <20260924-qcom_nandc-share-more-code-v1-0-f3012199b161@gmail.com> In-Reply-To: <20260924-qcom_nandc-share-more-code-v1-0-f3012199b161@gmail.com> To: Manivannan Sadhasivam , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: Md Sadre Alam , linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.3 The function gets a 'nand_chip' pointer as a parameter but it is only used to extract a pointer to the nand controller's private structure from that. In order to make the function more generic, change the declaration to get a 'qcom_nandc_controller' pointer directly, and update the callers accordingly. While at it, also change the function name to use a 'qpic_nandc' prefix. No functional changes intended. This is in preparation of moving the function into the 'qpic_common' code to allow reusing it from the 'spi-qpic-snand' driver. Signed-off-by: Gabor Juhos --- drivers/mtd/nand/raw/qcom_nandc.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c index 96a1a5a03de8..cc1e64ac4245 100644 --- a/drivers/mtd/nand/raw/qcom_nandc.c +++ b/drivers/mtd/nand/raw/qcom_nandc.c @@ -181,8 +181,8 @@ static void qcom_nandc_set_read_loc_first(struct qcom_nand_controller *nandc, } /** - * nandc_set_read_loc_last - to set read location last register - * @chip: NAND Private Flash Chip Data + * qcom_nandc_set_read_loc_last - to set read location last register + * @nandc: NAND controller's private data * @reg_base: location register base * @cw_offset: code word offset * @read_size: code word read length @@ -190,11 +190,10 @@ static void qcom_nandc_set_read_loc_first(struct qcom_nand_controller *nandc, * * This function will set location last register value */ -static void nandc_set_read_loc_last(struct nand_chip *chip, - int reg_base, u32 cw_offset, - u32 read_size, u32 is_last_read_loc) +static void qcom_nandc_set_read_loc_last(struct qcom_nand_controller *nandc, + int reg_base, u32 cw_offset, + u32 read_size, u32 is_last_read_loc) { - struct qcom_nand_controller *nandc = get_qcom_nand_controller(chip); __le32 locreg_val; u32 val = FIELD_PREP(READ_LOCATION_OFFSET_MASK, cw_offset) | FIELD_PREP(READ_LOCATION_SIZE_MASK, read_size) | @@ -226,8 +225,9 @@ static void nandc_set_read_loc(struct nand_chip *chip, int cw, int reg, reg_base += reg * 4; if (nandc->props->qpic_version2 && qcom_nandc_is_last_cw(ecc, cw)) - return nandc_set_read_loc_last(chip, reg_base, cw_offset, - read_size, is_last_read_loc); + return qcom_nandc_set_read_loc_last(nandc, reg_base, cw_offset, + read_size, + is_last_read_loc); else return qcom_nandc_set_read_loc_first(nandc, reg_base, cw_offset, read_size, @@ -1916,7 +1916,7 @@ static int qcom_param_page_type_exec(struct nand_chip *chip, const struct nand_ len = nand_subop_get_data_len(subop, op_id); if (nandc->props->qpic_version2) - nandc_set_read_loc_last(chip, reg_base, 0, len, 1); + qcom_nandc_set_read_loc_last(nandc, reg_base, 0, len, 1); else qcom_nandc_set_read_loc_first(nandc, reg_base, 0, len, 1); -- 2.55.0