From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 65ADF4BF941 for ; Thu, 24 Sep 2026 17:34:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790271272; cv=none; b=IoHUxXlesdb8IlLD0t0xiUnBNp7a+V8J2fj7wdZ/EU+HBTXh5njMN9vHwUizkYfO3dqmSuJtAdesZnLI6KD++K6xJKLLeWzRhIJXZceF2BTKLKgA+68fiiMwjcbJ39GuJoEvE4rCVKnGV6hQeipgL2dj5XQdotAgVnSO9wmDwQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790271272; c=relaxed/simple; bh=TiWi/q8xGcjEmeDCS5JuOhiRjHoHgT0etgyhg2oNuXc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eGGUQRnQZZAWe89bHjlK02xSHQQS+h2XeUZ2beQ0AMwfiF+BG9OutVzqyCooos40sf7IqdurP7h9qt406e0AgG/76HDcDdXWBOfFs+0e0003K2mcuTpfwOs88GSQUfeWuMRsh1iyBMEAk9XyXrC39c2lz44A5hj/i4eyYQBLeHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=t5n8vMau; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="t5n8vMau" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 538901E5E; Thu, 24 Sep 2026 10:34:26 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.2.213.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8204C3F86F; Thu, 24 Sep 2026 10:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1790271269; bh=TiWi/q8xGcjEmeDCS5JuOhiRjHoHgT0etgyhg2oNuXc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=t5n8vMauLKUNGewc6qGbdTdgiWoSsHiWd545D+clGvhHCm8X1SCMQyzgJKdRENxHa qCDvzM01DZdZH+wt1DE5/MWeg+tgd6oFh5Vwa/bp2kSyshBAmV1d8MKVyeT79ll6ip CcCPLvfoNJJ+6YFvjClD1l0ARyiVVfy7UKWFAhMM= From: Yeoreum Yun Date: Thu, 24 Sep 2026 18:33:44 +0100 Subject: [PATCH v12 06/14] coresight: etm3x: remove redundant cpu online check on etm_enable_sysfs() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260924-separate_etm_cfg_v2-v12-6-a2b41d2f7c2b@arm.com> References: <20260924-separate_etm_cfg_v2-v12-0-a2b41d2f7c2b@arm.com> In-Reply-To: <20260924-separate_etm_cfg_v2-v12-0-a2b41d2f7c2b@arm.com> To: Mike Leach , James Clark , Leo Yan , Greg Kroah-Hartman , Mathieu Poirier , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev Cc: Suzuki K Poulose , Alexander Shishkin , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , Yeoreum Yun X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1758; i=yeoreum.yun@arm.com; h=from:subject:message-id; bh=TiWi/q8xGcjEmeDCS5JuOhiRjHoHgT0etgyhg2oNuXc=; b=owEB7QES/pANAwAKAW3Vw9FaxTEzAcsmYgBqtV8OOoiUehSE1NCtOJ1jrZk1LRnIxlqhwtfLD +wrqBN2BiiJAbMEAAEKAB0WIQQtg+CS3QUzuFh1pJ1t1cPRWsUxMwUCarVfDgAKCRBt1cPRWsUx M3qqC/wLixn4NISa+k9QHAOi6tql6I269pCxge8QEpe6MtXp+t6cfKZjxOL+VwY9icKelUhKM10 x24Xh9cxyQf7gHok5eY33i+le6pC85/2IVG3+upW0xCP/SgBPiZNAJ4WpWvKUfQVYzn5seDf2FO cxf+0vS20IB7yVaHbE0NsVxbKCmW0ktxL9aGuw7F8Fatj2Sj9UZWes/lVWphEHVE769d55ohpr6 i/GMUjjhEStPpd7QpK6KDheI1kOZidQ5zHnFcqMo0tcy/YR0wNGtNvvuHNncYwAz+xf+rCxhvjt GoFSlzMvQu6mQeEquQ+jht+3jdI1AQfuQ2xP8fWa/Cd9nYN/iWeWNRwtv+qUrOMKBr2tQP6u5m0 9xah3KMiuB1d/RYOR7IJTvaDor0syE3dXk8xG+VsjyadtX9cORAlC4HArsDwZ72mTSaxJUDhZ8c YuFurBvQFVUApYFEnZgrrp/H5Uk8BapLy2yddoesRg8wxv7j3P0JzxcRDQLLghTBBBPfo= X-Developer-Key: i=yeoreum.yun@arm.com; a=openpgp; fpr=2D83E092DD0533B85875A49D6DD5C3D15AC53133 cpu online() check is done in coresight_validate_source_sysfs() already. and smp_call_function_single() will fail when cpu is offline. Therefore, remove redundant check in etm_enable_sysfs(). Reviewed-by: Mike Leach Tested-by: Leo Yan Signed-off-by: Yeoreum Yun --- drivers/hwtracing/coresight/coresight-etm3x-core.c | 26 +++++++++------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm3x-core.c b/drivers/hwtracing/coresight/coresight-etm3x-core.c index dcadcc383012..ac7c154720cb 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c @@ -513,25 +513,19 @@ static int etm_enable_sysfs(struct coresight_device *csdev, struct coresight_pat return -EBUSY; } - /* - * Configure the ETM only if the CPU is online. If it isn't online - * hw configuration will take place on the local CPU during bring up. - */ - if (cpu_online(drvdata->cpu)) { - arg.drvdata = drvdata; - arg.path = path; + arg.drvdata = drvdata; + arg.path = path; - scoped_guard(spinlock, &drvdata->spinlock) { - drvdata->curr_config = drvdata->config; - } + scoped_guard(spinlock, &drvdata->spinlock) { + drvdata->curr_config = drvdata->config; + } - ret = smp_call_function_single(drvdata->cpu, - etm_enable_sysfs_smp_call, &arg, 1); - if (!ret) - ret = arg.rc; - } else { + ret = smp_call_function_single(drvdata->cpu, + etm_enable_sysfs_smp_call, &arg, 1); + if (!ret) + ret = arg.rc; + else ret = -ENODEV; - } if (!ret) { dev_dbg(&csdev->dev, "ETM tracing enabled\n"); -- 2.43.0