From: Yuho Choi <oss.patchbox@gmail.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mike Leach <mike.leach@arm.com>,
James Clark <james.clark@linaro.org>, Leo Yan <leo.yan@arm.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Yuho Choi <oss.patchbox@gmail.com>
Subject: [PATCH v2] coresight: Check runtime PM resume result
Date: Wed, 23 Sep 2026 20:18:56 -0400 [thread overview]
Message-ID: <20260924001906.715322-1-oss.patchbox@gmail.com> (raw)
coresight_get_ref() ignores the return value of pm_runtime_get_sync()
and reports success even when runtime resume fails. A path is then built
and the CoreSight device may be accessed while it remains powered off.
Use pm_runtime_resume_and_get() so a failed resume is reported and its
runtime PM usage reference is rolled back. Drop the module and device
references acquired before the resume attempt when it fails.
Fixes: 32b0707a4182 ("coresight: Add try_get_module() in coresight_grab_device()")
Signed-off-by: Yuho Choi <oss.patchbox@gmail.com>
---
Changes in v2:
- Point Fixes: at commit 32b0707a4182, which introduced coresight_get_ref()
with the unchecked pm_runtime_get_sync() (Anshuman Khandual)
- Switch to my oss.patchbox address
v1: https://lore.kernel.org/all/20260802232552.593435-1-dbgh9129@gmail.com/
drivers/hwtracing/coresight/coresight-core.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
index 928488a216d4..c492f9082c46 100644
--- a/drivers/hwtracing/coresight/coresight-core.c
+++ b/drivers/hwtracing/coresight/coresight-core.c
@@ -843,7 +843,11 @@ static bool coresight_get_ref(struct coresight_device *csdev)
goto err_module;
/* Make sure the device is powered on */
- pm_runtime_get_sync(parent);
+ if (pm_runtime_resume_and_get(parent) < 0) {
+ module_put(drv->owner);
+ goto err_module;
+ }
+
return true;
err_module:
base-commit: f0100363d8c374bd8e9ea7c9ba02744f0b802ca4
--
2.43.0
next reply other threads:[~2026-09-24 0:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 0:18 Yuho Choi [this message]
2026-09-24 8:15 ` Leo Yan
2026-09-24 15:27 ` Yuho Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924001906.715322-1-oss.patchbox@gmail.com \
--to=oss.patchbox@gmail.com \
--cc=anshuman.khandual@arm.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®