mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Changhuang Liang <changhuang.liang@starfivetech.com>
To: jszhang@kernel.org
Cc: broonie@kernel.org, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org
Subject: [PATCH v3 3/5] spi: dw: remove duplicated "!rx_len && !tx_len" handling from dw_spi_irq
Date: Wed, 23 Sep 2026 19:14:09 -0700	[thread overview]
Message-ID: <20260924021409.4207-1-changhuang.liang@starfivetech.com> (raw)
In-Reply-To: <20260909143652.9234-4-jszhang@kernel.org>

> dw_spi_irq() need not handle enhanced-transfer's "!rx_len && !tx_len"
> case as that state is already handled by dw_spi_enh_handler()
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>

Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>

> ---
>  drivers/spi/spi-dw-core.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
> index f4c4e9dae25e..91de357f97f3 100644
> --- a/drivers/spi/spi-dw-core.c
> +++ b/drivers/spi/spi-dw-core.c
> @@ -284,12 +284,6 @@ static irqreturn_t dw_spi_irq(int irq, void *dev_id)
>  		dw_spi_mask_intr(dws, 0xff);
>  		return IRQ_HANDLED;
>  	}
> -	if (dws->transfer_handler == dw_spi_enh_handler &&
> -	    !dws->rx_len && !dws->tx_len) {
> -		dw_spi_mask_intr(dws, 0xff);
> -		spi_finalize_current_transfer(ctlr);
> -		return IRQ_HANDLED;
> -	}
>
>  	return dws->transfer_handler(dws);
>  }

  reply	other threads:[~2026-09-24  2:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 14:36 [PATCH v3 0/5] spi: dw: use threaded interrupt Jisheng Zhang
2026-09-09 14:36 ` [PATCH v3 1/5] spi: dw: use DW_SPI_ISR directly Jisheng Zhang
2026-09-09 14:36 ` [PATCH v3 2/5] spi: dw: remove useless dws->transfer_handler check Jisheng Zhang
2026-09-09 14:36 ` [PATCH v3 3/5] spi: dw: remove duplicated "!rx_len && !tx_len" handling from dw_spi_irq Jisheng Zhang
2026-09-24  2:14   ` Changhuang Liang [this message]
2026-09-09 14:36 ` [PATCH v3 4/5] spi: dw: restore previous irq handling behavior when !ctlr->cur_msg Jisheng Zhang
2026-09-24  2:13   ` Changhuang Liang
2026-09-09 14:36 ` [PATCH v3 5/5] spi: dw: use threaded interrupt and optimize the threaded ISR Jisheng Zhang
2026-09-10 22:17   ` Mark Brown
2026-09-11 14:22   ` Joseph Steel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924021409.4207-1-changhuang.liang@starfivetech.com \
    --to=changhuang.liang@starfivetech.com \
    --cc=broonie@kernel.org \
    --cc=jszhang@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®