From: Eric Biggers <ebiggers@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: x86@kernel.org, Thomas Gleixner <tglx@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-kernel@vger.kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] x86/fpu: Remove unnecessary checks for X86_FEATURE_FPU
Date: Wed, 23 Sep 2026 20:24:46 -0700 [thread overview]
Message-ID: <20260924032446.GA5048@sol> (raw)
In-Reply-To: <20260923211450.GBarRBSoXGFKvUBwe7@fat_crate.local>
On Wed, Sep 23, 2026 at 02:14:50PM -0700, Borislav Petkov wrote:
> On Mon, Aug 31, 2026 at 11:57:06AM -0700, Eric Biggers wrote:
> > Since commit ab05214025ee ("x86/fpu: Remove MATH_EMULATION and related
> > glue code"), X86_FEATURE_FPU is mandatory. If it's absent, the kernel
> > halts execution in fpu__init_system_early_generic(). Remove unnecessary
> > checks for X86_FEATURE_FPU that occur later in core x86 code.
> >
> > Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> > ---
> > arch/x86/kernel/fpu/bugs.c | 4 ----
> > arch/x86/kernel/fpu/core.c | 2 +-
> > arch/x86/kernel/fpu/init.c | 2 --
> > arch/x86/kernel/fpu/xstate.c | 5 -----
> > 4 files changed, 1 insertion(+), 12 deletions(-)
>
> Sashiko might have a point here:
>
> https://sashiko.dev/#/patchset/20260831185706.90103-1-ebiggers%40kernel.org
Sure, there's more stuff that can be removed too. It will make for a
large patch, but I'll try to get the rest in x86/fpu code.
- Eric
prev parent reply other threads:[~2026-09-24 3:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 18:57 Eric Biggers
2026-08-31 19:59 ` H. Peter Anvin
2026-09-23 21:14 ` Borislav Petkov
2026-09-24 3:24 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924032446.GA5048@sol \
--to=ebiggers@kernel.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®