mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ahmed Abdelhaleem Ahmed <ahmedhal@gmail.com>
To: James.Bottomley@HansenPartnership.com, mkp@kernel.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	loberman@redhat.com, yanghao_ht@163.com
Subject: Re: [PATCH] scsi: ch: Do not keep references to data transfer element devices
Date: Thu, 24 Sep 2026 06:04:40 +0000	[thread overview]
Message-ID: <20260924060440.33252-1-ahmedhal@gmail.com> (raw)
In-Reply-To: <20260922-ch-dt-leak-v1-1-2b2e40bf1624@gmail.com>

> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

Self-correction: that Fixes tag is wrong. drivers/scsi/ch.c is not part of
the initial git import; it was added a month later, already containing the
lookup into ch->dt[] and the kfree() that drops nothing:

  $ git cat-file -t v2.6.12-rc2:drivers/scsi/ch.c
  fatal: Not a valid object name v2.6.12-rc2:drivers/scsi/ch.c

  $ git log --diff-filter=A --oneline -- drivers/scsi/ch.c
  daa6eda65a53 [SCSI] add scsi changer driver

So the correct tag is

Fixes: daa6eda65a53 ("[SCSI] add scsi changer driver")

first released in v2.6.13-rc1. Nothing since has touched the ch->dt[]
reference handling: the only other commits mentioning scsi_device_put() or
ch->dt in this file are 66167283c21e ("scsi: ch: fixup refcounting imbalance
for SCSI devices"), which does not touch dt[], a2cf8a6306c8 ("[SCSI] ch:
Check NULL for kmalloc() return") and 85bc081f44d5 (kmalloc -> kcalloc).

Please amend when applying, or say the word and I will send a v2.

Thanks,
Ahmed

      parent reply	other threads:[~2026-09-24  6:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 15:46 Ahmed Abdelhaleem Ahmed via B4 Relay
2026-09-22 20:47 ` Laurence Oberman
2026-09-24  6:04 ` Ahmed Abdelhaleem Ahmed [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924060440.33252-1-ahmedhal@gmail.com \
    --to=ahmedhal@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=loberman@redhat.com \
    --cc=mkp@kernel.org \
    --cc=yanghao_ht@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®