mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Ming Wang <wangming01@loongson.cn>,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	stable@vger.kernel.org, Oliver Neukum <oliver@neukum.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: usb: cdc_mbim: add MeiG Smart SRM821 to ZLP whitelist
Date: Thu, 24 Sep 2026 16:22:54 +0200	[thread overview]
Message-ID: <2026092409-status-rocker-0fef@gregkh> (raw)
In-Reply-To: <4d5e2857-e6eb-43e2-b668-83e779aaa734@redhat.com>

On Thu, Sep 24, 2026 at 12:24:06PM +0200, Paolo Abeni wrote:
> On 9/20/26 09:44, Ming Wang wrote:
> > The MeiG Smart SRM821 5G module (0x2dee:0x4d53) crashes and drops off
> > the USB bus when it receives a Zero Length Packet (ZLP) after sending
> > or receiving an NTB of exactly 16384 bytes (tx_max).
> > 
> > According to the MBIM specification, devices do not require a ZLP
> > if the NTB size is exactly dwNtbOutMaxSize. However, the cdc_mbim
> > driver defaults to sending ZLPs for devices not explicitly whitelisted
> > to accommodate non-conformant hardware. This default behavior breaks
> > the strictly conformant MeiG SRM821 module.
> > 
> > Add this device to the ZLP conformance whitelist (cdc_mbim_info) so
> > the driver will pad the NTB to avoid sending ZLPs, preventing the
> > device firmware from crashing.
> > 
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Ming Wang <wangming01@loongson.cn>
> 
> Before any other step, please read:
> 
> https://elixir.bootlin.com/linux/v7.3-rc3/source/Documentation/process/maintainer-netdev.rst#L454
> 
> AFAICS this is actually support for additional H/W, just worded in
> very unusual way: please reword the commit message accordingly and
> drop stable from CC.

Why drop stable from cc:?  Do you not want it in any stable kernel
release?  Seems like it should be to me, we gladly take quirk additions
and new device ids in stable kernels.

thanks,

greg k-h

  reply	other threads:[~2026-09-24 14:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20  7:44 Ming Wang
2026-09-24 10:24 ` Paolo Abeni
2026-09-24 14:22   ` Greg KH [this message]
2026-09-24 16:28     ` Jakub Kicinski
2026-09-24 16:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026092409-status-rocker-0fef@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=wangming01@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®