From: Jakub Kicinski <kuba@kernel.org>
To: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
Cc: maxime.chevallier@bootlin.com, recv.jo@gmail.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
jun.ann.lai@intel.com, yi.fang.gan@intel.com,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v5 0/5] net: stmmac: Fix double VLAN 802.1ad tag handling
Date: Thu, 24 Sep 2026 09:30:51 -0700 [thread overview]
Message-ID: <20260924093051.71e9cf52@kernel.org> (raw)
In-Reply-To: <20260920153516.103461-1-ovidiu.panait.rb@renesas.com>
On Sun, 20 Sep 2026 15:35:11 +0000 Ovidiu Panait wrote:
> Currently, hardware VLAN stripping is broken for 802.1ad tags. vlan_rx_hw()
> hardcodes ETH_P_8021Q when putting the hardware tag into the skb, rather
> than using the actual protocol from the packet. Because of this, packets
> that contain an 802.1ad outer tag are incorrectly passed up the stack as
> having an 802.1Q tag.
Failed to apply patch:
Applying: net: stmmac: Remove VLAN perfect matching dead code
Applying: net: stmmac: Stop toggling the EDVLP bit
Applying: net: stmmac: Rename double VLAN references to svlan
error: sha1 information is lacking or useless (drivers/net/ethernet/stmicro/stmmac/hwif.h).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0003 net: stmmac: Rename double VLAN references to svlan
--
pw-bot: cr
prev parent reply other threads:[~2026-09-24 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 15:35 Ovidiu Panait
2026-09-20 15:35 ` [PATCH net v5 1/5] net: stmmac: Remove VLAN perfect matching dead code Ovidiu Panait
2026-09-20 15:35 ` [PATCH net v5 2/5] net: stmmac: Stop toggling the EDVLP bit Ovidiu Panait
2026-09-20 15:35 ` [PATCH net v5 3/5] net: stmmac: Rename double VLAN references to svlan Ovidiu Panait
2026-09-20 15:35 ` [PATCH net v5 4/5] net: stmmac: Do not advertise S-VLAN stripping when it is disabled Ovidiu Panait
2026-09-20 15:35 ` [PATCH net v5 5/5] net: stmmac: Disable S-Tag processing on dwmac4 Ovidiu Panait
2026-09-24 16:30 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924093051.71e9cf52@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=jun.ann.lai@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ovidiu.panait.rb@renesas.com \
--cc=pabeni@redhat.com \
--cc=recv.jo@gmail.com \
--cc=yi.fang.gan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®