mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heiko Carstens <hca@linux.ibm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
	linux-um@lists.infradead.org, linux-s390@vger.kernel.org,
	Huacai Chen <chenhuacai@kernel.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 1/4] s390: remove unwind_module_init()
Date: Thu, 24 Sep 2026 14:48:19 +0200	[thread overview]
Message-ID: <20260924124819.13740Cdf-hca@linux.ibm.com> (raw)
In-Reply-To: <20260924144039.4af0d88b163a.I91f8c59a12ad3d5fe67d50aa3b0434d666ffc9f8@changeid>

On Thu, Sep 24, 2026 at 02:35:50PM +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> This is dead code, but will likely conflict with
> the ORC unwinder unification.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  arch/s390/include/asm/unwind.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/s390/include/asm/unwind.h b/arch/s390/include/asm/unwind.h
> index b8ecf04e3468..021056d5982c 100644
> --- a/arch/s390/include/asm/unwind.h
> +++ b/arch/s390/include/asm/unwind.h
> @@ -91,8 +91,5 @@ static inline struct pt_regs *unwind_get_entry_regs(struct unwind_state *state)
>  	     unwind_next_frame(state))
>  
>  static inline void unwind_init(void) {}
> -static inline void unwind_module_init(struct module *mod, void *orc_ip,
> -				      size_t orc_ip_size, void *orc,
> -				      size_t orc_size) {}

This probably went upstream by mistake a couple of years ago.

Acked-by: Heiko Carstens <hca@linux.ibm.com>

  reply	other threads:[~2026-09-24 12:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 12:35 [PATCH 0/4] ORC unwinder cleanup & UML support Johannes Berg
2026-09-24 12:35 ` [PATCH 1/4] s390: remove unwind_module_init() Johannes Berg
2026-09-24 12:48   ` Heiko Carstens [this message]
2026-09-24 12:35 ` [PATCH 2/4] ORC: pull out module handling from x86/loongarch Johannes Berg
2026-09-24 12:35 ` [PATCH 3/4] ORC: unify orc_hash.h generation Johannes Berg
2026-09-24 12:35 ` [PATCH 4/4] um: ORC unwinder support Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924124819.13740Cdf-hca@linux.ibm.com \
    --to=hca@linux.ibm.com \
    --cc=chenhuacai@kernel.org \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=loongarch@lists.linux.dev \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®