From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f35.google.com (mail-wr2-f35.google.com [74.125.225.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 839C6386453 for ; Thu, 24 Sep 2026 14:03:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790258587; cv=none; b=ii2ztyQ8SvT0ydFukzHO4zGmud5SfQPkn+1XqJgC0U+M8YPqzQmuurhPPg1W0bFeH55PhRptydzGfAteABhQbeFRjpfZjpzcIa23ovo+bsFEGCyxScu7ZYcfDcOZeS/kM6vErtrtbIXGE56NkJHXQEkVawA9l2JGv0USscYa4Ls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790258587; c=relaxed/simple; bh=vgPaatv/nuuMB3kArXx0HJa/hPvxZmi/7qbO2VHTEFQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Kbq9aNYbPSyW8LMrVbquXn8/xtKox2Dt+kLGGnB86rdPStf1omZVDcUuaZVddsuPsOgHut4aSUCOHjUY8FIrEoPjdZApmeLJ0bKlKqCtCfdJP+eayw2CAarWcTRp0BBBNH6hQscBJHvB+iPaTQhlARwZnwalZEmRHymI5xUR4Ws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gs3elWvW; arc=none smtp.client-ip=74.125.225.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gs3elWvW" Received: by mail-wr2-f35.google.com with SMTP id ffacd0b85a97d-4887635e952so179184f8f.1 for ; Thu, 24 Sep 2026 07:03:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790258585; x=1790863385; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=esKDI064jHsR20UuoDXImNuPdjmJM/k8p4cbmXH1qsk=; b=Gs3elWvWKeRY0J20jtnX6+M3qmB7nrZ4L+y3R3RS5wU1TlH0JuMe/HeYnT0Co60uId Qn0durQopaYBC9mBGoP9CZQuAoFZzJbV/Jmw5CnBWbD7RqRL4iKgtjQTw6k/6I0yJ63D tobNWffexYOrQYfaVxhOEE+8lQNcbRvohb9VHxsHVCfRive+RSOsKwvx1NeVone8U/Sl V21W5V9y3vm3WRkcCuB4gQc+p4QgsZK7P8z2iHSc6iMPL9PmoijeDEDEZiEVzRQgd/HK cmAWr0l6F5ZC+axDkyw8Rpd2as/yMUVEuK/3DwAaVT/+dmk1o/NGvSIjRmnZZCFGBydZ lihQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790258585; x=1790863385; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=esKDI064jHsR20UuoDXImNuPdjmJM/k8p4cbmXH1qsk=; b=VEPbChbg0b5ua3xJhBeaO/6kgwC7L22EX6m4yAPQrDUx9udjhYv8dMXGKcIsoH/MEZ dsgH2BlUA0yzjKahhCgqp9BU27OhXL+DM/trMDEJjgyjN4QsNWQ/gs+G4uVsAra8ApNl nX2cgs3IySiCC2oPGFqWr3ArWV5wNDoualfQOnKcnRwj8cvoYz5eIbNL6G4qOxHxZdzy NZse+YI4a+B7ThcVcjaAIY0+sYh3WzrVuEnVK5YZyBUa1pAeF1uYOXuStQiaEX05E+Fs mvmvownT83MZZIF+lfrmB3ljoikycQ/A4QTKC0hWUtnjp1Iaqcef7WknRE5JGhkedI7b KY6g== X-Forwarded-Encrypted: i=1; AKwUvBx3A333xJECTup1zBydewX1T13bn2jeOPIf+BpJm9y/ayUem2v0t+p9IpTmtyWHziAfK3bacrUgWxbYNh4=@vger.kernel.org X-Gm-Message-State: AFuF++lfzMvSGOFUhY8OWjRR4P+at8HxFv149jqqktpilauhb0c4ixbL 19Qc72R4e1bc7YJrF4eaOwBsdT+M0xemlJB1tRlTrjoQUylz7cArBgYo X-Gm-Gg: AYBFou0PWsLXfbwS8taHfWRmkNI9JwCxpAChVzlqUb5Iutl0I5GR1t81PLo/6Q8OuYM FHmWRZn8LAglQgnq0ifLU09YPo+hLZ6XQ3TI42XUrvo0s20l3mYKAuq6P6u7x4nmgURyKp4y7P9 moASUjgwJc6lZZEFO8yjyIeZoLAbcJkIHa8BtE+OwhBFMZt8CQRU50ytrSSHfaKAIVZBHIXMwZ9 ovz/mSbVXUBo0P52NXOPUQJx/YlOg3e/mCICGGyymuOyKbgMYKdYDs/COTUqOfZQgF9M54GyWuN MWn/eFlzRG8mD42l316K1u/2nrHohVu/tlDdl3U/Xr6XDMszuAI5CPBA/QDRXLNbyyPC30hoyu/ VKIGPDD5gazmLGjDs7OBwkxFxdN+3CsXHNm4QzuwQBT8Zhyj//oAX/7VvTrFeC9v7smpMlzajJ5 pHa1kwYNKejf4ApfGNrO9nWUWyfdo/Eo/y77Lg55iqkxzhAQJvCfZBS+MCR7qiD/Jp3ZmmlGNvM 6IjzNbSjVlcWwaf6sTD4yH97UfkV8bdGsQ/u1JCoALNQEIs35WbbsMLJ/0mIJvz92jpY8COaOsn dA== X-Received: by 2002:a05:6000:26d3:b0:486:fed6:d7e with SMTP id ffacd0b85a97d-488716d3d3fmr4957139f8f.22.1790258584350; Thu, 24 Sep 2026 07:03:04 -0700 (PDT) Received: from localhost.localdomain (host86-148-231-190.range86-148.btcentralplus.com. [86.148.231.190]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4886877a247sm15542626f8f.28.2026.09.24.07.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 07:03:00 -0700 (PDT) From: Areeb Ul Haq Mirza To: Robert Jarzmik , Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Areeb Ul Haq Mirza Subject: [PATCH] gpio: pxa: stop reading gpio_chip::base in direction callbacks Date: Thu, 24 Sep 2026 15:02:42 +0100 Message-ID: <20260924140242.126159-1-auhmirza02@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __gpio_is_inverted() identifies GPIO86-89 on PXA26x by comparing its argument against hardware line numbers, and its other callers pass the hardware index from irqd_to_hwirq(). The direction_input() and direction_output() callbacks instead pass chip->base + offset. Pass the offset directly, which is the same conversion that commit 566e684e70cb ("gpio: pxa: use new pinctrl GPIO helpers") made for the pinctrl calls in these functions. No functional change: the driver never sets chip->base, which stays zero because struct pxa_gpio_chip is allocated with devm_kzalloc(). This removes a dependency on gpio_chip::base, as tracked in drivers/gpio/TODO. Signed-off-by: Areeb Ul Haq Mirza --- Compile-tested only (arm64, COMPILE_TEST, W=1 and sparse clean). drivers/gpio/gpio-pxa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index 2b5da973f51f..3ff21e899278 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/drivers/gpio/gpio-pxa.c @@ -268,7 +268,7 @@ static int pxa_gpio_direction_input(struct gpio_chip *chip, unsigned offset) spin_lock_irqsave(&gpio_lock, flags); value = readl_relaxed(base + GPDR_OFFSET); - if (__gpio_is_inverted(chip->base + offset)) + if (__gpio_is_inverted(offset)) value |= mask; else value &= ~mask; @@ -297,7 +297,7 @@ static int pxa_gpio_direction_output(struct gpio_chip *chip, spin_lock_irqsave(&gpio_lock, flags); tmp = readl_relaxed(base + GPDR_OFFSET); - if (__gpio_is_inverted(chip->base + offset)) + if (__gpio_is_inverted(offset)) tmp &= ~mask; else tmp |= mask; base-commit: cee9395acd8043be0644b25c34bfa86623f2b935 -- 2.43.0