From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B6EA94A207D for ; Thu, 24 Sep 2026 15:25:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790263548; cv=none; b=E7lHGwDa9DIyezC1RTn3daMNPp6sY+LyK56eHdo46Ea0+EBzjzA9/5BvTgZkWNIHoXR8XLhUx61OjRf46eeMZ4nBNnyb//V+pPRu2Jo80baEztJZtSLH0SLhFLFMM8KoK7WWmCWcsgRySnTHW5IE/5v1QRcBOzaADEddMbL1t1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790263548; c=relaxed/simple; bh=Hvp6b+Atb+Avq4qy65XbI5BgoGiA0NTrVIhHxTRDZy0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t/GclAODxXNeL49DHWsAeHTCREuQytsQ7trKhkhxobULEy6yhxP0idPxJKdJ3gK8v6si3OG/YmUOOIeqHL/hnz6MEb5IuvHghIOe3dINM0JnhQvaNcTT0DfVNiwfFZ1t16juPiAZQre3aML6gIWZp6JgKTIb5g7uAa/QYm12G3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=EloduLO9; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="EloduLO9" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 810E41476; Thu, 24 Sep 2026 08:25:42 -0700 (PDT) Received: from localhost (unknown [10.2.196.114]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9218F3F86F; Thu, 24 Sep 2026 08:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1790263546; bh=Hvp6b+Atb+Avq4qy65XbI5BgoGiA0NTrVIhHxTRDZy0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EloduLO9QF/ahawLBjI2c5MW1xgxdY2f1q0LbzmcqYyWa9Mm8gcVYgoxsqUcT7BOc qfQ+b4pyIR4maHEsUYaJ/GTP9e5q+vZGUi1DJkByWh24RNUvuGvBaSeD0QBtUez+OZ IeOnVnbVHT7xmmU2V3qvHxI1TNKtRLAMam6qTlxw= Date: Thu, 24 Sep 2026 16:25:43 +0100 From: Leo Yan To: Yeoreum Yun Cc: Mike Leach , James Clark , Greg Kroah-Hartman , Mathieu Poirier , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Suzuki K Poulose , Alexander Shishkin , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt Subject: Re: [PATCH v11 0/9] fix several inconsistencies with sysfs configuration in etmX Message-ID: <20260924152543.GL200420@e132581.arm.com> References: <20260915-separate_etm_cfg_v2-v11-0-d2b258d51747@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260915-separate_etm_cfg_v2-v11-0-d2b258d51747@arm.com> On Tue, Sep 15, 2026 at 12:34:35PM +0100, Yeoreum Yun wrote: > To resolve these inconsistencies, the configuration should be separated into: > > - active_config, which is applied configuration for the current session > - config, which stores the settings configured via sysfs. > > and apply configuration from configfs after taking a mode. I did the following tests on this series: 1) Perf test on Orion6 board: # ./perf test coresight 142: CoreSight synthesized callchain : Ok 143: CoreSight concurrent threads : Ok 144: CoreSight context switch thread attribution : Ok 145: CoreSight deterministic workload decode : Ok 146: CoreSight raw dump stress : Ok 147: Check Arm CoreSight trace data recording and synthesized samples : FAILED! 148: Check Arm CoreSight disassembly script completes without errors : Ok Test 147 has a known issue with per-thread mode. The failure was already observed before this series. 2) Strobe mode test: # echo 5000 > /sys/kernel/config/cs-syscfg/features/strobing/params/window/value # echo 0 > /sys/kernel/config/cs-syscfg/features/strobing/params/period/value # perf record -e cs_etm/autofdo,timestamp=0/u -m,128M -- perf test -w brstack 3000000 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 36.301 MB perf.data ] # echo 1 > /sys/kernel/config/cs-syscfg/features/strobing/params/period/value # perf record -e cs_etm/autofdo,timestamp=0/u -m,128M -- perf test -w brstack 3000000 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 18.361 MB perf.data ] # echo 2 > /sys/kernel/config/cs-syscfg/features/strobing/params/period/value # perf record -e cs_etm/autofdo,timestamp=0/u -m,128M -- perf test -w brstack 3000000 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 12.246 MB perf.data ] # echo 3 > /sys/kernel/config/cs-syscfg/features/strobing/params/period/value # perf record -e cs_etm/autofdo,timestamp=0/u -m,128M -- perf test -w brstack 3000000 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 9.197 MB perf.data ] The captured trace sizes maintain the expected proportional relationship with the period values. 3) I verified the series on Juno-r2 baord with insmod and rmmod, and CPU PM, and did not see any regression. Maybe it'd be good to send a new version addressing Mike's comments. Based on the test results, you can add my test tags: Tested-by: Leo Yan