From: Andre Przywara <andre.przywara@arm.com>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
Ben Horgan <ben.horgan@arm.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Fenghua Yu <fenghuay@nvidia.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Srivathsa L Rao <srivathsa.rao@oss.qualcomm.com>,
Ganapatrao Kulkarni <ganapatrao.kulkarni@oss.qualcomm.com>,
Trilok Soni <tsoni@quicinc.com>,
Srinivas Ramana <sramana@qti.qualcomm.com>,
Niyas Sait <niyas.sait@arm.com>, Lee Trager <lee@trager.us>,
Ritwick Sharma <ritwick.sharma@arm.com>,
Gavin Shan <gshan@redhat.com>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v11 09/13] arm_mpam: propagate MSC access errors in mpam_reset_class_locked()
Date: Thu, 24 Sep 2026 17:27:35 +0200 [thread overview]
Message-ID: <20260924152739.2865510-10-andre.przywara@arm.com> (raw)
In-Reply-To: <20260924152739.2865510-1-andre.przywara@arm.com>
The mpam_reset_ris() function can return an error, propagate this up
through mpam_reset_component_locked() to mpam_reset_class_locked(),
which is exported. The external caller is a void function, so cannot
really handle the error at the moment, but at least we report everything
on the MPAM interface side.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
drivers/resctrl/mpam_devices.c | 24 ++++++++++++++++++------
drivers/resctrl/mpam_internal.h | 2 +-
2 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c
index eb26c25b9f970..6d1fda949a05c 100644
--- a/drivers/resctrl/mpam_devices.c
+++ b/drivers/resctrl/mpam_devices.c
@@ -2994,7 +2994,7 @@ static void mpam_enable_once(void)
mpam_partid_max + 1, mpam_pmg_max + 1);
}
-static void mpam_reset_component_locked(struct mpam_component *comp)
+static int mpam_reset_component_locked(struct mpam_component *comp)
{
struct mpam_vmsc *vmsc;
@@ -3008,26 +3008,38 @@ static void mpam_reset_component_locked(struct mpam_component *comp)
srcu_read_lock_held(&mpam_srcu)) {
struct mpam_msc *msc = vmsc->msc;
struct mpam_msc_ris *ris;
+ int ret;
list_for_each_entry_srcu(ris, &vmsc->ris, vmsc_list,
srcu_read_lock_held(&mpam_srcu)) {
- if (!ris->in_reset_state)
- mpam_touch_msc(msc, mpam_reset_ris, ris);
+ if (!ris->in_reset_state) {
+ ret = mpam_touch_msc(msc, mpam_reset_ris, ris);
+ if (ret)
+ return ret;
+ }
ris->in_reset_state = true;
}
}
+
+ return 0;
}
-void mpam_reset_class_locked(struct mpam_class *class)
+int mpam_reset_class_locked(struct mpam_class *class)
{
struct mpam_component *comp;
+ int ret;
lockdep_assert_cpus_held();
guard(srcu)(&mpam_srcu);
list_for_each_entry_srcu(comp, &class->components, class_list,
- srcu_read_lock_held(&mpam_srcu))
- mpam_reset_component_locked(comp);
+ srcu_read_lock_held(&mpam_srcu)) {
+ ret = mpam_reset_component_locked(comp);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
}
static void mpam_reset_class(struct mpam_class *class)
diff --git a/drivers/resctrl/mpam_internal.h b/drivers/resctrl/mpam_internal.h
index 68a6cf2b9cc73..09f8168fb4d2c 100644
--- a/drivers/resctrl/mpam_internal.h
+++ b/drivers/resctrl/mpam_internal.h
@@ -465,7 +465,7 @@ void mpam_enable(struct work_struct *work);
void mpam_disable(struct work_struct *work);
/* Reset all the RIS in a class under cpus_read_lock() */
-void mpam_reset_class_locked(struct mpam_class *class);
+int mpam_reset_class_locked(struct mpam_class *class);
int mpam_apply_config(struct mpam_component *comp, u16 partid,
struct mpam_config *cfg);
--
2.43.0
next prev parent reply other threads:[~2026-09-24 15:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 15:27 [PATCH v11 00/13] arm_mpam: Add MPAM-Fb firmware support Andre Przywara
2026-09-24 15:27 ` [PATCH v11 01/13] arm_mpam: let low level MSC accessors return an error Andre Przywara
2026-09-24 15:27 ` [PATCH v11 02/13] arm_mpam: propagate MSC access errors for hw_probe functions Andre Przywara
2026-09-24 15:27 ` [PATCH v11 03/13] arm_mpam: propagate MSC access errors for MBWU counters Andre Przywara
2026-09-24 15:27 ` [PATCH v11 04/13] arm_mpam: propagate MSC access errors for msmon helpers Andre Przywara
2026-09-24 15:27 ` [PATCH v11 05/13] arm_mpam: propagate MSC access errors for __ris_msmon_read() Andre Przywara
2026-09-24 15:27 ` [PATCH v11 06/13] arm_mpam: propagate MSC access errors for state saving function Andre Przywara
2026-09-24 15:27 ` [PATCH v11 07/13] arm_mpam: propagate MSC access errors for mpam_reprogram_ris_partid() Andre Przywara
2026-09-24 15:27 ` [PATCH v11 08/13] arm_mpam: propagate MSC access errors for interrupt control Andre Przywara
2026-09-24 22:20 ` Jonathan Cameron
2026-09-24 15:27 ` Andre Przywara [this message]
2026-09-24 22:21 ` [PATCH v11 09/13] arm_mpam: propagate MSC access errors in mpam_reset_class_locked() Jonathan Cameron
2026-09-24 15:27 ` [PATCH v11 10/13] arm_mpam: prepare mon_sel locking for MPAM-Fb Andre Przywara
2026-09-24 15:27 ` [PATCH v11 11/13] arm_mpam: add MPAM-Fb MSC firmware access support Andre Przywara
2026-09-24 15:27 ` [PATCH v11 12/13] arm_mpam: change MPAM-Fb error IRQ to use a threaded IRQ handler Andre Przywara
2026-09-24 22:36 ` Jonathan Cameron
2026-09-24 15:27 ` [PATCH v11 13/13] arm_mpam: detect and enable MPAM-Fb PCC support Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924152739.2865510-10-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=ben.horgan@arm.com \
--cc=catalin.marinas@arm.com \
--cc=fenghuay@nvidia.com \
--cc=ganapatrao.kulkarni@oss.qualcomm.com \
--cc=gshan@redhat.com \
--cc=guohanjun@huawei.com \
--cc=james.morse@arm.com \
--cc=jic23@kernel.org \
--cc=lee@trager.us \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=niyas.sait@arm.com \
--cc=rafael@kernel.org \
--cc=reinette.chatre@intel.com \
--cc=ritwick.sharma@arm.com \
--cc=sramana@qti.qualcomm.com \
--cc=srivathsa.rao@oss.qualcomm.com \
--cc=sudeep.holla@kernel.org \
--cc=tsoni@quicinc.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®