From: Ruslan Koreev <koreev.r@gmail.com>
To: lee@kernel.org, pavel@kernel.org, rillian.grant@gmail.com
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Ruslan Koreev <koreev.r@gmail.com>
Subject: [PATCH 0/2] leds: flash: lm3643: standby fix and ACPI LED description
Date: Thu, 24 Sep 2026 20:20:38 +0300 [thread overview]
Message-ID: <20260924172040.1185688-1-koreev.r@gmail.com> (raw)
In-Reply-To: <20260821083620.68324-1-rillian.grant@gmail.com>
These apply on top of Rillian Grant's "[RFC PATCH 0/2] leds: flash:
LM3643 dual LED flash driver" and answer two things from that thread.
Patch 1 addresses the two state-machine problems flagged by the Sashiko
review of the RFC, which Lee Jones asked to have addressed: switching
the last active output off left the chip in torch or flash mode instead
of standby.
Patch 2 addresses the question in the RFC cover letter about supplying
a default configuration on ACPI machines, where the chip is enumerated
as TXNW3643 without LED child nodes: it adds a DMI table describing the
LED as a software node, starting with the Lenovo ThinkPad X1 Carbon
Gen 14, where the LM3643 drives the Windows Hello IR flood illuminator
with both current sources feeding one LED. The limits are 100 mA torch
and 300 mA flash per output, well below the chip's maximums.
Tested on that laptop with Fedora 44 (kernel 7.2.5): the LED appears as
ir:flash, torch mode lights the ST VD55G1 IR camera's field of view and
the chip returns to standby when the torch is switched off, and face
authentication with howdy works on those frames.
Rillian, if you prefer to fold these into a v2 of your series, please
do; a DMI entry for the X9-15 Gen 1 only needs its product version
string.
Ruslan Koreev (2):
leds: flash: lm3643: Return to standby when the last output is
switched off
leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes
drivers/leds/flash/leds-lm3643.c | 115 +++++++++++++++++++++++++++++--
1 file changed, 109 insertions(+), 6 deletions(-)
--
2.55.0
next prev parent reply other threads:[~2026-09-24 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260821083620.68324-1-rillian.grant@gmail.com>
2026-08-21 8:36 ` [RFC PATCH 1/2] dt-bindings: leds: Document TI LM3643 dual LED flash driver Rillian Grant
2026-08-21 8:36 ` [RFC PATCH 2/2] leds: flash: Add support for the " Rillian Grant
2026-09-24 17:20 ` Ruslan Koreev [this message]
2026-09-24 17:20 ` [PATCH 1/2] leds: flash: lm3643: Return to standby when the last output is switched off Ruslan Koreev
2026-09-24 17:20 ` [PATCH 2/2] leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes Ruslan Koreev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924172040.1185688-1-koreev.r@gmail.com \
--to=koreev.r@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=rillian.grant@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®