From: "Cen Zhang (Microsoft Security FORGE Labs)" <cenzhang@linux.microsoft.com>
To: omar@blockcast.net
Cc: AutonomousCodeSecurity@microsoft.com, andrew+netdev@lunn.ch,
ap420073@gmail.com, cenzhang@linux.microsoft.com,
davem@davemloft.net, edumazet@google.com, horms@kernel.org,
kuba@kernel.org, kys@microsoft.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com,
tgopinath@linux.microsoft.com, xmei5@asu.edu
Subject: Re: [PATCH net v2] amt: do not store tunnel pointer in skb control block
Date: Thu, 24 Sep 2026 15:08:29 -0400 [thread overview]
Message-ID: <20260924190829.34651-1-cenzhang@linux.microsoft.com> (raw)
In-Reply-To: <20260923225630.95537-2-omar@blockcast.net>
Hi Omar,
On Thu, Sep 24, 2026 at 01:56:31AM +0300, Omar Ramadan wrote:
> Agreed on the refcount. Could we avoid both the refcount and the
> lookup by not sending the relay's GQ through amt_dev_xmit() at all?
Thanks for the exploration and the thoughtful solution. I did not
consider removing the round trip in the first place, since that
looked like a user-visible behaviour change, but your write-up
covers it well.
> I haven't reproduced the KASAN report. Could you share the netem
> setup you used, so I can run it before and after?
I will send you and Taehee the reproducer artifact in private soon.
It covers the base, base + your diff and base + v2.
> If you and Taehee like this direction, either of these works for me:
> - I post it as v3 with your KASAN trace in the commit message,
> keeping the existing Reported-by tags (you're already one), plus
> Co-developed-by if you'd like; that needs your Signed-off-by.
If Taehee is fine with it, let's go with your v3. I am fine with the
credit as long as the CVE credits the report to Xiang and I (so for
my institution).
Thanks,
Cen
next prev parent reply other threads:[~2026-09-24 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 21:41 Cen Zhang (Microsoft Security FORGE Labs)
2026-09-23 22:56 ` Omar Ramadan
2026-09-24 19:08 ` Cen Zhang (Microsoft Security FORGE Labs) [this message]
2026-09-26 0:47 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924190829.34651-1-cenzhang@linux.microsoft.com \
--to=cenzhang@linux.microsoft.com \
--cc=AutonomousCodeSecurity@microsoft.com \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=omar@blockcast.net \
--cc=pabeni@redhat.com \
--cc=tgopinath@linux.microsoft.com \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®