From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23BAB46D0BD; Fri, 25 Sep 2026 19:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790363720; cv=none; b=QzMV0JCFLVNA47E4EAWYjXdVzCqVL8ufgmKDabSRwyKxcSQZYiAtdfmBBVh3SeoX4anlFda2iMzSSD5rkF+8SE1QtEvfqojlQWNS8sDWN53XpVVcLdJbt9SeMd/NV2UgigsFXIfD5qYSnHn1pSICva5o6J00ate7YR4SkmK9b30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790363720; c=relaxed/simple; bh=02i0M9cQVcI4OzfL9ZRzbIOSN6ZwbmiBZLNmG6nxo3Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Mw0DlEPlrdzZhOPo0Ypdv5jnlXqA3+SX9LbOq8cTCyVH5da8AftcKDyHiRolqjPVoQvWB6wdghpBNXn3duJuSZfNDpje4rkYQEHLpCKVtAY3j1RhzotUfnB3yZUwefnfzbd0m0Mf20m/UFkd5DtIJ1ixz3x4IRORN94zQ8wH9vs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fapHcvZU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fapHcvZU" Received: by smtp.kernel.org (Postfix) with ESMTPS id 28C7AC2BCF4; Fri, 25 Sep 2026 19:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1790363718; bh=02i0M9cQVcI4OzfL9ZRzbIOSN6ZwbmiBZLNmG6nxo3Y=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=fapHcvZUicmb73uuObKaBee8PFtqzHeBCLr+6algNLdknYl6xZJjq2KZ7eX8PwIPg N4KZDMOR++vDIzLYhP97U50ggUnu++OsYvE4ZEGu+6E6vC7ziNAmxjuWYjBZ3PSf7M CLT1dDlGfQGbRQuwDutYocTcbnAoockgwojU4EwyJ3WJaeN6kL++bAwBzuSNXENjWj GQTs5TvXX1S8QTT4XVHTsadgtSJQsD7594wNqaVK8VodDcdrNZTRYNJvj4AeL9hr3K bs770559IOODakdlC6yXVaBN9c7DjK5wPs55mFhvi9b09Xlo2pNU6BZSYttQRu2xM5 YwSm7/TJNC+mQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19C4C98328; Fri, 25 Sep 2026 19:15:17 +0000 (UTC) From: Alireza Haghdoost via B4 Relay Date: Fri, 25 Sep 2026 12:09:38 -0700 Subject: [PATCH v3 1/6] perf symbols: Fix broken ELF_C_READ_MMAP fallback guard Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260925-perf-symbol-memory-send-v3-1-3e4e234c363b@uber.com> References: <20260925-perf-symbol-memory-send-v3-0-3e4e234c363b@uber.com> In-Reply-To: <20260925-perf-symbol-memory-send-v3-0-3e4e234c363b@uber.com> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Alexei Starovoitov , Andrii Nakryiko Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Alireza Haghdoost X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1501; i=haghdoost@uber.com; h=from:subject:message-id; bh=Fie+m8uDrnEku3C9hTHPEiLsQANbwK1zFduANx60M6s=; b=owEBiQJ2/ZANAwAIAVNlBDxl2ALYAcsmYgBqtshCpzsrTy68JCej2jYNxVbsTcbi9zZ25Pb6+ hUmrGve/3CJAk8EAAEIADkWIQS5+sFL3gX/8PrA0S1TZQQ8ZdgC2AUCarbIQhsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwwLDMACgkQU2UEPGXYAthXcxAAkX0bsj8EiGS+gGJ/fOI1ADGjhU7dwcE ITVR2blrWPqv2/wipl49gq6ThcRqIKHHjUylBNmAiPx+fOpZU9dZYYxPpc9Jo/5eY0qZ4oTwg6C zp+7Vdenb5HsCSMLcWtHBUtidU+36fgai34dEg9WTXW6RkXDbwc1vjHrBu44sAy6KQVP0w6yaai N1yl+4Mq3N6YGOby6ZMCOriDasBMeJQBv7eKyeKxV+EtGoGLgrad2SOh46BCEpfUobuHFku4FXC 82ZSh9mZrTNsLuUuckCu3hl9C05a2rLcsY4SzUzgM//kv54IQHGvC1+/2re2Qe6aUtjIo9S3Y9U BaxfBJNMPj3m4CpDt2bCH1Jwpmat5LdRb3sjtPY/R+qOiMXH9HnoGgmjMINJ5kV6+CNY/IEKriL Bz6mAwNQ+gHsFB5n8jf9dyQxA+esJzAZ2f4rN3Ku+eT5cxG9M6EeWy0fuAzqF2J//j67NSXoW0u sDZaOauaCyuryPYzKUdQ7j9y6u+Gq2RHZoLteiBxgVipDBK2eyk8W3Pwkxh5ymFgnLuQBo4WnkC ANIr76Irv0yuKsmnbJUmo5rDFj4ns/ZkL8FiLlQZriXRoRtarg2T4PogO7TIMLqxrD9fTcYeTDQ nYsbhvfg8LV/ekki7nTXxiPT9QpEoqvxy0mr6fdYc0rTnyAz3jEI= X-Developer-Key: i=haghdoost@uber.com; a=openpgp; fpr=B9FAC14BDE05FFF0FAC0D12D5365043C65D802D8 X-Endpoint-Received: by B4 Relay for haghdoost@uber.com/default with auth_id=764 X-Original-From: Alireza Haghdoost Reply-To: haghdoost@uber.com From: Alireza Haghdoost Commit 22dd1ac91a77 ("tools: Remove feature-libelf-mmap feature detection") replaced perf's compile-time feature test with an #ifdef on ELF_C_READ_MMAP. ELF_C_READ_MMAP is an Elf_Cmd enumerator rather than a preprocessor macro, so the condition is always false and perf silently uses ELF_C_READ. Perf already requires a sufficiently recent elfutils version that provides ELF_C_READ_MMAP. Use the enumerator directly instead of restoring a feature probe or retaining an unreachable fallback. Fixes: 22dd1ac91a77 ("tools: Remove feature-libelf-mmap feature detection") Signed-off-by: Alireza Haghdoost Reviewed-by: Namhyung Kim --- tools/perf/util/symbol.h | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index d0bac824c79c..46b1649c64fc 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h @@ -57,15 +57,7 @@ static inline bool is_livepatch_symbol(const char *str) return strstarts(str, KLP_SYM_PREFIX); } -/* - * libelf 0.8.x and earlier do not support ELF_C_READ_MMAP; - * for newer versions we can use mmap to reduce memory usage: - */ -#ifdef ELF_C_READ_MMAP -# define PERF_ELF_C_READ_MMAP ELF_C_READ_MMAP -#else -# define PERF_ELF_C_READ_MMAP ELF_C_READ -#endif +#define PERF_ELF_C_READ_MMAP ELF_C_READ_MMAP #ifdef HAVE_LIBELF_SUPPORT Elf_Scn *elf_section_by_name(Elf *elf, GElf_Ehdr *ep, -- Git-157)