From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Pengpeng Hou <hppiscas@163.com>,
nuno.sa@analog.com, michael.hennerich@analog.com,
dlechner@baylibre.com, andy@kernel.org, linux@analog.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: cdc: ad7150: fix OF matching and publish module aliases
Date: Fri, 25 Sep 2026 02:50:22 +0100 [thread overview]
Message-ID: <20260925025022.23fcca59@jic23-hlaptop> (raw)
In-Reply-To: <arJX66ZmCWbZ_4RV@ashevche-desk.local>
On Tue, 22 Sep 2026 13:26:51 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Sun, Sep 20, 2026 at 11:33:03AM +0800, Pengpeng Hou wrote:
> > The OF match entries use positional initializers, which initialize the
> > name field rather than compatible. Consequently the advertised AD7150,
> > AD7151 and AD7156 compatible strings do not describe OF compatible
> > matches. The table is also not exported for module alias generation.
> >
> > Use designated compatible initializers and publish the OF table. Keep
> > the existing I2C ID table and its device-variant selection unchanged.
> >
> > The issue was found by our static-analysis tool.
> >
> > Fixes: 89f2d5b080bc ("staging:iio:cdc:ad7150: Add of_match_table")
> > Assisted-by: gpt 5
>
> Assisted-by: LLM
>
> > Signed-off-by: Pengpeng Hou <hppiscas@163.com>
>
> Same to other patches with similar tag.
>
> ...
>
> TBH, except the commit message I can't see how LLM could be helpful to the
> code. It's quite a simple change...
>
Applied with the Assisted by tweaked.
Thanks,
Jonathan
prev parent reply other threads:[~2026-09-25 1:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 3:33 Pengpeng Hou
2026-09-22 10:26 ` Andy Shevchenko
2026-09-25 1:50 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925025022.23fcca59@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=hppiscas@163.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®