mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Pengpeng Hou <hppiscas@163.com>
Cc: petre.rodan@subdimension.ro, dlechner@baylibre.com,
	nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, tiberiu.a.breana@intel.com,
	andriy.shevchenko@intel.com
Subject: Re: [PATCH v2] iio: accel: bma220: publish the SPI driver ACPI alias
Date: Fri, 25 Sep 2026 02:51:54 +0100	[thread overview]
Message-ID: <20260925025154.3a477b43@jic23-hlaptop> (raw)
In-Reply-To: <20260920033358.12345-1-hppiscas@163.com>

On Sun, 20 Sep 2026 11:33:58 +0800
Pengpeng Hou <hppiscas@163.com> wrote:

> The SPI driver advertises an ACPI match for BMA0220 but does not export
> that table. A modular build therefore lacks the ACPI alias used to load
> the driver when the device is enumerated through ACPI.
> 
> Export the ACPI table. Move the existing SPI export next to its SPI ID
> table so each export is adjacent to the table it describes.
> 
> The issue was found by our static-analysis tool.
> 
> Fixes: bf2a5600a3eb ("iio: accel: Add support for Bosch BMA220")
> Assisted-by: gpt 5
Updated to LLM and patch applied.

> Signed-off-by: Pengpeng Hou <hppiscas@163.com>
> ---
> Changes since v1:
> https://lore.kernel.org/all/20260905133901.66016-1-hppiscas@163.com/
> Place the SPI export immediately after the SPI table as Jonathan and
> Andy requested; use the full author name.
> 
>  drivers/iio/accel/bma220_spi.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/bma220_spi.c b/drivers/iio/accel/bma220_spi.c
> index d6c1087cc3c0..d7a95289df48 100644
> --- a/drivers/iio/accel/bma220_spi.c
> +++ b/drivers/iio/accel/bma220_spi.c
> @@ -28,12 +28,13 @@ static const struct spi_device_id bma220_spi_id[] = {
>  	{ .name = "bma220" },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(spi, bma220_spi_id);
>  
>  static const struct acpi_device_id bma220_acpi_id[] = {
>  	{ "BMA0220", 0 },
>  	{ }
>  };
> -MODULE_DEVICE_TABLE(spi, bma220_spi_id);
> +MODULE_DEVICE_TABLE(acpi, bma220_acpi_id);
>  
>  static const struct of_device_id bma220_of_spi_match[] = {
>  	{ .compatible = "bosch,bma220" },
> 
> base-commit: 518e5b794c06c0f0eb40df3e202274a66202c137


      reply	other threads:[~2026-09-25  1:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20  3:33 Pengpeng Hou
2026-09-25  1:51 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260925025154.3a477b43@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=hppiscas@163.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=petre.rodan@subdimension.ro \
    --cc=tiberiu.a.breana@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®