From: Borislav Petkov <bp@alien8.de>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: Stefan Schaeckeler <sschaeck@cisco.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Tony Luck <tony.luck@intel.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, Borislav Petkov <bp@suse.de>,
stable@vger.kernel.org
Subject: Re: [PATCH v3 2/9] EDAC/aspeed: Set the DIMM grain
Date: Thu, 24 Sep 2026 22:45:22 -0700 [thread overview]
Message-ID: <20260925054522.GDarYKcvFR4mLdAhSe@fat_crate.local> (raw)
In-Reply-To: <20260916-edac-v3-2-23e9ed2fbdf9@aspeedtech.com>
On Wed, Sep 16, 2026 at 01:30:39PM +0800, Ryan Chen wrote:
> The driver never sets dimm->grain, leaving it zero. Since commit
> 3724ace582d9 ("EDAC/mc: Fix grain_bits calculation")
> edac_raw_mc_handle_error() runs WARN_ON_ONCE(!e->grain) and forces the
> grain to 1, so the first ECC error reported on any Aspeed BMC SoC emits a
> warning splat, e.g. on the AST2600:
>
> WARNING: CPU: 0 PID: 0 at drivers/edac/edac_mc.c:924 edac_raw_mc_handle_error+0x4b4/0x604
> ...
> edac_raw_mc_handle_error from edac_mc_handle_error+0x364/0x4a8
> edac_mc_handle_error from count_rec+0xdc/0x124
> count_rec from mcr_isr+0x110/0x1e8
All of that is fine and dandy but you should talk about why the grain is
chosen to be 16 here. The warning is just to make you choose a proper grain
for your hw and doesn't need that much 'splainin'.
> Fixes: 9b7e6242ee4e ("EDAC, aspeed: Add an Aspeed AST2500 EDAC driver")
> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> Cc: stable@vger.kernel.org
Is this really stable material and if so, why?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-09-25 5:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 5:30 [PATCH v3 0/9] Add Aspeed AST2700 SDRAM EDAC support Ryan Chen
2026-09-16 5:30 ` [PATCH v3 1/9] dt-bindings: edac: aspeed: Add AST2700 SDRAM EDAC Ryan Chen
2026-09-16 5:30 ` [PATCH v3 2/9] EDAC/aspeed: Set the DIMM grain Ryan Chen
2026-09-25 5:45 ` Borislav Petkov [this message]
2026-09-16 5:30 ` [PATCH v3 3/9] EDAC/aspeed: Free the interrupt before the mem_ctl_info on remove Ryan Chen
2026-09-16 5:30 ` [PATCH v3 4/9] EDAC/aspeed: Clean up whitespace and include ordering Ryan Chen
2026-09-16 5:30 ` [PATCH v3 5/9] EDAC/aspeed: Free the mem_ctl_info unconditionally on remove Ryan Chen
2026-09-16 5:30 ` [PATCH v3 6/9] EDAC/aspeed: Replace regmap with direct register access Ryan Chen
2026-09-16 5:30 ` [PATCH v3 7/9] EDAC/aspeed: Abstract SoC differences behind chip data Ryan Chen
2026-09-16 5:30 ` [PATCH v3 8/9] EDAC/aspeed: Add AST2700 support Ryan Chen
2026-09-16 5:30 ` [PATCH v3 9/9] MAINTAINERS: Add a reviewer for the Aspeed EDAC driver Ryan Chen
2026-09-22 2:53 ` [PATCH v3 0/9] Add Aspeed AST2700 SDRAM EDAC support Ryan Chen
2026-09-22 3:19 ` Borislav Petkov
2026-09-22 5:25 ` Ryan Chen
2026-09-25 5:44 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925054522.GDarYKcvFR4mLdAhSe@fat_crate.local \
--to=bp@alien8.de \
--cc=andrew@codeconstruct.com.au \
--cc=bp@suse.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=sschaeck@cisco.com \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®