From: Christoph Hellwig <hch@lst.de>
To: Runyu Xiao <runyu.xiao@seu.edu.cn>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Andreas Hindborg <a.hindborg@kernel.org>,
Breno Leitao <leitao@debian.org>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Jianhao Xu <jianhao.xu@seu.edu.cn>
Subject: Re: [PATCH v4 1/3] fs: configfs: add helpers for opening non-configfs paths
Date: Fri, 25 Sep 2026 08:40:38 +0200 [thread overview]
Message-ID: <20260925064038.GA4025@lst.de> (raw)
In-Reply-To: <20260923023923.2002144-1-runyu.xiao@seu.edu.cn>
On Wed, Sep 23, 2026 at 10:39:23AM +0800, Runyu Xiao wrote:
> > > +EXPORT_SYMBOL_GPL(configfs_open_root);
> >
> > These two aren't used outside this file, so they could be static,
> > or in case of configfs_path_is_configfs even be folded into the
> > only caller. Or do you plan to have other users?
>
> I folded the filesystem-type check into configfs_open_root() and dropped
> the predicate entirely. configfs_file_open() is for callers that have a
> pathname, while configfs_open_root() is for callers that keep a resolved
> root and open files below it.
Which callers are those? There are none in this series, so right now
this is just adding dead code. If you have other callers, please send
everything in one series, as it needs to go together.
>
> > > +struct file *configfs_file_open(const char *filename, int flags, umode_t mode)
> >
> > Can you add a kerneldoc comment explaining how/why this should be used?
>
> I will add kerneldoc comments for both helpers in v5.
The versions added look like extremely verbose AI generated text.
Please use your own brains and your own voice to write a concise
description.
>
> > Didn't you also have patches for drivers/target/ that should use
> > the new helper?
>
> Yes. The target-core patch titled "scsi: target: pin db_root for metadata
> writes" is another consumer of configfs_open_root(). I will rebase that
> patch on this series and drop its duplicate configfs changes.
Please merge everything into one series.
next prev parent reply other threads:[~2026-09-25 6:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 9:05 [PATCH v4 0/3] nvmet: avoid recursive configfs open Runyu Xiao
2026-09-21 9:05 ` [PATCH v4 1/3] fs: configfs: add helpers for opening non-configfs paths Runyu Xiao
2026-09-22 13:29 ` Christoph Hellwig
2026-09-23 2:39 ` Runyu Xiao
2026-09-25 6:40 ` Christoph Hellwig [this message]
2026-09-21 9:05 ` [PATCH v4 2/3] nvmet: avoid recursive configfs open for file-backed namespaces Runyu Xiao
2026-09-22 13:29 ` Christoph Hellwig
2026-09-21 9:05 ` [PATCH v4 3/3] nvmet: avoid recursive configfs open for passthru Runyu Xiao
2026-09-22 13:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925064038.GA4025@lst.de \
--to=hch@lst.de \
--cc=a.hindborg@kernel.org \
--cc=jianhao.xu@seu.edu.cn \
--cc=kch@nvidia.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=runyu.xiao@seu.edu.cn \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®