From: Lian Wang <lianux.mm@gmail.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Youngjun Park <her0gyugyu@gmail.com>,
Youngjun Park <youngjun.park@lge.com>,
akpm@linux-foundation.org, chrisl@kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
kasong@tencent.com, mhocko@kernel.org, roman.gushchin@linux.dev,
shakeel.butt@linux.dev, muchun.song@linux.dev,
shikemeng@huaweicloud.com, baoquan.he@linux.dev,
baohua@kernel.org, yosry@kernel.org, joshua.hahnjy@gmail.com,
taejoon.song@lge.com, lianux.mm@gmail.com
Subject: Re: [RFC PATCH v11 0/4] mm/swap: priority-based swap tiers with per-cgroup selection
Date: Fri, 25 Sep 2026 14:54:57 +0800 [thread overview]
Message-ID: <20260925065521.36340-1-lianux.mm@gmail.com> (raw)
In-Reply-To: <arQJIjzE0BlUg0CV@cmpxchg.org>
On Wed, Sep 23, 2026 at 01:15:14PM -0400, Johannes Weiner wrote:
> If you can think of a good usecase, memory.swap.prio.min would be
> certainly a natural extension. But we should get the usecase laid out.
>
> The requirement to punch holes is the one I can relate to least. Why
> would a cgroup need access to good tiers and bad tiers, but skip the
> middle ones?
>
> This would seem less like tiering/hierarchy and more like flat
> per-cgroup swap pools but with obstacles.
Hi Johannes and Youngjun,
Sorry that I am only joining this part of the discussion now.
I recently started helping carry Kairui's swap queue work forward. Our
current v2 is here [1]. Youngjun's tier work interacts directly with it:
v2 maintains a device queue and reader for each priority, while v11 makes
each priority a tier and moves device selection under that tier.
I did a functional integration test of v11 on an x86-64 host. The tier
mask, fallback, same-priority device allocation, concurrent allocation,
and swapoff smoke tests all worked without kernel warnings. This was a
zram integration test, not yet a real multi-SSD performance test.
One result seems relevant to this discussion: with a restricted parent
and an unconfigured child, the child could still use the faster tier. I
therefore agree that an inheritable memory.swap.prio.max looks like the
cleaner first cgroup interface. A hole in the mask worked mechanically,
but I do not yet have a convincing hierarchical use case for it; it felt
more like per-cgroup swap-pool membership.
For the queue integration, one possible boundary is for the tier to own
the queue/reader and for the swap queue to become the default per-tier
device allocation policy. I would like to align this with both of you
before changing v2. I will also continue the real multi-SSD tests.
If either of you has suggestions or specific test cases you would like
to see, please let me know. I have a few test setups available and should
be able to try some of them. I am still getting up to speed on this part
of MM, so please correct me if I missed some context or got any detail
wrong.
[1] https://lore.kernel.org/all/20260829-swap-pcp-priq-v2-resend-0-68d3d925578c@gmail.com/
Thanks,
Lian
prev parent reply other threads:[~2026-09-25 6:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 18:34 Youngjun Park
2026-09-16 18:34 ` [RFC PATCH v11 1/4] mm: swap: introduce swap tier infrastructure Youngjun Park
2026-09-16 18:34 ` [RFC PATCH v11 2/4] mm: swap: allocate swap slots from swap tiers Youngjun Park
2026-09-16 18:34 ` [RFC PATCH v11 3/4] mm: swap: add a debugfs interface for memcg tier selection Youngjun Park
2026-09-16 18:34 ` [RFC PATCH v11 4/4] mm: swap: filter swap allocation by memcg tier mask Youngjun Park
2026-09-16 20:04 ` [RFC PATCH v11 0/4] mm/swap: priority-based swap tiers with per-cgroup selection Johannes Weiner
2026-09-20 16:20 ` Youngjun Park
2026-09-23 17:15 ` Johannes Weiner
2026-09-25 6:54 ` Lian Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925065521.36340-1-lianux.mm@gmail.com \
--to=lianux.mm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baoquan.he@linux.dev \
--cc=cgroups@vger.kernel.org \
--cc=chrisl@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=her0gyugyu@gmail.com \
--cc=joshua.hahnjy@gmail.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=shikemeng@huaweicloud.com \
--cc=taejoon.song@lge.com \
--cc=yosry@kernel.org \
--cc=youngjun.park@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®