From: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Abel Vesa <abelvesa@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Subject: [PATCH 2/4] arm64: dts: qcom: hawi: Fix PCIe IOMMU maps
Date: Fri, 25 Sep 2026 15:43:06 +0530 [thread overview]
Message-ID: <20260925101309.3826038-2-mukesh.ojha@oss.qualcomm.com> (raw)
In-Reply-To: <20260925101309.3826038-1-mukesh.ojha@oss.qualcomm.com>
apps_smmu defines #iommu-cells = <2>, requiring five cells per
iommu-map tuple: rid-base, phandle, sid-base, sid-mask, and length.
The pcie0 and pcie1 nodes specify only four cells and were omitting
the mask field.
Add the missing 0x0 mask cell to both tuples in each PCIe node.
Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/hawi.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/hawi.dtsi b/arch/arm64/boot/dts/qcom/hawi.dtsi
index c7ae8133b9cd..89bf0f59304d 100644
--- a/arch/arm64/boot/dts/qcom/hawi.dtsi
+++ b/arch/arm64/boot/dts/qcom/hawi.dtsi
@@ -2958,8 +2958,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
operating-points-v2 = <&pcie0_opp_table>;
- iommu-map = <0 &apps_smmu 0x1000 0x1>,
- <0x100 &apps_smmu 0x1001 0x1>;
+ iommu-map = <0 &apps_smmu 0x1000 0x0 0x1>,
+ <0x100 &apps_smmu 0x1001 0x0 0x1>;
interrupt-map = <0 0 0 1 &intc 0 0 GIC_ESPI 213 IRQ_TYPE_LEVEL_HIGH>,
<0 0 0 2 &intc 0 0 GIC_ESPI 214 IRQ_TYPE_LEVEL_HIGH>,
@@ -3140,8 +3140,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
operating-points-v2 = <&pcie1_opp_table>;
- iommu-map = <0 &apps_smmu 0x1080 0x1>,
- <0x100 &apps_smmu 0x1081 0x1>;
+ iommu-map = <0 &apps_smmu 0x1080 0x0 0x1>,
+ <0x100 &apps_smmu 0x1081 0x0 0x1>;
interrupt-map = <0 0 0 1 &intc 0 0 GIC_ESPI 106 IRQ_TYPE_LEVEL_HIGH>,
<0 0 0 2 &intc 0 0 GIC_ESPI 107 IRQ_TYPE_LEVEL_HIGH>,
--
2.55.0
next prev parent reply other threads:[~2026-09-25 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 10:13 [PATCH 1/4] arm64: dts: qcom: hawi: Sort IPCC client IDs Mukesh Ojha
2026-09-25 10:13 ` Mukesh Ojha [this message]
2026-09-25 10:23 ` [PATCH 2/4] arm64: dts: qcom: hawi: Fix PCIe IOMMU maps Konrad Dybcio
2026-09-25 10:13 ` [PATCH 3/4] arm64: dts: qcom: hawi: Enable SoCCP by default Mukesh Ojha
2026-09-25 10:19 ` Konrad Dybcio
2026-09-25 10:13 ` [PATCH 4/4] arm64: dts: qcom: hawi: Trivial fix Mukesh Ojha
2026-09-25 16:43 ` (subset) [PATCH 1/4] arm64: dts: qcom: hawi: Sort IPCC client IDs Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925101309.3826038-2-mukesh.ojha@oss.qualcomm.com \
--to=mukesh.ojha@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®