From: Andrew Morton <akpm@linux-foundation.org>
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: Anastasios Papagiannis <tasos.papagiannnis@gmail.com>,
linux-mm@kvack.org, liam@infradead.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/nommu: Reject wrapping ranges in access_remote_vm()
Date: Fri, 25 Sep 2026 16:04:53 -0700 [thread overview]
Message-ID: <20260925160453.7e7561edb77b5c4152675f7e@linux-foundation.org> (raw)
In-Reply-To: <arZzn0bwWqp7xTE5@gremlin>
On Fri, 25 Sep 2026 14:20:33 +0100 "Lorenzo Stoakes (ARM)" <ljs@kernel.org> wrote:
> BTW always feel free to nag if you're not getting review! Something things
> get missed. (Though I'd say wait at least a couple weeks before doing
> that!)
>
> On Wed, Sep 09, 2026 at 09:42:31AM +0300, Anastasios Papagiannis wrote:
> > The NOMMU implementation of access_process_vm() rejects address ranges
> > whose end wraps around, but access_remote_vm() bypasses this check even
> > though both functions delegate to __access_remote_vm().
> >
> > Move the wraparound check into __access_remote_vm() so it applies to
> > both entry points.
> >
> > This is originally reported in [1].
> >
> > [1] https://lore.kernel.org/bpf/4ef240a5bea36ff84df9589671367832860795159386a4c8fba546a0fa8b786f@mail.kernel.org/
>
> Probably better to drop this big and make this a Link: tag.
My scripts (after much recent LLM-driven fancification) made this
change automatically! It became
Closes: https://lore.kernel.org/bpf/4ef240a5bea36ff84df9589671367832860795159386a4c8fba546a0fa8b786f@mail.kernel.org/ [1]
But scripts didn't figure out how to add a Reported-by: as well.
> >
> > Fixes: f55f199b7d76 ("NOMMU: implement access_remote_vm")
>
> Cc: stable I think?
Well why.
I see in [1] "causing memory disclosure or a bus fault". OK, we care
about that. So the changelog should tell people this very important
info and should explain the circumstances which can lead to the failure.
> > Signed-off-by: Anastasios Papagiannis <tasos.papagiannnis@gmail.com>
>
> Seems reasonable to me! So:
>
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Cool.
prev parent reply other threads:[~2026-09-25 23:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 6:42 Anastasios Papagiannis
2026-09-09 7:13 ` Andrew Morton
2026-09-09 20:11 ` Hajime Tazaki
2026-09-25 13:08 ` Lorenzo Stoakes (ARM)
2026-09-25 13:20 ` Lorenzo Stoakes (ARM)
2026-09-25 23:04 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925160453.7e7561edb77b5c4152675f7e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bpf@vger.kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=tasos.papagiannnis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®