From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy2-f42.google.com (mail-dy2-f42.google.com [74.125.229.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D118040B0EF for ; Fri, 25 Sep 2026 17:58:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790359114; cv=none; b=lz2Lshbm4Uxsu1U+AO4JVLL38TllJwhDKRPqypBdiJBCUjTGx6LENeDkavW7hEExBhujrVeWsJelR8FwZS5T08V8tyUVe/CpgRwXzZ8snsyjKjIx2lreDNj6HfS4YoKG8qwL4JTkAHzzZ5wGIFWq0/4h2LgOUpDgqzTomc8Lp1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790359114; c=relaxed/simple; bh=jqoaoIlPOoHSlj9+wXRIMUwDN4RhN1jA+h8Gn7rewq8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RoMh2L7aoUz1smql8ISudN8EVgvgqaq34+Ff0zLu7T1la0bIuJyPYI+W/3eTtqy/1ntAyyyfDXEjebYKZxKmWgw8n0yD8dQpKDU6alkW3VaLU3HlAIXXhcv/LhVihpNuRjaMX3zYEIBMQFN2o36ELCFbIxfQJ+srXZ6Df5A5cAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=leOcBCFS; arc=none smtp.client-ip=74.125.229.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="leOcBCFS" Received: by mail-dy2-f42.google.com with SMTP id 5a478bee46e88-3429bca3880so318694eec.3 for ; Fri, 25 Sep 2026 10:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790359107; x=1790963907; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=AyFVOhvCGQIiViIbb7+gjM5CZL+S3jyqr2aX/1FUz8c=; b=leOcBCFSpJ664aT36nbueNaKIasNAJD9iYgSZuozrxRJIDpSIlUR19RR22hj2L7CEH yCrrvmD9a+8Y1O4IIOL7bdeRhO8SSdSU38bB9FsMteUEas3WlR4y8bDKYFRE0/yjcEwy pTc5kiwMDM9376f1IBE4kbZFMV34DTGaPaz3F3h7b5VlDI9HcsbKp2ZuuAMPyHlEMHzI jAEBGl050H0ZtONOpgZ1UNYedw9eKX62jenlh2b28Y3hQUvS17w2DnK2jz3DsCnkN1Uh 9C5Ku1gXeZ/Fp5abH/2X0EjsZmFY0Qa7KjjrLi7i060ksSsCMU4uDXZc7MSeveFBMf+M 3Usg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790359107; x=1790963907; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AyFVOhvCGQIiViIbb7+gjM5CZL+S3jyqr2aX/1FUz8c=; b=yA84yOgtgUCooDBWnH5lpPjfBaUrZXRTrg3xbpoeKE3/BepYXf/votYpprGpnRbDeG j1TO44kP9yUR+8zkahR/3zypzDsKc6RJjnFueI3jI719ovM4TBaPJfElNN5VFE2CkIn0 EuddCT/RzUYIMQtzmJuJyByewuWxZ2ueWvjdECaS64ZAkAZHpFlYYwagExmNQ/7Wb1+k PcFkJts59a9vV6002S3nDe/mZF4qcd3GWLCKJZm1LiQ0pWNdhG/xgSyrZ1VSMmBYCMA4 lDAnE79+VLM2obGM/YLoDAQwDYniMb+u8dDmmbIcaBYYBcbZ437ZNkjnJ9nMMjWOX236 fE7g== X-Forwarded-Encrypted: i=1; AKwUvBzMpXSzAlo8dscBo4+Enpcc0FmPE/DTuNKBg1MhuCwv6VWw6uTueDgLzMhbf0OLWIcSAhCwaia0vzwG7B8=@vger.kernel.org X-Gm-Message-State: AFuF++kI01/Av3x/Id9ElJZcN/IyEvqKryMkgcUxUaKzxmEWMW3Q740g sCfoWOyPIoVZ3c78oUzaJWmlk2wcwDz7gOukXQgJ0krvnMBhnsuL7fcv X-Gm-Gg: AYBFou1mBiSks7GnqNtK9GCmgiJ+WidkB8l0gpf11JlChzxZvdQkFgIpwQ9wCHsjzjk cPMCaOqCfpDsgqUnb4ryVis7+qm0oGLjZaeAPw6n0vkL+pRKkX2ycIQAWFiK6wm1mUCk7o0dLep D2G+VIRUWbAWCIY2vLZ07KSVGP6UWiXU5/AbGGhQSPRPrwpDvoXhfB8phHlqLcrW8sfz5LQ14Bg JZzccrbw/UnV0FFk+UT7EFeatinHu47Vivk0ICShqSSIy69yzaAyq5aWWcZz+qkP359EJhPrcS1 2rCCdDDn+vFMji04UsQS5b+1PXS/oflxX3gf2Yx2WAj0VpQ8s8P75HXqtotvylRxNGSjf0cvVI0 xlFcQSGykWae9ExJr9++hn0xcbzR2u2EpI3XGmbenlLFof/MAAyw7xkfaiPyWUyoWc312+eyGBv 1O3LELJoO3wboCjxDPeh69FM/kC9a5oHbRQ4aGom3ztjcfJQYw7lluXQ5z4ZEldSM= X-Received: by 2002:a05:7300:c394:b0:33b:fae8:bbd6 with SMTP id 5a478bee46e88-3426febb742mr935256eec.2.1790359107087; Fri, 25 Sep 2026 10:58:27 -0700 (PDT) Received: from beelink.. ([187.13.30.172]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-34145c17074sm6579075eec.26.2026.09.25.10.58.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 10:58:26 -0700 (PDT) From: Aldo Ariel Panzardo To: airlied@redhat.com, dakr@kernel.org, bskeggs@nvidia.com Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Aldo Ariel Panzardo Subject: [PATCH] drm/nouveau: cancel irq_work before freeing connector Date: Fri, 25 Sep 2026 14:58:19 -0300 Message-ID: <20260925175819.3699225-1-qwe.aldo@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit nouveau_connector_irq() schedules irq_work on the system workqueue. nouveau_connector_destroy() calls nvif_event_dtor() which unregisters the interrupt event source so no new callbacks will fire, but it does not drain the system workqueue. If a work item was already queued, nouveau_dp_irq() can run after kfree(connector) and dereference freed memory. Add cancel_work_sync() after nvif_event_dtor() so any in-flight or pending irq_work completes before the connector is freed. Cc: stable@vger.kernel.org Signed-off-by: Aldo Ariel Panzardo --- drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c index XXXXXXX..YYYYYYY 100644 --- a/drivers/gpu/drm/nouveau/nouveau_connector.c +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c @@ -395,6 +395,7 @@ nouveau_connector_destroy(struct drm_connector *connector) struct nouveau_connector *nv_connector = nouveau_connector(connector); nvif_event_dtor(&nv_connector->irq); nvif_event_dtor(&nv_connector->hpd); + cancel_work_sync(&nv_connector->irq_work); kfree(nv_connector->edid); drm_connector_unregister(connector); drm_connector_cleanup(connector);