From: Rosen Penev <rosenp@gmail.com>
To: linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Rosen Penev <rosenp@gmail.com>,
linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL
DRIVERS)
Subject: [PATCH] serial: cpm_uart: use irq variable for platform_get_irq()
Date: Fri, 25 Sep 2026 11:15:30 -0700 [thread overview]
Message-ID: <20260925181530.52953-1-rosenp@gmail.com> (raw)
struct uart_port has its irq member as an unsigned int, which does not
work when platform_get_irq() returns an error.
Use a local irq variable to handle this and write to struct uart_port's
irq member when platform_get_irq() succeeds. On success, it returns an
IRQ >= 0, which is representable by unsigned int.
Fixes: 831603b3e8aa ("serial: cpm_uart: replace irq_of_parse_and_map with platform_get_irq")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202609251916.1XlVHLwd-lkp@intel.com/
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/tty/serial/cpm_uart.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/cpm_uart.c b/drivers/tty/serial/cpm_uart.c
index 39f54bb7b485..ca0acccd3dd8 100644
--- a/drivers/tty/serial/cpm_uart.c
+++ b/drivers/tty/serial/cpm_uart.c
@@ -1517,6 +1517,7 @@ static int cpm_uart_probe(struct platform_device *ofdev)
{
int index = probe_index++;
struct uart_cpm_port *pinfo = &cpm_uart_ports[index];
+ int irq;
int ret;
pinfo->port.line = index;
@@ -1524,14 +1525,15 @@ static int cpm_uart_probe(struct platform_device *ofdev)
if (index >= UART_NR)
return -ENODEV;
+ irq = platform_get_irq(ofdev, 0);
+ if (irq < 0)
+ return irq;
+
platform_set_drvdata(ofdev, pinfo);
/* initialize the device pointer for the port */
pinfo->port.dev = &ofdev->dev;
-
- pinfo->port.irq = platform_get_irq(ofdev, 0);
- if (pinfo->port.irq < 0)
- return pinfo->port.irq;
+ pinfo->port.irq = irq;
ret = cpm_uart_init_port(ofdev->dev.of_node, pinfo);
if (!ret)
--
2.55.0
reply other threads:[~2026-09-25 18:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925181530.52953-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®