From: Rosen Penev <rosenp@gmail.com>
To: linux-serial@vger.kernel.org
Cc: Vineet Gupta <vgupta@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-snps-arc@lists.infradead.org (open list:SYNOPSYS ARC
ARCHITECTURE),
linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL
DRIVERS)
Subject: [PATCH] serial: arc_uart: Use platform IRQ helper
Date: Fri, 25 Sep 2026 11:30:50 -0700 [thread overview]
Message-ID: <20260925183050.56839-1-rosenp@gmail.com> (raw)
Avoid calling irq_dispose_mapping() by letting the platform_device
machinery handle it. Also enable possibility of handling -EPROBE_DEFER
and other errors. Handle as early as possible to avoid doing unnecessary
work.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/tty/serial/arc_uart.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
index 3988e5958896..b46b057a181b 100644
--- a/drivers/tty/serial/arc_uart.c
+++ b/drivers/tty/serial/arc_uart.c
@@ -30,7 +30,6 @@
#include <linux/tty_flip.h>
#include <linux/serial_core.h>
#include <linux/io.h>
-#include <linux/of_irq.h>
#include <linux/of_address.h>
/*************************************
@@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev)
struct arc_uart_port *uart;
struct uart_port *port;
int dev_id;
+ int irq;
u32 val;
/* no device tree device */
if (!np)
return -ENODEV;
+ irq = platform_get_irq(pdev, 0);
+ if (irq < 0)
+ return irq;
+
dev_id = of_alias_get_id(np, "serial");
if (dev_id < 0)
dev_id = 0;
@@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev)
return PTR_ERR(port->membase);
}
- port->irq = irq_of_parse_and_map(np, 0);
+ port->irq = irq;
port->dev = &pdev->dev;
port->iotype = UPIO_MEM;
--
2.55.0
reply other threads:[~2026-09-25 18:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925183050.56839-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®