From: Jacob Pan <jacob.pan@linux.microsoft.com>
To: iommu@lists.linux.dev
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Nicolin Chen <nicolinc@nvidia.com>,
Kevin Tian <kevin.tian@intel.com>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>, Wei Liu <wei.liu@kernel.org>,
"K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Dexuan Cui <decui@microsoft.com>, Long Li <longli@microsoft.com>,
linux-hyperv@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Vasant Hegde <vasant.hegde@amd.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
Mukesh Rathor <mukeshrathor@microsoft.com>,
John Starks <John.Starks@microsoft.com>,
Souradeep Chakrabarti <schakrabarti@microsoft.com>,
Yu Zhang <zhangyu1@linux.microsoft.com>,
Easwar Hariharan <eahariha@linux.microsoft.com>,
Alex Williamson <alex@shazbot.org>
Subject: [PATCH RFC 6/9] mshv: Add prepare callback for external device attach
Date: Fri, 25 Sep 2026 12:07:39 -0700 [thread overview]
Message-ID: <20260925190742.1575380-7-jacob.pan@linux.microsoft.com> (raw)
In-Reply-To: <20260925190742.1575380-1-jacob.pan@linux.microsoft.com>
Unlike VFIO/IOMMUFD paging domains, external attach bypasses the DMA
map flow that pins mapped memory. The ownership model is also different
for MSHV external attach: MSHV, as the L0 hypervisor, owns address
translation and DMA fault handling.
Guest memory must therefore be pinned through the MSHV/userspace VMM
contract before it is mapped for DMA, rather than by the VFIO/IOMMUFD
pin-and-map flow.
Add a partition-file prepare_attach callback that lets MSHV apply its
guest-memory pinning policy and perform any other preparation required
before an external device is attached. A later external-domain patch
invokes the callback through the vIOMMU-held VM file.
The per-region conversion helper is intentionally left as a stub for
this RFC to show where MSHV will pin guest memory.
Assisted-by: GPT-5.6 Sol
Signed-off-by: Jacob Pan <jacob.pan@linux.microsoft.com>
---
drivers/hv/hv_common.c | 24 ++++++++++++++++++++++-
drivers/hv/mshv_regions.c | 6 ++++++
drivers/hv/mshv_root.h | 1 +
drivers/hv/mshv_root_main.c | 35 ++++++++++++++++++++++++++++++++++
include/asm-generic/mshyperv.h | 7 +++++++
5 files changed, 72 insertions(+), 1 deletion(-)
diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
index d259cb833376..7acea1bceae1 100644
--- a/drivers/hv/hv_common.c
+++ b/drivers/hv/hv_common.c
@@ -46,7 +46,8 @@ int mshv_partition_file_ops_register(const struct mshv_partition_file_ops *ops)
{
int ret = 0;
- if (!ops || !ops->file_is_partition || !ops->get_partid)
+ if (!ops || !ops->file_is_partition || !ops->get_partid ||
+ !ops->prepare_attach)
return -EINVAL;
mutex_lock(&mshv_partition_file_ops_lock);
@@ -106,6 +107,27 @@ u64 mshv_partition_file_get_partid(struct file *file)
}
EXPORT_SYMBOL_GPL(mshv_partition_file_get_partid);
+int mshv_partition_file_prepare_attach(struct file *file)
+{
+ const struct mshv_partition_file_ops *ops;
+ int ret = -EOPNOTSUPP;
+
+ if (!file)
+ return -EINVAL;
+
+ mutex_lock(&mshv_partition_file_ops_lock);
+ ops = mshv_partition_file_ops;
+ if (ops && ops->file_is_partition(file))
+ ret = 0;
+ mutex_unlock(&mshv_partition_file_ops_lock);
+
+ if (!ret)
+ ret = ops->prepare_attach(file);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(mshv_partition_file_prepare_attach);
+
/*
* ms_hyperv and hv_nested are defined here with other
* Hyper-V specific globals so they are shared across all architectures and are
diff --git a/drivers/hv/mshv_regions.c b/drivers/hv/mshv_regions.c
index dddaade31b5d..b98e5c3e7819 100644
--- a/drivers/hv/mshv_regions.c
+++ b/drivers/hv/mshv_regions.c
@@ -324,6 +324,12 @@ int mshv_region_pin(struct mshv_mem_region *region)
return ret < 0 ? ret : -ENOMEM;
}
+int mshv_region_make_pinned(struct mshv_mem_region *region)
+{
+ /* Guest-memory pin conversion is not implemented in this RFC. */
+ return 0;
+}
+
static int mshv_region_chunk_unmap(struct mshv_mem_region *region,
u32 flags,
u64 page_offset, u64 page_count,
diff --git a/drivers/hv/mshv_root.h b/drivers/hv/mshv_root.h
index d57c26950203..d0f3a28abb3b 100644
--- a/drivers/hv/mshv_root.h
+++ b/drivers/hv/mshv_root.h
@@ -393,6 +393,7 @@ int mshv_region_unshare(struct mshv_mem_region *region);
int mshv_region_map(struct mshv_mem_region *region);
void mshv_region_invalidate(struct mshv_mem_region *region);
int mshv_region_pin(struct mshv_mem_region *region);
+int mshv_region_make_pinned(struct mshv_mem_region *region);
void mshv_region_put(struct mshv_mem_region *region);
int mshv_region_get(struct mshv_mem_region *region);
bool mshv_region_handle_gfn_fault(struct mshv_mem_region *region, u64 gfn);
diff --git a/drivers/hv/mshv_root_main.c b/drivers/hv/mshv_root_main.c
index 838ea6397c9f..fb422ed23662 100644
--- a/drivers/hv/mshv_root_main.c
+++ b/drivers/hv/mshv_root_main.c
@@ -2182,9 +2182,44 @@ static u64 mshv_partition_file_get_partid_impl(struct file *file)
return HV_PARTITION_ID_INVALID;
}
+static int mshv_partition_file_prepare_attach_impl(struct file *file)
+{
+ struct mshv_mem_region *region;
+ struct mshv_partition *partition;
+ int ret = 0;
+
+#if IS_ENABLED(CONFIG_IOMMUFD_TEST)
+ if (file->f_op == &mshv_fake_partition_fops)
+ return 0;
+#endif
+ if (file->f_op != &mshv_partition_fops)
+ return -EINVAL;
+
+ partition = file->private_data;
+ if (!partition)
+ return -EINVAL;
+
+ mutex_lock(&partition->pt_mutex);
+ if (partition->pt_regions_pinned)
+ goto out_unlock;
+
+ hlist_for_each_entry(region, &partition->pt_mem_regions, hnode) {
+ ret = mshv_region_make_pinned(region);
+ if (ret)
+ goto out_unlock;
+ }
+
+ partition->pt_regions_pinned = true;
+
+out_unlock:
+ mutex_unlock(&partition->pt_mutex);
+ return ret;
+}
+
static const struct mshv_partition_file_ops mshv_partition_file_ops = {
.file_is_partition = mshv_partition_file_is_valid,
.get_partid = mshv_partition_file_get_partid_impl,
+ .prepare_attach = mshv_partition_file_prepare_attach_impl,
};
static int
diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyperv.h
index ed7ab21d68a2..6af793444a4b 100644
--- a/include/asm-generic/mshyperv.h
+++ b/include/asm-generic/mshyperv.h
@@ -405,6 +405,7 @@ struct file;
struct mshv_partition_file_ops {
bool (*file_is_partition)(struct file *file);
u64 (*get_partid)(struct file *file);
+ int (*prepare_attach)(struct file *file);
};
#if IS_ENABLED(CONFIG_HYPERV)
@@ -413,6 +414,7 @@ void
mshv_partition_file_ops_unregister(const struct mshv_partition_file_ops *ops);
bool file_is_mshv_partition(struct file *file);
u64 mshv_partition_file_get_partid(struct file *file);
+int mshv_partition_file_prepare_attach(struct file *file);
#else
static inline int
mshv_partition_file_ops_register(const struct mshv_partition_file_ops *ops)
@@ -434,6 +436,11 @@ static inline u64 mshv_partition_file_get_partid(struct file *file)
{
return HV_PARTITION_ID_INVALID;
}
+
+static inline int mshv_partition_file_prepare_attach(struct file *file)
+{
+ return -EOPNOTSUPP;
+}
#endif
static inline int hv_deposit_memory(u64 partition_id, u64 status)
--
2.43.0
next prev parent reply other threads:[~2026-09-25 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 19:07 [RFC PATCH 0/9] iommu/iommufd: Add hypervisor external attach Jacob Pan
2026-09-25 19:07 ` [PATCH RFC 1/9] iommu: Introduce external attach domain type Jacob Pan
2026-09-25 19:07 ` [PATCH RFC 2/9] iommufd: Introduce hypervisor vIOMMU type Jacob Pan
2026-09-25 19:07 ` [PATCH RFC 3/9] iommufd: Add external HWPT support Jacob Pan
2026-09-25 19:07 ` [PATCH RFC 4/9] iommufd/selftest: Add hypervisor external attach backend Jacob Pan
2026-09-25 19:07 ` [PATCH RFC 5/9] mshv: Add partition file identity helper Jacob Pan
2026-09-25 19:07 ` Jacob Pan [this message]
2026-09-25 19:07 ` [PATCH RFC 7/9] iommu/hyperv: Split root IOMMU declarations Jacob Pan
2026-09-25 19:07 ` [PATCH RFC 8/9] iommu/hyperv: Add fd-backed vIOMMU support Jacob Pan
2026-09-25 19:07 ` [PATCH RFC 9/9] iommu/hyperv: Add IOMMUFD external domains Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925190742.1575380-7-jacob.pan@linux.microsoft.com \
--to=jacob.pan@linux.microsoft.com \
--cc=John.Starks@microsoft.com \
--cc=alex@shazbot.org \
--cc=aneesh.kumar@kernel.org \
--cc=arnd@arndb.de \
--cc=decui@microsoft.com \
--cc=eahariha@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mukeshrathor@microsoft.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=schakrabarti@microsoft.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=zhangyu1@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®