mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: drivers/tty/serial/cpm_uart.c:1533 cpm_uart_probe() warn: unsigned 'pinfo->port.irq' is never less than zero.
Date: Fri, 25 Sep 2026 19:42:45 +0200	[thread overview]
Message-ID: <202609251916.1XlVHLwd-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   165768bb70265b5c38cf0b73fafd75be235f8b14
commit: 831603b3e8aa3892de229fda846b2f859c518699 serial: cpm_uart: replace irq_of_parse_and_map with platform_get_irq
date:   3 months ago
config: powerpc-randconfig-r2202-20260925 (https://download.01.org/0day-ci/archive/20260925/202609251916.1XlVHLwd-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 16.1.0
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 831603b3e8aa ("serial: cpm_uart: replace irq_of_parse_and_map with platform_get_irq")
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609251916.1XlVHLwd-lkp@intel.com/

smatch warnings:
drivers/tty/serial/cpm_uart.c:1533 cpm_uart_probe() warn: unsigned 'pinfo->port.irq' is never less than zero.

vim +1533 drivers/tty/serial/cpm_uart.c

  1515	
  1516	static int cpm_uart_probe(struct platform_device *ofdev)
  1517	{
  1518		int index = probe_index++;
  1519		struct uart_cpm_port *pinfo = &cpm_uart_ports[index];
  1520		int ret;
  1521	
  1522		pinfo->port.line = index;
  1523	
  1524		if (index >= UART_NR)
  1525			return -ENODEV;
  1526	
  1527		platform_set_drvdata(ofdev, pinfo);
  1528	
  1529		/* initialize the device pointer for the port */
  1530		pinfo->port.dev = &ofdev->dev;
  1531	
  1532		pinfo->port.irq = platform_get_irq(ofdev, 0);
> 1533		if (pinfo->port.irq < 0)
  1534			return pinfo->port.irq;
  1535	
  1536		ret = cpm_uart_init_port(ofdev->dev.of_node, pinfo);
  1537		if (!ret)
  1538			return uart_add_one_port(&cpm_reg, &pinfo->port);
  1539	
  1540		return ret;
  1541	}
  1542	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-09-25 17:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202609251916.1XlVHLwd-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=rosenp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®